Details

Reviewers

tusooa

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T164: Cannot download file from matrix.org

Summary

Add GetContentJobV1 for the new download endpoint that needs authorization

Type: add

Test Plan

N/A

Diff Detail

Repository

rL libkazv

Branch

nannanko/get-content-job-v1

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 399
Build 781: GitLab CI for libkazv
Build 780: arc lint + arc unit

Event Timeline

nannanko created this revision.May 26 2025, 10:09 PM

Owners added a reviewer: O1: the Kazv Project.May 26 2025, 10:09 PM

nannanko added a child revision: D217: Add fallback endpoint for download.May 26 2025, 10:15 PM

nannanko added a task: T164: Cannot download file from matrix.org.May 28 2025, 1:40 AM

nannanko mentioned this in D217: Add fallback endpoint for download.May 28 2025, 6:06 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 28 2025, 6:23 PM

Harbormaster failed remote builds in B372: Diff 607!

Harbormaster completed remote builds in B372: Diff 607.May 28 2025, 7:51 PM

nannanko requested review of this revision.May 28 2025, 7:51 PM

nannanko planned changes to this revision.Sat, May 31, 7:05 PM

nannanko requested review of this revision.Wed, Jun 4, 6:36 AM

nannanko planned changes to this revision.Wed, Jun 4, 3:13 PM

Add function to detect whether the server supports the specified version

Harbormaster completed remote builds in B386: Diff 626.Sat, Jun 14, 7:15 PM

nannanko planned changes to this revision.Sat, Jun 14, 7:18 PM

nannanko added a task: T29: Parse matrix links.Sat, Jun 21, 7:27 PM

nannanko removed a task: T29: Parse matrix links.

Add tests

Fixed copyright

Harbormaster completed remote builds in B391: Diff 633.Tue, Jun 24, 8:06 PM

Harbormaster failed remote builds in B392: Diff 634!Tue, Jun 24, 8:18 PM

Harbormaster completed remote builds in B392: Diff 634.Tue, Jun 24, 10:01 PM

tusooa requested changes to this revision.Sat, Jun 28, 4:20 PM

tusooa added inline comments.

src/client/client.hpp
386–392	declare in header and implement in cpp file

This revision now requires changes to proceed.Sat, Jun 28, 4:20 PM

Declare mxcUriToHttpV1 in header and define in source

nannanko marked an inline comment as done.Sat, Jun 28, 5:27 PM

Harbormaster completed remote builds in B399: Diff 642.Sat, Jun 28, 5:53 PM

tusooa accepted this revision.Sat, Jun 28, 7:02 PM

This revision is now accepted and ready to land.Sat, Jun 28, 7:02 PM

Add GetContentJobV1 for the new download endpoint that needs authorization
AcceptedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 642

src/client/CMakeLists.txt

src/client/actions/auth.cpp

src/client/client-model.hpp

src/client/client.hpp

src/client/client.cpp

src/client/get-content-job-v1.hpp

src/client/get-content-job-v1.cpp

src/tests/CMakeLists.txt

src/tests/client/get-versions-test.cpp

Add GetContentJobV1 for the new download endpoint that needs authorizationAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 642

src/client/CMakeLists.txt

src/client/actions/auth.cpp

src/client/client-model.hpp

src/client/client.hpp

src/client/client.cpp

src/client/get-content-job-v1.hpp

src/client/get-content-job-v1.cpp

src/tests/CMakeLists.txt

src/tests/client/get-versions-test.cpp

Add GetContentJobV1 for the new download endpoint that needs authorization
AcceptedPublic
Actions

Revision Contents
Changeset List