Page MenuHomePhorge

Use json object instead of QSet for sets
ClosedPublic

Authored by tusooa on Dec 18 2024, 2:28 PM.
Tags
None
Referenced Files
F85802782: D208.1791424934.diff
Tue, Oct 6, 7:02 PM
F85802773: D208.1791424891.diff
Tue, Oct 6, 7:01 PM
F85802752: D208.1791424549.diff
Tue, Oct 6, 6:55 PM
F85802629: D208.1791418478.diff
Tue, Oct 6, 5:14 PM
Subscribers
None

Details

Summary

This is a workaround for a crash that is an upstream Qt bug. Also JS object is more performant in checking whether something exists as an element in the set, as QSet is converted to a JS array when passed to QML.

Type: fix

Upstream: https://bugreports.qt.io/browse/QTBUG-131961

Test Plan

Verify pinning and unpinning events still work. Verify timeline gaps still work.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 332
Build 650: GitLab CI for kazv
Build 649: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 18 2024, 5:02 PM
This revision was automatically updated to reflect the committed changes.