Page MenuHomePhorge

Use FileHandler for all images and avatars
ClosedPublic

Authored by tusooa on Oct 16 2024, 4:29 PM.
Tags
None
Referenced Files
F112322: D192.1732293444.diff
Thu, Nov 21, 8:37 AM
F112224: D192.1732282051.diff
Thu, Nov 21, 5:27 AM
F112221: D192.1732281066.diff
Thu, Nov 21, 5:11 AM
Subscribers
None

Details

Summary

This commit repurposes AvatarAdapter and creates a new component, ImageAdapter, which accept an mxc uri and display the image represented by it, through FileHandler. It provides caching for the images, thus improves loading speed and enhances metadata privacy. It also makes the client better prepared for authenticated media.

Type: add

Test Plan

Verify unit tests pass.

In the room list view, verify avatars can be displayed.

Change the order of two rooms with different avatars (e.g. by sending a message to a room), and verify that the avatars are displayed properly.

Open the sticker picker with lots of stickers, and open it again in another room. Verify that the stickers load much faster.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

tusooa removed a reviewer: servant.
This revision is now accepted and ready to land.Sat, Oct 26, 6:11 AM