Page MenuHomePhorge

Display reactions under the reacted event
ClosedPublic

Authored by tusooa on Fri, Nov 1, 7:10 PM.

Details

Summary

This commit provides a aggregated view of all reactions under some event. You can click on the button to react or unreact with keys already present as a reaction.

Type: add

BUG: https://iron.lily-is.land/T53

Test Plan

Go to an event. React from another account.
Verify in kazv that there is a reaction button displayed under the event, and it is unhighlighted.
Click on the left side of the button (reaction content). Verify it is highlighted and the count is updated to 2. Verify no standalone reaction event is displayed.
Click on the left side of the button again. Verify it is unhighlighted and the count is updated to 1. Verify a standalone event is displayed as deleted.

Note: Clicking on the count does not do anything yet, but in the future it can be made to show who has reacted.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 310
Build 608: GitLab CI for kazv
Build 607: arc lint + arc unit

Event Timeline

tusooa requested review of this revision.Fri, Nov 1, 7:25 PM

Fix reaction text color

nannanko subscribed.
nannanko added inline comments.
src/contents/ui/EventReactions.qml
21

I saw in the documentation that the default value is 0. Are there any benefits to setting it to -1?

This revision is now accepted and ready to land.Sat, Nov 9, 3:56 AM
src/contents/ui/EventReactions.qml
21

It is there to make the two borders (right border of the left button and left border of the right button) overlap.

It generates the following layout:

[ content | count ], where [ and ] represent a rounded border and | represents an unrounded one.