create-room-page-visibility is not used anywhere, this revision removed them.
cmn-Hans miss create-room-page-type and create-room-invite items, this revision added them.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T112: Missing Mandarin translation for create room invitations
- Commits
- rK7602d918db87: Remove useless items and added missing items of create-room-page series
N/A
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- nannanko/stacked
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 307 Build 602: GitLab CI for kazv Build 601: arc lint + arc unit
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
Comment Actions
] wc -l src/l10n/cmn-Hans/100-ui.ftl 413 src/l10n/cmn-Hans/100-ui.ftl ] wc -l src/l10n/en/100-ui.ftl 435 src/l10n/en/100-ui.ftl
seems there are still a lot of things missing in mandarin
Comment Actions
No, there is only one name error rather than lack of translation items.
$ grep '=' src/l10n/cmn-Hans/100-ui.ftl | awk '{print $1}' > ~/.tmp/cmn $ grep '=' src/l10n/en/100-ui.ftl | awk '{print $1}' > ~/.tmp/en $ diff ~/.tmp/{cmn,en} 308c308 < user-page-ban-user-confirm-dialog-titile --- > user-page-ban-user-confirm-dialog-title
Maybe we need a CI script to check the consistency of translation items.
The collide of line counts is due to the different formats for some same items.
e.g.
// cmn-Hans
room-list-view-room-item-unread-notification-count-text = { $count } 条未读通知
// en
room-list-view-room-item-unread-notification-count-text = { $count } unread {
$count ->
[1] message
*[other] messages
}