Page MenuHomePhorge
Differential D184

Set cryptopp as private link lib for libkazvcrypto
ClosedPublic
Actions

Authored by tusooa on Sep 13 2024, 7:16 PM.
Tags
None
Referenced Files
F2617267: D184.1751782038.diff
Fri, Jul 4, 11:07 PM
F2617262: D184.1751782022.diff
Fri, Jul 4, 11:07 PM
F2614942: D184.1751759356.diff
Fri, Jul 4, 4:49 PM
F2613683: D184.1751735289.diff
Fri, Jul 4, 10:08 AM
F2613620: D184.1751735031.diff
Fri, Jul 4, 10:03 AM
F2613618: D184.1751735029.diff
Fri, Jul 4, 10:03 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rLbc0f306b9a90: Set cryptopp as private link lib for libkazvcrypto
Summary

The public interface of libkazvcrypto does not depend on cryptopp. Thus we can remove it from the find_dependency calls.

Type: fix

Test Plan

Verify kazv still compiles under this commit.

Diff Detail

Repository
rL libkazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 292
Build 572: GitLab CI for libkazv
Build 571: arc lint + arc unit

Event Timeline

tusooa created this revision.Sep 13 2024, 7:16 PM
Owners added a reviewer: O1: the Kazv Project.Sep 13 2024, 7:16 PM
Herald added a reviewer: servant. · View Herald TranscriptSep 13 2024, 7:16 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B292: Diff 482.Sep 13 2024, 7:53 PM
tusooa requested review of this revision.Sep 13 2024, 7:53 PM
tusooa edited the summary of this revision. (Show Details)Sep 14 2024, 8:19 AM
tusooa removed a reviewer: servant.
nannanko accepted this revision.Sep 16 2024, 8:35 AM
This revision is now accepted and ready to land.Sep 16 2024, 8:35 AM
Closed by commit rLbc0f306b9a90: Set cryptopp as private link lib for libkazvcrypto. · Explain WhySep 28 2024, 6:21 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rLbc0f306b9a90: Set cryptopp as private link lib for libkazvcrypto.

Revision Contents
Changeset List

Diff 482

View Options

CMakeLists.txt

Loading...
View Options

cmake/libkazvConfig.cmake

Loading...
View Options

src/crypto/CMakeLists.txt

Loading...