Page MenuHomePhorge
Differential D177

Fix the problem that kazv cannot be closed when cached files
ClosedPublic
Actions

Authored by nannanko on Aug 24 2024, 3:27 AM.
Tags
None
Referenced Files
F112402: D177.1732308582.diff
Thu, Nov 21, 12:49 PM
F112332: D177.1732294023.diff
Thu, Nov 21, 8:47 AM
F112302: D177.1732290943.diff
Thu, Nov 21, 7:55 AM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rK70d40937b597: Fix the problem that kazv cannot be closed when cached files
Summary

Fixed the problem that kazv cannot be closed when cached files.

Type: fix

Test Plan

Open a room with uncached files and verify kazv starts caching the files.

Close kazv and verify that the cache jobs is killed immediately.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 280
Build 548: GitLab CI for kazv
Build 547: arc lint + arc unit

Event Timeline

nannanko created this revision.Aug 24 2024, 3:27 AM
Owners added a reviewer: O1: the Kazv Project.Aug 24 2024, 3:27 AM
Herald added a reviewer: servant. · View Herald TranscriptAug 24 2024, 3:27 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B280: Diff 467.Aug 24 2024, 3:43 AM
nannanko requested review of this revision.Aug 24 2024, 3:43 AM
nannanko edited the summary of this revision. (Show Details)Aug 24 2024, 6:55 AM
nannanko removed a reviewer: servant.
tusooa requested changes to this revision.Aug 24 2024, 5:38 PM
tusooa added inline comments.
src/kazv-io-manager.cpp
188–191
This revision now requires changes to proceed.Aug 24 2024, 5:38 PM
nannanko marked an inline comment as done.Aug 24 2024, 6:08 PM
nannanko added inline comments.
src/kazv-io-manager.cpp
188–191

It don't work because the cancel() will cause the job to be removed from cacheJobs, so iterators and loops cannot be used reliably.

nannanko updated this revision to Diff 472.Aug 31 2024, 7:21 AM
nannanko marked an inline comment as done.
  • Fixed the problem that kazv cannot be closed when cached files
nannanko added a comment.Aug 31 2024, 7:22 AM

Added comment on why loops cannot be used directly on m_d->cacheJobs

Harbormaster completed remote builds in B284: Diff 472.Aug 31 2024, 7:37 AM
tusooa retitled this revision from Fixed the problem that kazv cannot be closed when cached files to Fix the problem that kazv cannot be closed when cached files.Aug 31 2024, 7:03 PM
tusooa accepted this revision.Sep 1 2024, 3:21 PM
This revision is now accepted and ready to land.Sep 1 2024, 3:21 PM
Closed by commit rK70d40937b597: Fix the problem that kazv cannot be closed when cached files. · Explain WhySep 4 2024, 3:18 AM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK70d40937b597: Fix the problem that kazv cannot be closed when cached files.

Revision Contents
Changeset List

PathSizePackages
src/
9 linesO1: the Kazv Project

Diff 467

View Options

src/kazv-io-manager.cpp

Loading...