Page MenuHomePhorge
Differential D167

Fix lint ci
ClosedPublic
Actions

Authored by tusooa on Aug 12 2024, 4:35 PM.
Tags
None
Referenced Files
F114845: D167.1732583038.diff
Sun, Nov 24, 5:03 PM
F114694: D167.1732569467.diff
Sun, Nov 24, 1:17 PM
F114693: D167.1732569463.diff
Sun, Nov 24, 1:17 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK002424e4650d: Fix lint ci
Summary

The ci for lint was not properly run because in some runners the default image is ubuntu, while on others it is alpine. The alpine images does not support --exclude-dir and thus it reports a false negative. This fixes it.

Type: skip

Test Plan

Verify CI passes.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Aug 12 2024, 4:35 PM
Owners added a reviewer: O1: the Kazv Project.Aug 12 2024, 4:35 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 12 2024, 4:52 PM
Harbormaster failed remote builds in B265: Diff 438!
tusooa requested review of this revision.Aug 12 2024, 5:11 PM
nannanko accepted this revision.Aug 13 2024, 10:23 PM
This revision is now accepted and ready to land.Aug 13 2024, 10:23 PM
This revision was landed with ongoing or failed builds.Aug 14 2024, 6:00 PM
Closed by commit rK002424e4650d: Fix lint ci. · Explain Why
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK002424e4650d: Fix lint ci.

Revision Contents
Changeset List

Diff 450

View Options

.gitlab-ci.yml

Loading...
View Options

src/contents/ui/ReactToEventPopup.qml

Loading...