Page MenuHomePhorge
Differential D159

Port InboundGroupSession to vodozemac
ClosedPublic
Actions

Authored by tusooa on Aug 6 2024, 7:57 PM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T125: Migrate to vodozemac
Commits
rLd938af678492: Port InboundGroupSession to vodozemac
Summary

This uses libvodozemac for InboundGroupSession.

Type: add

CCBUG: https://iron.lily-is.land/T125

Test Plan

Verify unit tests pass. Build kazv against this. Verify you can decrypt messages in kazv.

Diff Detail

Repository
rL libkazv
Branch
tusooa/inbound-group-session
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 251
Build 490: GitLab CI for libkazv
Build 489: arc lint + arc unit

Event Timeline

tusooa created this revision.Aug 6 2024, 7:57 PM
Owners added a reviewer: O1: the Kazv Project.Aug 6 2024, 7:57 PM
tusooa added a comment.Aug 6 2024, 7:57 PM

TODO:

  • check error handling
  • add tests for error handling
  • add tests for libolm -> vodozemac conversion
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 6 2024, 7:58 PM
Harbormaster failed remote builds in B245: Diff 412!
tusooa updated this revision to Diff 414.Aug 6 2024, 10:13 PM

Test more

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 6 2024, 10:14 PM
Harbormaster failed remote builds in B247: Diff 414!
tusooa added a task: T125: Migrate to vodozemac.Aug 6 2024, 10:17 PM
tusooa updated this revision to Diff 416.Aug 7 2024, 3:16 PM

Add test for InboundGroupSession ctor error handling

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 3:18 PM
Harbormaster failed remote builds in B248: Diff 416!
tusooa added a parent revision: D158: Find vodozemac as a dependency.Aug 7 2024, 6:37 PM
tusooa added a parent revision: D157: Add generate-libolm-crypto-dump tool.
tusooa added a child revision: D160: Port OutboundGroupsession to vodozemac.
tusooa updated this revision to Diff 419.Aug 7 2024, 8:06 PM

Prepend vodozemac:: namespace

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 8:08 PM
Harbormaster failed remote builds in B251: Diff 419!
tusooa updated this revision to Diff 422.Aug 8 2024, 4:21 PM

check decrypt() error

tusooa updated this revision to Diff 423.Aug 8 2024, 4:28 PM

Check error when decrypting

Harbormaster completed remote builds in B254: Diff 422.Aug 8 2024, 5:22 PM
Harbormaster completed remote builds in B255: Diff 423.Aug 8 2024, 5:51 PM
tusooa requested review of this revision.Aug 8 2024, 5:51 PM
nannanko accepted this revision.Aug 10 2024, 1:43 AM
This revision is now accepted and ready to land.Aug 10 2024, 1:43 AM
Closed by commit rLd938af678492: Port InboundGroupSession to vodozemac. · Explain WhyAug 10 2024, 12:13 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rLd938af678492: Port InboundGroupSession to vodozemac.

Revision Contents
Changeset List

Diff 419

View Options

src/base/maybe.hpp

Loading...
View Options

src/crypto/CMakeLists.txt

Loading...
View Options

src/crypto/crypto-util-p.hpp

Loading...
View Options

src/crypto/inbound-group-session-p.hpp

Loading...
View Options

src/crypto/inbound-group-session.cpp

Loading...
View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/crypto/crypto-test-resource.hpp

Loading...
View Options

src/tests/crypto/inbound-group-session-test.cpp

Loading...