Differential D144

Port away from legacy implicit conversions
ClosedPublic
Actions

Authored by tusooa on Jul 23 2024, 10:04 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T121: Port away from implicit string literal -> QString conversion

Commits

rK12bd8059aae6: Port away from legacy implicit conversions

Summary

This adds back the compiler defs that disables implicit conversions.

Type: skip

BUG: https://iron.lily-is.land/T121

Test Plan

Verify that kazv still works.

Diff Detail

Repository

rK kazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 23 2024, 10:04 PM

Owners added a reviewer: O1: the Kazv Project.Jul 23 2024, 10:04 PM

tusooa added a task: T121: Port away from implicit string literal -> QString conversion.Jul 23 2024, 10:05 PM

Harbormaster completed remote builds in B218: Diff 366.Jul 23 2024, 10:19 PM

tusooa requested review of this revision.Jul 23 2024, 10:19 PM

nannanko accepted this revision.Jul 24 2024, 12:30 AM

This revision is now accepted and ready to land.Jul 24 2024, 12:30 AM

Closed by commit rK12bd8059aae6: Port away from legacy implicit conversions. · Explain WhyJul 24 2024, 2:34 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK12bd8059aae6: Port away from legacy implicit conversions.

Revision Contents
Changeset List

Path

Size

Packages

7 lines

src/

10 lines

14 lines

14 lines

8 lines

16 lines

14 lines

27 lines

2 lines

13 lines

16 lines

matrix-sticker-pack.cpp

7 lines

11 lines

2 lines

shortcuts/

4 lines

tests/

kazv-markdown-test.cpp

7 lines

O1: the Kazv Project

matrix-event-test.cpp

11 lines

O1: the Kazv Project

matrix-link-test.cpp

60 lines

O1: the Kazv Project

matrix-promise-test.cpp

3 lines

O1: the Kazv Project

matrix-room-list-test.cpp

19 lines

O1: the Kazv Project

matrix-room-member-list-model-test.cpp

23 lines

O1: the Kazv Project

matrix-room-timeline-test.cpp

31 lines

O1: the Kazv Project

matrix-sdk-sessions-test.cpp

3 lines

O1: the Kazv Project

matrix-sdk-test.cpp

9 lines

O1: the Kazv Project

matrix-sticker-pack-test.cpp

25 lines

O1: the Kazv Project

matrix-user-given-attrs-map-test.cpp

11 lines

O1: the Kazv Project

quick-tests/

tst_ConfirmUploadPopup.qml

14 lines

O1: the Kazv Project

Diff 374

View Options

CMakeLists.txt

View Options

src/kazv-clipboard.cpp

View Options

src/kazv-config.cpp

View Options

src/kazv-io-job.cpp

View Options

src/kazv-io-manager.cpp

View Options

src/l10n-provider.cpp

View Options

src/main.cpp

View Options

src/matrix-link.cpp

View Options

src/matrix-room.hpp

View Options

src/matrix-room.cpp

View Options

src/matrix-sdk.cpp

View Options

src/matrix-sticker-pack.cpp

View Options

src/matrix-sticker.cpp

View Options

src/qt-job.cpp

View Options

src/shortcuts/shortcut-util.cpp

View Options

src/tests/kazv-markdown-test.cpp

View Options

src/tests/matrix-event-test.cpp

View Options

src/tests/matrix-link-test.cpp

View Options

src/tests/matrix-promise-test.cpp

View Options

src/tests/matrix-room-list-test.cpp

View Options

src/tests/matrix-room-member-list-model-test.cpp

View Options

src/tests/matrix-room-timeline-test.cpp

View Options

src/tests/matrix-sdk-sessions-test.cpp

View Options

src/tests/matrix-sdk-test.cpp

View Options

src/tests/matrix-sticker-pack-test.cpp

View Options

src/tests/matrix-user-given-attrs-map-test.cpp

View Options

src/tests/quick-tests/tst_ConfirmUploadPopup.qml

Port away from legacy implicit conversionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 374

CMakeLists.txt

src/kazv-clipboard.cpp

src/kazv-config.cpp

src/kazv-io-job.cpp

src/kazv-io-manager.cpp

src/l10n-provider.cpp

src/main.cpp

src/matrix-link.cpp

src/matrix-room.hpp

src/matrix-room.cpp

src/matrix-sdk.cpp

src/matrix-sticker-pack.cpp

src/matrix-sticker.cpp

src/qt-job.cpp

src/shortcuts/shortcut-util.cpp

src/tests/kazv-markdown-test.cpp

src/tests/matrix-event-test.cpp

src/tests/matrix-link-test.cpp

src/tests/matrix-promise-test.cpp

src/tests/matrix-room-list-test.cpp

src/tests/matrix-room-member-list-model-test.cpp

src/tests/matrix-room-timeline-test.cpp

src/tests/matrix-sdk-sessions-test.cpp

src/tests/matrix-sdk-test.cpp

src/tests/matrix-sticker-pack-test.cpp

src/tests/matrix-user-given-attrs-map-test.cpp

src/tests/quick-tests/tst_ConfirmUploadPopup.qml

Port away from legacy implicit conversions
ClosedPublic
Actions

Revision Contents
Changeset List