Page MenuHomePhorge
Differential D112

Add a tooltip for event date in timeline
ClosedPublic
Actions

Authored by tusooa on Jul 9 2024, 8:53 PM.
Tags
None
Referenced Files
F30750: D112.1726923376.diff
Fri, Sep 20, 5:56 AM
F30680: D112.1726919853.diff
Fri, Sep 20, 4:57 AM
F30677: D112.1726919781.diff
Fri, Sep 20, 4:56 AM
F30538: D112.1726911735.diff
Fri, Sep 20, 2:42 AM
Unknown Object (File)
Mon, Sep 2, 7:22 PM
Unknown Object (File)
Fri, Aug 30, 9:33 AM
Unknown Object (File)
Fri, Aug 30, 9:33 AM
Unknown Object (File)
Fri, Aug 30, 9:33 AM
View All 74 Files
Subscribers
nannanko

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T61: Display date of events in timeline
Commits
rK0315a8b23484: Add a tooltip for event date in timeline
Summary

We had no way to see the date of an event. This commit adds one.

Type: add

BUG: https://iron.lily-is.land/T61

Test Plan

Hover on the event time for 1s and verify that you can see a tooltip of the date time of the event.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 9 2024, 8:53 PM
Owners added a reviewer: O1: the Kazv Project.Jul 9 2024, 8:53 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2024, 8:57 PM
Harbormaster failed remote builds in B159: Diff 270!
tusooa added a task: T61: Display date of events in timeline.Jul 10 2024, 9:04 PM
tusooa edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B159: Diff 270.Jul 13 2024, 9:18 AM
tusooa requested review of this revision.Jul 13 2024, 9:18 AM
nannanko subscribed.Jul 17 2024, 4:02 AM
nannanko added inline comments.
src/contents/ui/Bubble.qml
220

I noticed that there are several places where the same values ​​of ToolTip.delay and ToolTip.timeout are used.

Why not set the preferences for ToolTip.delay and ToolTip.timeout as variables in main.qml or some other way?

tusooa updated this revision to Diff 332.Jul 17 2024, 4:41 PM

Use unified values for tooltip attributes

tusooa marked an inline comment as done.Jul 17 2024, 4:43 PM
tusooa added inline comments.
src/contents/ui/Bubble.qml
220

Done in https://iron.lily-is.land/D137 . Also changed here.

Harbormaster completed remote builds in B202: Diff 332.Jul 17 2024, 4:56 PM
nannanko accepted this revision.Jul 17 2024, 7:51 PM
This revision is now accepted and ready to land.Jul 17 2024, 7:51 PM
tusooa added a parent revision: D137: Unify tooltip delay and timeout.Jul 17 2024, 9:59 PM
Closed by commit rK0315a8b23484: Add a tooltip for event date in timeline. · Explain WhyJul 19 2024, 2:34 PM
This revision was automatically updated to reflect the committed changes.
tusooa marked an inline comment as done.
tusooa added a commit: rK0315a8b23484: Add a tooltip for event date in timeline.

Revision Contents
Changeset List

Diff 353

View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/matrix-event.hpp

Loading...
View Options

src/matrix-event.cpp

Loading...