Differential D141

Use Image instead of Kirigami.Icon for sticker picker
ClosedPublic
Actions

Authored by tusooa on Jul 19 2024, 10:06 AM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rK2eba226f8bda: Use Image instead of Kirigami.Icon for sticker picker

Summary

Using Kirigami.Icon will cause the image to be blurry on HiDPI screens. This uses Image to replace Kirigami.Icon in sticker picker.

Type: fix

Test Plan

Using a HiDPI screen, verify that stickers in the sticker picker are not blurry.

Diff Detail

Repository

rK kazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 213
Build 415: GitLab CI for kazv
Build 414: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 19 2024, 10:06 AM

Owners added a reviewer: O1: the Kazv Project.Jul 19 2024, 10:06 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2024, 10:13 AM

Harbormaster failed remote builds in B213: Diff 350!

Harbormaster completed remote builds in B213: Diff 350.Jul 19 2024, 8:16 PM

tusooa requested review of this revision.Jul 19 2024, 8:16 PM

nannanko accepted this revision.Jul 24 2024, 12:27 AM

This revision is now accepted and ready to land.Jul 24 2024, 12:27 AM

Closed by commit rK2eba226f8bda: Use Image instead of Kirigami.Icon for sticker picker. · Explain WhyJul 24 2024, 2:34 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK2eba226f8bda: Use Image instead of Kirigami.Icon for sticker picker.

Revision Contents
Changeset List

Path

Size

Packages

src/

contents/

ui/

StickerPicker.qml

3 lines

O1: the Kazv Project

Diff 350

View Options

src/contents/ui/StickerPicker.qml

Use Image instead of Kirigami.Icon for sticker pickerClosedPublicActions