Differential D111

Prevent user from sending an empty message
ClosedPublic
Actions

Authored by tusooa on Jul 8 2024, 9:03 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rKf3dff531dd21: Prevent user from sending an empty message

Summary

This commit disables the send message action when the text box is empty, thus preventing the user from sending an empty text message.

Type: fix

Test Plan

Verify unit tests pass. Verify that the send message button is greyed out if the text box is empty. Verify that when you hit Ctrl+Enter when the text box is empty, no message is sent.

Diff Detail

Repository

rK kazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 8 2024, 9:03 PM

Owners added a reviewer: O1: the Kazv Project.Jul 8 2024, 9:03 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 8 2024, 9:07 PM

Harbormaster failed remote builds in B158: Diff 269!

Harbormaster completed remote builds in B158: Diff 269.Jul 13 2024, 8:33 AM

tusooa requested review of this revision.Jul 13 2024, 8:33 AM

Why should users be prevented from sending empty messages?

Matrix Spec does not seem to have a restriction on this, and Element also supports receiving empty messages.

In D111#2237, @nannanko wrote:

Why should users be prevented from sending empty messages?

Matrix Spec does not seem to have a restriction on this, and Element also supports receiving empty messages.

I just feel it's rather useless to send an empty message and it's easy for me to misclick Ctrl+Enter

nannanko accepted this revision.Jul 17 2024, 7:51 PM

This revision is now accepted and ready to land.Jul 17 2024, 7:51 PM

Closed by commit rKf3dff531dd21: Prevent user from sending an empty message. · Explain WhyJul 17 2024, 9:49 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rKf3dff531dd21: Prevent user from sending an empty message.