Differential D114

Unify list models
ClosedPublic
Actions

Authored by tusooa on Jul 11 2024, 3:11 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rKe641f6cc5cba: Unify list models

Summary

This unifies all the list models.

Type: skip

BUG: https://iron.lily-is.land/T108

Test Plan

Verify unit tests pass. Run kazv and verify all lists still work.

Diff Detail

Repository

rK kazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 11 2024, 3:11 PM

Owners added a reviewer: O1: the Kazv Project.Jul 11 2024, 3:11 PM

tusooa edited the test plan for this revision. (Show Details)Jul 11 2024, 3:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 11 2024, 4:19 PM

Harbormaster failed remote builds in B161: Diff 272!

Harbormaster completed remote builds in B161: Diff 272.Jul 13 2024, 9:25 AM

tusooa requested review of this revision.Jul 13 2024, 9:25 AM

nannanko accepted this revision.Jul 17 2024, 4:17 AM

This revision is now accepted and ready to land.Jul 17 2024, 4:17 AM

Closed by commit rKe641f6cc5cba: Unify list models. · Explain WhyJul 17 2024, 4:17 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rKe641f6cc5cba: Unify list models.

Revision Contents
Changeset List

Path

Size

Packages

src/

CMakeLists.txt

1 line

O1: the Kazv Project

kazv-abstract-list-model.hpp

40 lines

O1: the Kazv Project

kazv-abstract-list-model.cpp

76 lines

13 lines

39 lines

matrix-room-member-list-model.hpp

13 lines

O1: the Kazv Project

matrix-room-member-list-model.cpp

40 lines

O1: the Kazv Project

matrix-room-timeline.hpp

12 lines

O1: the Kazv Project

matrix-room-timeline.cpp

48 lines

O1: the Kazv Project

matrix-sticker-pack-list.hpp

14 lines

O1: the Kazv Project

matrix-sticker-pack-list.cpp

43 lines

O1: the Kazv Project

matrix-sticker-pack.hpp

14 lines

O1: the Kazv Project

matrix-sticker-pack.cpp

43 lines

O1: the Kazv Project

tests/

CMakeLists.txt

1 line

O1: the Kazv Project

kazv-abstract-list-model-test.cpp

104 lines

O1: the Kazv Project

Diff 327

View Options

src/CMakeLists.txt

View Options

src/kazv-abstract-list-model.hpp

View Options

src/kazv-abstract-list-model.cpp

View Options

src/matrix-room-list.hpp

View Options

src/matrix-room-list.cpp

View Options

src/matrix-room-member-list-model.hpp

View Options

src/matrix-room-member-list-model.cpp

View Options

src/matrix-room-timeline.hpp

View Options

src/matrix-room-timeline.cpp

View Options

src/matrix-sticker-pack-list.hpp

View Options

src/matrix-sticker-pack-list.cpp

View Options

src/matrix-sticker-pack.hpp

View Options

src/matrix-sticker-pack.cpp

View Options

src/tests/CMakeLists.txt

View Options

src/tests/kazv-abstract-list-model-test.cpp

Unify list modelsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 327

src/CMakeLists.txt

src/kazv-abstract-list-model.hpp

src/kazv-abstract-list-model.cpp

src/matrix-room-list.hpp

src/matrix-room-list.cpp

src/matrix-room-member-list-model.hpp

src/matrix-room-member-list-model.cpp

src/matrix-room-timeline.hpp

src/matrix-room-timeline.cpp

src/matrix-sticker-pack-list.hpp

src/matrix-sticker-pack-list.cpp

src/matrix-sticker-pack.hpp

src/matrix-sticker-pack.cpp

src/tests/CMakeLists.txt

src/tests/kazv-abstract-list-model-test.cpp

Unify list models
ClosedPublic
Actions

Revision Contents
Changeset List