Page MenuHomePhorge
Differential D107

Update local notifications when syncing
ClosedPublic
Actions

Authored by tusooa on Jul 7 2024, 8:39 PM.
Tags
None
Referenced Files
F27040: D107.1726600128.diff
Mon, Sep 16, 12:08 PM
Unknown Object (File)
Thu, Sep 12, 8:37 PM
Unknown Object (File)
Thu, Sep 12, 8:37 PM
Unknown Object (File)
Thu, Sep 12, 8:37 PM
Unknown Object (File)
Thu, Sep 12, 7:56 PM
Unknown Object (File)
Thu, Sep 5, 4:43 AM
Unknown Object (File)
Fri, Aug 30, 9:32 AM
Unknown Object (File)
Fri, Aug 30, 9:31 AM
View All 87 Files
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rL609dea65d4ab: Update local notifications when syncing
Summary

This commit implements updating local notifications when returned from a sync response.

Type: add

CCBUG: https://iron.lily-is.land/T52

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rL libkazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 154
Build 297: GitLab CI for libkazv
Build 296: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 7 2024, 8:39 PM
Owners added a reviewer: O1: the Kazv Project.Jul 7 2024, 8:39 PM
tusooa updated this revision to Diff 263.Jul 7 2024, 9:06 PM

Rebase upon D106

Harbormaster completed remote builds in B151: Diff 261.Jul 7 2024, 9:12 PM
tusooa updated this revision to Diff 264.Jul 7 2024, 9:49 PM

Fix notifications not updated after read receipt is updated

Harbormaster completed remote builds in B153: Diff 263.Jul 7 2024, 10:12 PM
Harbormaster completed remote builds in B154: Diff 264.Jul 7 2024, 10:35 PM
tusooa requested review of this revision.Jul 7 2024, 10:35 PM
tusooa mentioned this in D108: Add unread notification count to room list view.Jul 8 2024, 2:57 PM
nannanko accepted this revision.Jul 12 2024, 8:42 PM
This revision is now accepted and ready to land.Jul 12 2024, 8:42 PM
Closed by commit rL609dea65d4ab: Update local notifications when syncing. · Explain WhyJul 12 2024, 10:14 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rL609dea65d4ab: Update local notifications when syncing.
tusooa mentioned this in rK3ccfd1634b04: Add unread notification count to room list view.Jul 17 2024, 4:08 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
client/
actions/
31 lines63%
Loading...
O1: the Kazv Project
tests/
client/
146 lines--O1: the Kazv Project

Diff 264

View Options

src/client/actions/sync.cpp

Loading...
View Options

src/tests/client/sync-test.cpp

Loading...