Page MenuHomePhorge
Differential D97

Optimize replied-to event style
ClosedPublic
Actions

Authored by tusooa on Jul 5 2024, 5:40 PM.
Tags
None
Referenced Files
F112966: D97.1732361968.diff
Fri, Nov 22, 3:39 AM
F112886: D97.1732357984.diff
Fri, Nov 22, 2:33 AM
F112648: D97.1732340172.diff
Thu, Nov 21, 9:36 PM
F5426: image.png
Jul 5 2024, 5:41 PM
F5424: image.png
Jul 5 2024, 5:41 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK5626392886ab: Optimize replied-to event style
Summary

Originally, the height of the replied-to event can be larger than needed. This fixes the problem.

Type: fix

Test Plan

Open a room where there are a lot of replies to one-line text messages. Verify that none of them has "blanks" below the text.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 140
Build 269: GitLab CI for kazv
Build 268: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 5 2024, 5:40 PM
Owners added a reviewer: O1: the Kazv Project.Jul 5 2024, 5:40 PM
tusooa added a comment.Jul 5 2024, 5:41 PM
BeforeAfter
image.png (533×1 px, 93 KB)
image.png (485×1 px, 95 KB)

(notice the blank space below the quoted text)

Harbormaster completed remote builds in B140: Diff 236.Jul 5 2024, 5:50 PM
tusooa requested review of this revision.Jul 5 2024, 5:50 PM
nannanko accepted this revision.Jul 6 2024, 8:31 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:31 AM
Closed by commit rK5626392886ab: Optimize replied-to event style. · Explain WhyJul 6 2024, 9:13 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK5626392886ab: Optimize replied-to event style.

Revision Contents
Changeset List

PathSizePackages
src/
contents/
ui/
4 linesO1: the Kazv Project

Diff 236

View Options

src/contents/ui/Bubble.qml

Loading...