Page MenuHomePhorge
Differential D355

Make context drawer actions configurable
ClosedPublic
Actions

Authored by nannanko on Sat, Aug 22, 11:01 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rKe5561fbb5f28: Make context drawer actions configurable
Summary

Make context drawer actions configurable.

Type: add

Test Plan

Compile and open configure shortcuts page, verify that you can configure the context drawer actions.

Verify unit tets pass.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nannanko created this revision.Sat, Aug 22, 11:01 AM
Owners added a reviewer: O1: the Kazv Project.Sat, Aug 22, 11:01 AM
Harbormaster completed remote builds in B705: Diff 1091.Sat, Aug 22, 11:31 AM
nannanko requested review of this revision.Sat, Aug 22, 11:31 AM
nannanko mentioned this in D356: Make more actions configurable.Sat, Aug 22, 11:41 AM
tusooa added a comment.Sat, Aug 22, 6:37 PM

I think I would rather have them in separate files (not in Main.qml because there are already too many), e.g. GlobalActions.qml. RoomPageActions.qml, etc.

or we can consider a single ActionGroups.qml file that contains a KazvShortcuts.ActionCollection whose children are some ActionCollections containing actions for each group

tusooa accepted this revision.Tue, Aug 25, 2:44 PM
This revision is now accepted and ready to land.Tue, Aug 25, 2:44 PM
Closed by commit rKe5561fbb5f28: Make context drawer actions configurable. · Explain WhySat, Aug 29, 7:35 PM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rKe5561fbb5f28: Make context drawer actions configurable.
nannanko mentioned this in rK6232d174ed33: Make more actions configurable.Wed, Sep 2, 8:52 AM

Revision Contents
Changeset List

Diff 1107

View Options

src/contents/ui/Main.qml

Loading...
View Options

src/contents/ui/RoomPage.qml

Loading...
View Options

src/l10n/cmn-Hans/100-ui.ftl

Loading...
View Options

src/l10n/en/100-ui.ftl

Loading...