Page MenuHomePhorge
Differential D338

Refactor room list to use ItemDelegate
ClosedPublic
Actions

Authored by tusooa on Tue, Jul 28, 9:21 PM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKf98786dbed52: Refactor room list to use ItemDelegate
Summary

SwipeListItem is buggy, so port away from it. The favourite indicator is shown as a pure indicator and all actions are moved into the context menu.

Type: add

CCBUG: https://iron.lily-is.land/T175

Test Plan

Check you can invoke the context menu for the RoomListViewItemDelegate via right click (desktop) / long press (mobile).

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked-2
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 682
Build 1346: Invoke BuildbotBuildbot build #2255
Build 1345: arc lint + arc unit

Event Timeline

tusooa created this revision.Tue, Jul 28, 9:21 PM
Owners added a reviewer: O1: the Kazv Project.Tue, Jul 28, 9:21 PM
Herald added a reviewer: servant. · View Herald TranscriptTue, Jul 28, 9:21 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

tusooa edited the summary of this revision. (Show Details)Tue, Jul 28, 9:21 PM
tusooa removed a reviewer: servant.
tusooa edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B682: Diff 1049.Tue, Jul 28, 9:50 PM
tusooa requested review of this revision.Tue, Jul 28, 9:50 PM
nannanko accepted this revision.Sat, Aug 1, 7:39 PM
This revision is now accepted and ready to land.Sat, Aug 1, 7:39 PM
Closed by commit rKf98786dbed52: Refactor room list to use ItemDelegate. · Explain WhySat, Aug 1, 8:51 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKf98786dbed52: Refactor room list to use ItemDelegate.

Revision Contents
Changeset List

Diff 1049

View Options

CMakeLists.txt

Loading...
View Options

src/contents/ui/RoomListView.qml

Loading...
View Options

src/contents/ui/RoomListViewItemDelegate.qml

Loading...
View Options

src/tests/quick-tests/tst_RoomListViewItemDelegate.qml

Loading...