Page MenuHomePhorge

Mark deleted devices as deleted
AcceptedPublic

Authored by tusooa on Thu, Jul 23, 5:26 PM.
Tags
None
Referenced Files
F85612477: D335.1785214879.diff
Sun, Jul 26, 10:01 PM
F85612450: D335.1785210939.diff
Sun, Jul 26, 8:55 PM
F85612171: D335.1785171230.diff
Sun, Jul 26, 9:53 AM
F85612096: D335.1785162147.diff
Sun, Jul 26, 7:22 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Summary

Before, we did not have a way to track deleted devices. All of them linger in the device list tracker with no mark of deletion. This also caused megolm keys to be sent to these devices. This commit introduces a deleted marker; when a /keys/query is sent to obtain the full device list of a certain user, any device not in the response will be marked as deleted. ClientModel::devicesToSendKeys() will also exclude deleted devices so we no longer send session keys to them.

Type: fix
BUG: https://iron.lily-is.land/T140

Adapted from output of OpenCode (DeepSeek V4 Pro; GLM 5.2). tusooa reviewed the code and takes full responsibility.

Test Plan

To be tested together with a corresponding kazv diff ( https://iron.lily-is.land/D336 ).

Diff Detail

Repository
rL libkazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 675
Build 1332: Invoke BuildbotBuildbot build #2193
Build 1331: arc lint + arc unit