Page MenuHomePhorge

Activate the corresponding room when clicking on notification
ClosedPublic

Authored by tusooa on May 11 2024, 7:13 AM.
Tags
None
Referenced Files
F114397: D24.1732544052.diff
Sun, Nov 24, 6:14 AM
F113805: D24.1732489099.diff
Sat, Nov 23, 2:58 PM
F113698: D24.1732488674.diff
Sat, Nov 23, 2:51 PM
F113697: D24.1732488671.diff
Sat, Nov 23, 2:51 PM
F113696: D24.1732488667.diff
Sat, Nov 23, 2:51 PM
F113695: D24.1732488662.diff
Sat, Nov 23, 2:51 PM
F113645: D24.1732488339.diff
Sat, Nov 23, 2:45 PM
Subscribers

Details

Summary

When the user clicks on a notification, they usually want to see the message right away. This makes kazv lead them to the corresponding room when the notification is clicked on (defaultActivated).

Type: add

BUG: https://iron.lily-is.land/T62

Test Plan

Send a message that creates a notification from another user. Verify that when clicking on the notification, the corresponding room is activated, and the room is always opened as the second page (i.e. index 1) no matter how many pages are opened.

Open kazv and resize the window so that only one page is shown. Open the page of some room. Go back to main page, and send a message from another user to that room. Click on the notification and verify that the room page is shown.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.May 11 2024, 7:16 AM
Harbormaster failed remote builds in B39: Diff 59!
nannanko subscribed.
nannanko added inline comments.
src/contents/ui/MessageNotification.qml
18

It don't work when sdkVars.currentRoomId was already roomId.

Do you still remember kazv can't return room page with click room item? This made the same mistake.

I fixed the previous one, so I suggested using a function to set the currentRoomId and reuse my code.

This revision now requires changes to proceed.May 29 2024, 5:37 AM

Fix not returning to room in narrow mode

Rebase onto lily/servant

This revision is now accepted and ready to land.Jun 1 2024, 2:54 AM