HomePhorge

Do not return {:error, reason} tuple on header check failure
673b3f7ba2e4Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Do not return {:error, reason} tuple on header check failure

Due to how Pleroma handles checking whether the signature check failed
or not, returning the error tuple also constitutes as a valid signature.
(Pleroma uses cond which matches on the first thing that does not
evaluate to false or nil and {:error, reason} passes that test.)

Details

Provenance
PhantasmAuthored on Sun, May 10, 1:35 PM
Parents
R18:a97413244347: Add Woodpecker CI lint and test pipelines
Branches
Unknown
Tags
Unknown
References
refs/pull/13/head

Event Timeline