No OneTemporary
Actions

Size

96 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/lib/pleroma/web/activity_pub/builder.ex b/lib/pleroma/web/activity_pub/builder.ex
	index 167c769a9..3b208ab77 100644
	--- a/lib/pleroma/web/activity_pub/builder.ex
	+++ b/lib/pleroma/web/activity_pub/builder.ex
	@@ -1,425 +1,423 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Web.ActivityPub.Builder do
	@moduledoc """
	This module builds the objects. Meant to be used for creating local objects.

	This module encodes our addressing policies and general shape of our objects.
	"""

	alias Pleroma.Activity
	alias Pleroma.Emoji
	alias Pleroma.Object
	alias Pleroma.User
	alias Pleroma.Web.ActivityPub.Relay
	alias Pleroma.Web.ActivityPub.Utils
	alias Pleroma.Web.ActivityPub.Visibility
	alias Pleroma.Web.CommonAPI.ActivityDraft

	require Pleroma.Constants

	def accept_or_reject(actor, activity, type) do
	data = %{
	"id" => Utils.generate_activity_id(),
	"actor" => actor.ap_id,
	"type" => type,
	"object" => activity.data["id"],
	"to" => [activity.actor]
	}

	{:ok, data, []}
	end

	@spec reject(User.t(), Activity.t()) :: {:ok, map(), keyword()}
	def reject(actor, rejected_activity) do
	accept_or_reject(actor, rejected_activity, "Reject")
	end

	@spec accept(User.t(), Activity.t()) :: {:ok, map(), keyword()}
	def accept(actor, accepted_activity) do
	accept_or_reject(actor, accepted_activity, "Accept")
	end

	@spec follow(User.t(), User.t()) :: {:ok, map(), keyword()}
	def follow(follower, followed) do
	data = %{
	"id" => Utils.generate_activity_id(),
	"actor" => follower.ap_id,
	"type" => "Follow",
	"object" => followed.ap_id,
	"to" => [followed.ap_id]
	}

	{:ok, data, []}
	end

	defp unicode_emoji_react(_object, data, emoji) do
	data
	\|> Map.put("content", emoji)
	\|> Map.put("type", "EmojiReact")
	end

	defp add_emoji_content(data, emoji, url) do
	tag = [
	Emoji.build_emoji_tag({Emoji.maybe_strip_name(emoji), url})
	]

	data
	\|> Map.put("content", Emoji.maybe_quote(emoji))
	\|> Map.put("type", "EmojiReact")
	\|> Map.put("tag", tag)
	end

	defp remote_custom_emoji_react(
	%{data: %{"reactions" => existing_reactions}},
	data,
	emoji
	) do
	[emoji_code, instance] = String.split(Emoji.maybe_strip_name(emoji), "@")

	matching_reaction =
	Enum.find(
	existing_reactions,
	fn [name, _, url] ->
	if url != nil do
	url = URI.parse(url)
	url.host == instance && name == emoji_code
	end
	end
	)

	if matching_reaction do
	[name, _, url] = matching_reaction
	add_emoji_content(data, name, url)
	else
	{:error, "Could not react"}
	end
	end

	defp remote_custom_emoji_react(_object, _data, _emoji) do
	{:error, "Could not react"}
	end

	defp local_custom_emoji_react(data, emoji) do
	with %{file: path} = emojo <- Emoji.get(emoji) do
	url = Emoji.local_url(path)
	add_emoji_content(data, emojo.code, url)
	else
	_ -> {:error, "Emoji does not exist"}
	end
	end

	defp custom_emoji_react(object, data, emoji) do
	if String.contains?(emoji, "@") do
	remote_custom_emoji_react(object, data, emoji)
	else
	local_custom_emoji_react(data, emoji)
	end
	end

	@spec emoji_react(User.t(), Object.t(), String.t()) :: {:ok, map(), keyword()}
	def emoji_react(actor, object, emoji) do
	with {:ok, data, meta} <- object_action(actor, object) do
	data =
	if Emoji.unicode?(emoji) do
	unicode_emoji_react(object, data, emoji)
	else
	custom_emoji_react(object, data, emoji)
	end

	{:ok, data, meta}
	end
	end

	@spec undo(User.t(), Activity.t()) :: {:ok, map(), keyword()}
	def undo(actor, object) do
	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"actor" => actor.ap_id,
	"type" => "Undo",
	"object" => object.data["id"],
	"to" => object.data["to"] \|\| [],
	"cc" => object.data["cc"] \|\| []
	}, []}
	end

	@spec delete(User.t(), String.t()) :: {:ok, map(), keyword()}
	def delete(actor, object_id) do
	object = Object.normalize(object_id, fetch: false)

	user = !object && User.get_cached_by_ap_id(object_id)

	to =
	case {object, user} do
	{%Object{}, _} ->
	# We are deleting an object, address everyone who was originally mentioned
	(object.data["to"] \|\| []) ++ (object.data["cc"] \|\| [])

	{_, %User{follower_address: follower_address}} ->
	# We are deleting a user, address the followers of that user
	[follower_address]
	end

	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"actor" => actor.ap_id,
	"object" => object_id,
	"to" => to,
	"type" => "Delete"
	}, []}
	end

	def create(actor, object, recipients) do
	context =
	if is_map(object) do
	object["context"]
	else
	nil
	end

	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"actor" => actor.ap_id,
	"to" => recipients,
	"object" => object,
	"type" => "Create",
	"published" => DateTime.utc_now() \|> DateTime.to_iso8601()
	}
	\|> Pleroma.Maps.put_if_present("context", context), []}
	end

	@spec note(ActivityDraft.t()) :: {:ok, map(), keyword()}
	def note(%ActivityDraft{} = draft) do
	data =
	%{
	"type" => "Note",
	"to" => draft.to,
	"cc" => draft.cc,
	"content" => draft.content_html,
	"summary" => draft.summary,
	"sensitive" => draft.sensitive,
	"context" => draft.context,
	"attachment" => draft.attachments,
	"actor" => draft.user.ap_id,
	"tag" => Keyword.values(draft.tags) \|> Enum.uniq()
	}
	\|> add_in_reply_to(draft.in_reply_to)
	\|> add_quote(draft.quote_post)
	\|> Map.merge(draft.extra)

	{:ok, data, []}
	end

	defp add_in_reply_to(object, nil), do: object

	defp add_in_reply_to(object, in_reply_to) do
	with %Object{} = in_reply_to_object <- Object.normalize(in_reply_to, fetch: false) do
	Map.put(object, "inReplyTo", in_reply_to_object.data["id"])
	else
	_ -> object
	end
	end

	defp add_quote(object, nil), do: object

	defp add_quote(object, quote_post) do
	with %Object{} = quote_object <- Object.normalize(quote_post, fetch: false) do
	Map.put(object, "quoteUrl", quote_object.data["id"])
	else
	_ -> object
	end
	end

	def chat_message(actor, recipient, content, opts \\ []) do
	basic = %{
	"id" => Utils.generate_object_id(),
	"actor" => actor.ap_id,
	"type" => "ChatMessage",
	"to" => [recipient],
	"content" => content,
	"published" => DateTime.utc_now() \|> DateTime.to_iso8601(),
	"emoji" => Emoji.Formatter.get_emoji_map(content)
	}

	case opts[:attachment] do
	%Object{data: attachment_data} ->
	{
	:ok,
	Map.put(basic, "attachment", attachment_data),
	[]
	}

	_ ->
	{:ok, basic, []}
	end
	end

	def answer(user, object, name) do
	{:ok,
	%{
	"type" => "Answer",
	"actor" => user.ap_id,
	"attributedTo" => user.ap_id,
	"cc" => [object.data["actor"]],
	"to" => [],
	"name" => name,
	"inReplyTo" => object.data["id"],
	"context" => object.data["context"],
	"published" => DateTime.utc_now() \|> DateTime.to_iso8601(),
	"id" => Utils.generate_object_id()
	}, []}
	end

	@spec tombstone(String.t(), String.t()) :: {:ok, map(), keyword()}
	def tombstone(actor, id) do
	{:ok,
	%{
	"id" => id,
	"actor" => actor,
	"type" => "Tombstone"
	}, []}
	end

	@spec like(User.t(), Object.t()) :: {:ok, map(), keyword()}
	def like(actor, object) do
	with {:ok, data, meta} <- object_action(actor, object) do
	data =
	data
	\|> Map.put("type", "Like")

	{:ok, data, meta}
	end
	end

	@spec update(User.t(), Object.t()) :: {:ok, map(), keyword()}
	def update(actor, object) do
	{to, cc} =
	if object["type"] in Pleroma.Constants.actor_types() do
	# User updates, always public
	{[Pleroma.Constants.as_public(), actor.follower_address], []}
	else
	# Status updates, follow the recipients in the object
	{object["to"] \|\| [], object["cc"] \|\| []}
	end

	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"type" => "Update",
	"actor" => actor.ap_id,
	"object" => object,
	"to" => to,
	"cc" => cc
	}, []}
	end

	@spec block(User.t(), User.t(), map()) :: {:ok, map(), keyword()}
	def block(blocker, blocked, params \\ %{}) do
	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"type" => "Block",
	"actor" => blocker.ap_id,
	"object" => blocked.ap_id,
	"to" => [blocked.ap_id]
	}, Keyword.new(params)}
	end

	@spec announce(User.t(), Object.t(), keyword()) :: {:ok, map(), keyword()}
	def announce(actor, object, options \\ []) do
	- public? = Keyword.get(options, :public, false)
	+ visibility = Keyword.get(options, :visibility, "public")

	- to =
	- cond do
	- actor.ap_id == Relay.ap_id() ->
	- [actor.follower_address]
	-
	- public? and Visibility.local_public?(object) ->
	- [actor.follower_address, object.data["actor"], Utils.as_local_public()]
	-
	- public? ->
	- [actor.follower_address, object.data["actor"], Pleroma.Constants.as_public()]
	-
	- true ->
	- [actor.follower_address, object.data["actor"]]
	+ {to, cc} =
	+ if actor.ap_id == Relay.ap_id() do
	+ {[actor.follower_address], []}
	+ else
	+ Pleroma.Web.CommonAPI.Utils.get_to_and_cc_for_visibility(
	+ visibility,
	+ actor.follower_address,
	+ nil,
	+ [object.data["actor"]]
	+ )
	end

	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"actor" => actor.ap_id,
	"object" => object.data["id"],
	"to" => to,
	+ "cc" => cc,
	"context" => object.data["context"],
	"type" => "Announce",
	"published" => Utils.make_date()
	}, []}
	end

	@spec object_action(User.t(), Object.t()) :: {:ok, map(), keyword()}
	defp object_action(actor, object) do
	object_actor = User.get_cached_by_ap_id(object.data["actor"])

	# Address the actor of the object, and our actor's follower collection if the post is public.
	to =
	if Visibility.public?(object) do
	[actor.follower_address, object.data["actor"]]
	else
	[object.data["actor"]]
	end

	# CC everyone who's been addressed in the object, except ourself and the object actor's
	# follower collection
	cc =
	(object.data["to"] ++ (object.data["cc"] \|\| []))
	\|> List.delete(actor.ap_id)
	\|> List.delete(object_actor.follower_address)

	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"actor" => actor.ap_id,
	"object" => object.data["id"],
	"to" => to,
	"cc" => cc,
	"context" => object.data["context"]
	}, []}
	end

	@spec pin(User.t(), Object.t()) :: {:ok, map(), keyword()}
	def pin(%User{} = user, object) do
	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"target" => pinned_url(user.nickname),
	"object" => object.data["id"],
	"actor" => user.ap_id,
	"type" => "Add",
	"to" => [Pleroma.Constants.as_public()],
	"cc" => [user.follower_address]
	}, []}
	end

	@spec unpin(User.t(), Object.t()) :: {:ok, map, keyword()}
	def unpin(%User{} = user, object) do
	{:ok,
	%{
	"id" => Utils.generate_activity_id(),
	"target" => pinned_url(user.nickname),
	"object" => object.data["id"],
	"actor" => user.ap_id,
	"type" => "Remove",
	"to" => [Pleroma.Constants.as_public()],
	"cc" => [user.follower_address]
	}, []}
	end

	defp pinned_url(nickname) when is_binary(nickname) do
	Pleroma.Web.Router.Helpers.activity_pub_url(Pleroma.Web.Endpoint, :pinned, nickname)
	end
	end
	diff --git a/lib/pleroma/web/common_api.ex b/lib/pleroma/web/common_api.ex
	index 04181ad8f..cb9d521b3 100644
	--- a/lib/pleroma/web/common_api.ex
	+++ b/lib/pleroma/web/common_api.ex
	@@ -1,799 +1,797 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Web.CommonAPI do
	alias Pleroma.Activity
	alias Pleroma.Conversation.Participation
	alias Pleroma.Formatter
	alias Pleroma.ModerationLog
	alias Pleroma.Object
	alias Pleroma.Rule
	alias Pleroma.ThreadMute
	alias Pleroma.User
	alias Pleroma.UserRelationship
	alias Pleroma.Web.ActivityPub.ActivityPub
	alias Pleroma.Web.ActivityPub.Builder
	alias Pleroma.Web.ActivityPub.Pipeline
	alias Pleroma.Web.ActivityPub.Utils
	alias Pleroma.Web.ActivityPub.Visibility
	alias Pleroma.Web.CommonAPI.ActivityDraft

	import Ecto.Query, only: [where: 3]
	import Pleroma.Web.Gettext
	import Pleroma.Web.CommonAPI.Utils

	require Pleroma.Constants
	require Logger

	@spec block(User.t(), User.t()) :: {:ok, Activity.t()} \| Pipeline.errors()
	def block(blocked, blocker, params \\ %{}) do
	with {:ok, block_data, meta} <- Builder.block(blocker, blocked, params),
	{:ok, block, _} <- Pipeline.common_pipeline(block_data, meta ++ [local: true]) do
	{:ok, block}
	end
	end

	@spec post_chat_message(User.t(), User.t(), String.t(), list()) ::
	{:ok, Activity.t()} \| Pipeline.errors()
	def post_chat_message(%User{} = user, %User{} = recipient, content, opts \\ []) do
	with maybe_attachment <- opts[:media_id] && Object.get_by_id(opts[:media_id]),
	:ok <- validate_chat_attachment_attribution(maybe_attachment, user),
	:ok <- validate_chat_content_length(content, !!maybe_attachment),
	{_, {:ok, chat_message_data, _meta}} <-
	{:build_object,
	Builder.chat_message(
	user,
	recipient.ap_id,
	content \|> format_chat_content,
	attachment: maybe_attachment
	)},
	{_, {:ok, create_activity_data, _meta}} <-
	{:build_create_activity, Builder.create(user, chat_message_data, [recipient.ap_id])},
	{_, {:ok, %Activity{} = activity, _meta}} <-
	{:common_pipeline,
	Pipeline.common_pipeline(create_activity_data,
	local: true,
	idempotency_key: opts[:idempotency_key]
	)} do
	{:ok, activity}
	else
	{:common_pipeline, e} -> e
	e -> e
	end
	end

	defp format_chat_content(nil), do: nil

	defp format_chat_content(content) do
	{text, _, _} =
	content
	\|> Formatter.html_escape("text/plain")
	\|> Formatter.linkify()
	\|> (fn {text, mentions, tags} ->
	{String.replace(text, ~r/\r?\n/, "<br>"), mentions, tags}
	end).()

	text
	end

	defp validate_chat_attachment_attribution(nil, _), do: :ok

	defp validate_chat_attachment_attribution(attachment, user) do
	with :ok <- Object.authorize_access(attachment, user) do
	:ok
	else
	e ->
	e
	end
	end

	defp validate_chat_content_length(_, true), do: :ok
	defp validate_chat_content_length(nil, false), do: {:error, :no_content}

	defp validate_chat_content_length(content, _) do
	if String.length(content) <= Pleroma.Config.get([:instance, :chat_limit]) do
	:ok
	else
	{:error, :content_too_long}
	end
	end

	@spec unblock(User.t(), User.t()) ::
	{:ok, Activity.t()} \| {:ok, :no_activity} \| Pipeline.errors() \| {:error, :not_blocking}
	def unblock(blocked, blocker) do
	with {_, %Activity{} = block} <- {:fetch_block, Utils.fetch_latest_block(blocker, blocked)},
	{:ok, unblock_data, _} <- Builder.undo(blocker, block),
	{:ok, unblock, _} <- Pipeline.common_pipeline(unblock_data, local: true) do
	{:ok, unblock}
	else
	{:fetch_block, nil} ->
	if User.blocks?(blocker, blocked) do
	User.unblock(blocker, blocked)
	{:ok, :no_activity}
	else
	{:error, :not_blocking}
	end

	e ->
	e
	end
	end

	@spec follow(User.t(), User.t()) ::
	{:ok, User.t(), User.t(), Activity.t() \| Object.t()}
	\| {:error, :rejected}
	\| Pipeline.errors()
	def follow(followed, follower) do
	timeout = Pleroma.Config.get([:activitypub, :follow_handshake_timeout])

	with {:ok, follow_data, _} <- Builder.follow(follower, followed),
	{:ok, activity, _} <- Pipeline.common_pipeline(follow_data, local: true),
	{:ok, follower, followed} <- User.wait_and_refresh(timeout, follower, followed) do
	if activity.data["state"] == "reject" do
	{:error, :rejected}
	else
	{:ok, followed, follower, activity}
	end
	end
	end

	@spec unfollow(User.t(), User.t()) :: {:ok, User.t()} \| {:error, any()}
	def unfollow(unfollowed, follower) do
	with {:ok, follower, _follow_activity} <- User.unfollow(follower, unfollowed),
	{:ok, _activity} <- ActivityPub.unfollow(follower, unfollowed),
	{:ok, _subscription} <- User.unsubscribe(follower, unfollowed),
	{:ok, _endorsement} <- User.unendorse(follower, unfollowed) do
	{:ok, follower}
	end
	end

	@spec accept_follow_request(User.t(), User.t()) :: {:ok, User.t()} \| Pipeline.errors()
	def accept_follow_request(follower, followed) do
	with %Activity{} = follow_activity <- Utils.fetch_latest_follow(follower, followed),
	{:ok, accept_data, _} <- Builder.accept(followed, follow_activity),
	{:ok, _activity, _} <- Pipeline.common_pipeline(accept_data, local: true) do
	{:ok, follower}
	end
	end

	@spec reject_follow_request(User.t(), User.t()) :: {:ok, User.t()} \| Pipeline.errors() \| nil
	def reject_follow_request(follower, followed) do
	with %Activity{} = follow_activity <- Utils.fetch_latest_follow(follower, followed),
	{:ok, reject_data, _} <- Builder.reject(followed, follow_activity),
	{:ok, _activity, _} <- Pipeline.common_pipeline(reject_data, local: true) do
	{:ok, follower}
	end
	end

	@spec delete(String.t(), User.t()) ::
	{:ok, Activity.t()} \| Pipeline.errors() \| {:error, :not_found \| String.t()}
	def delete(activity_id, user) do
	with {_, %Activity{data: %{"object" => _, "type" => "Create"}} = activity} <-
	{:find_activity, Activity.get_by_id(activity_id, filter: [])},
	{_, {:ok, _}} <- {:cancel_jobs, maybe_cancel_jobs(activity)},
	{_, %Object{} = object, _} <-
	{:find_object, Object.normalize(activity, fetch: false), activity},
	true <- User.privileged?(user, :messages_delete) \|\| user.ap_id == object.data["actor"],
	{:ok, delete_data, _} <- Builder.delete(user, object.data["id"]),
	{:ok, delete, _} <- Pipeline.common_pipeline(delete_data, local: true) do
	if User.privileged?(user, :messages_delete) and user.ap_id != object.data["actor"] do
	action =
	if object.data["type"] == "ChatMessage" do
	"chat_message_delete"
	else
	"status_delete"
	end

	ModerationLog.insert_log(%{
	action: action,
	actor: user,
	subject_id: activity_id
	})
	end

	{:ok, delete}
	else
	{:find_activity, _} ->
	{:error, :not_found}

	{:find_object, nil, %Activity{data: %{"actor" => actor, "object" => object}}} ->
	# We have the create activity, but not the object, it was probably pruned.
	# Insert a tombstone and try again
	with {:ok, tombstone_data, _} <- Builder.tombstone(actor, object),
	{:ok, _tombstone} <- Object.create(tombstone_data) do
	delete(activity_id, user)
	else
	_ ->
	Logger.error(
	"Could not insert tombstone for missing object on deletion. Object is #{object}."
	)

	{:error, dgettext("errors", "Could not delete")}
	end

	_ ->
	{:error, dgettext("errors", "Could not delete")}
	end
	end

	@spec repeat(String.t(), User.t(), map()) :: {:ok, Activity.t()} \| {:error, :not_found}
	def repeat(id, user, params \\ %{}) do
	with %Activity{data: %{"type" => "Create"}} = activity <- Activity.get_by_id(id),
	object = %Object{} <- Object.normalize(activity, fetch: false),
	{_, nil} <- {:existing_announce, Utils.get_existing_announce(user.ap_id, object)},
	- public = public_announce?(object, params),
	- {:ok, announce, _} <- Builder.announce(user, object, public: public),
	+ visibility = announce_visibility(object, params),
	+ {:ok, announce, _} <- Builder.announce(user, object, visibility: visibility),
	{:ok, activity, _} <- Pipeline.common_pipeline(announce, local: true) do
	{:ok, activity}
	else
	{:existing_announce, %Activity{} = announce} ->
	{:ok, announce}

	_ ->
	{:error, :not_found}
	end
	end

	@spec unrepeat(String.t(), User.t()) :: {:ok, Activity.t()} \| {:error, :not_found \| String.t()}
	def unrepeat(id, user) do
	with {_, %Activity{data: %{"type" => "Create"}} = activity} <-
	{:find_activity, Activity.get_by_id(id)},
	%Object{} = note <- Object.normalize(activity, fetch: false),
	%Activity{} = announce <- Utils.get_existing_announce(user.ap_id, note),
	{_, {:ok, _}} <- {:cancel_jobs, maybe_cancel_jobs(announce)},
	{:ok, undo, _} <- Builder.undo(user, announce),
	{:ok, activity, _} <- Pipeline.common_pipeline(undo, local: true) do
	{:ok, activity}
	else
	{:find_activity, _} -> {:error, :not_found}
	_ -> {:error, dgettext("errors", "Could not unrepeat")}
	end
	end

	@spec favorite(String.t(), User.t()) ::
	{:ok, Activity.t()} \| {:ok, :already_liked} \| {:error, :not_found \| String.t()}
	def favorite(id, %User{} = user) do
	case favorite_helper(user, id) do
	{:ok, _} = res ->
	res

	{:error, :not_found} = res ->
	res

	{:error, e} ->
	Logger.error("Could not favorite #{id}. Error: #{inspect(e, pretty: true)}")
	{:error, dgettext("errors", "Could not favorite")}
	end
	end

	defp favorite_helper(user, id) do
	with {_, %Activity{object: object}} <- {:find_object, Activity.get_by_id_with_object(id)},
	{_, true} <- {:visibility_error, activity_visible_to_actor(object, user)},
	{_, {:ok, like_object, meta}} <- {:build_object, Builder.like(user, object)},
	{_, {:ok, %Activity{} = activity, _meta}} <-
	{:common_pipeline,
	Pipeline.common_pipeline(like_object, Keyword.put(meta, :local, true))} do
	{:ok, activity}
	else
	{:find_object, _} ->
	{:error, :not_found}

	{:visibility_error, _} ->
	{:error, :not_found}

	{:common_pipeline, {:error, {:validate, {:error, changeset}}}} = e ->
	if {:object, {"already liked by this actor", []}} in changeset.errors do
	{:ok, :already_liked}
	else
	{:error, e}
	end

	e ->
	{:error, e}
	end
	end

	@spec unfavorite(String.t(), User.t()) ::
	{:ok, Activity.t()} \| {:error, :not_found \| String.t()}
	def unfavorite(id, user) do
	with {_, %Activity{data: %{"type" => "Create"}} = activity} <-
	{:find_activity, Activity.get_by_id(id)},
	%Object{} = note <- Object.normalize(activity, fetch: false),
	{_, true} <- {:visibility_error, activity_visible_to_actor(note, user)},
	%Activity{} = like <- Utils.get_existing_like(user.ap_id, note),
	{_, {:ok, _}} <- {:cancel_jobs, maybe_cancel_jobs(like)},
	{:ok, undo, _} <- Builder.undo(user, like),
	{:ok, activity, _} <- Pipeline.common_pipeline(undo, local: true) do
	{:ok, activity}
	else
	{:find_activity, _} -> {:error, :not_found}
	{:visibility_error, _} -> {:error, :not_found}
	_ -> {:error, dgettext("errors", "Could not unfavorite")}
	end
	end

	@spec react_with_emoji(String.t(), User.t(), String.t()) ::
	{:ok, Activity.t()} \| {:error, String.t()}
	def react_with_emoji(id, user, emoji) do
	with %Activity{} = activity <- Activity.get_by_id(id),
	{_, true} <- {:visibility_error, activity_visible_to_actor(activity, user)},
	object <- Object.normalize(activity, fetch: false),
	{:ok, emoji_react, _} <- Builder.emoji_react(user, object, emoji),
	{:ok, activity, _} <- Pipeline.common_pipeline(emoji_react, local: true) do
	{:ok, activity}
	else
	{:visibility_error, _} ->
	{:error, :not_found}

	_ ->
	{:error, dgettext("errors", "Could not add reaction emoji")}
	end
	end

	@spec unreact_with_emoji(String.t(), User.t(), String.t()) ::
	{:ok, Activity.t()} \| {:error, String.t()}
	def unreact_with_emoji(id, user, emoji) do
	with %Activity{} = reaction_activity <- Utils.get_latest_reaction(id, user, emoji),
	{_, {:ok, _}} <- {:cancel_jobs, maybe_cancel_jobs(reaction_activity)},
	{:ok, undo, _} <- Builder.undo(user, reaction_activity),
	{:ok, activity, _} <- Pipeline.common_pipeline(undo, local: true) do
	{:ok, activity}
	else
	_ ->
	{:error, dgettext("errors", "Could not remove reaction emoji")}
	end
	end

	@spec vote(Object.t(), User.t(), list()) :: {:ok, list(), Object.t()} \| Pipeline.errors()
	def vote(%Object{data: %{"type" => "Question"}} = object, %User{} = user, choices) do
	with :ok <- validate_not_author(object, user),
	:ok <- validate_existing_votes(user, object),
	{:ok, options, choices} <- normalize_and_validate_choices(choices, object) do
	answer_activities =
	Enum.map(choices, fn index ->
	{:ok, answer_object, _meta} =
	Builder.answer(user, object, Enum.at(options, index)["name"])

	{:ok, activity_data, _meta} = Builder.create(user, answer_object, [])

	{:ok, activity, _meta} =
	activity_data
	\|> Map.put("cc", answer_object["cc"])
	\|> Map.put("context", answer_object["context"])
	\|> Pipeline.common_pipeline(local: true)

	# TODO: Do preload of Pleroma.Object in Pipeline
	Activity.normalize(activity.data)
	end)

	object = Object.get_cached_by_ap_id(object.data["id"])
	{:ok, answer_activities, object}
	end
	end

	defp validate_not_author(%{data: %{"actor" => ap_id}}, %{ap_id: ap_id}),
	do: {:error, dgettext("errors", "Poll's author can't vote")}

	defp validate_not_author(_, _), do: :ok

	defp validate_existing_votes(%{ap_id: ap_id}, object) do
	if Utils.get_existing_votes(ap_id, object) == [] do
	:ok
	else
	{:error, dgettext("errors", "Already voted")}
	end
	end

	defp get_options_and_max_count(%{data: %{"anyOf" => any_of}})
	when is_list(any_of) and any_of != [],
	do: {any_of, Enum.count(any_of)}

	defp get_options_and_max_count(%{data: %{"oneOf" => one_of}})
	when is_list(one_of) and one_of != [],
	do: {one_of, 1}

	defp normalize_and_validate_choices(choices, object) do
	choices = Enum.map(choices, fn i -> if is_binary(i), do: String.to_integer(i), else: i end)
	{options, max_count} = get_options_and_max_count(object)
	count = Enum.count(options)

	with {_, true} <- {:valid_choice, Enum.all?(choices, &(&1 < count))},
	{_, true} <- {:count_check, Enum.count(choices) <= max_count} do
	{:ok, options, choices}
	else
	{:valid_choice, _} -> {:error, dgettext("errors", "Invalid indices")}
	{:count_check, _} -> {:error, dgettext("errors", "Too many choices")}
	end
	end

	- defp public_announce?(_, %{visibility: visibility})
	- when visibility in ~w{public unlisted private direct},
	- do: visibility in ~w(public unlisted)
	+ def announce_visibility(_, %{visibility: visibility})
	+ when visibility in ~w{public unlisted private direct local},
	+ do: visibility

	- defp public_announce?(object, _) do
	- Visibility.public?(object)
	- end
	+ def announce_visibility(object, _), do: Visibility.get_visibility(object)

	@spec get_visibility(map(), map() \| nil, Participation.t() \| nil) ::
	{String.t() \| nil, String.t() \| nil}
	def get_visibility(_, _, %Participation{}), do: {"direct", "direct"}

	def get_visibility(%{visibility: visibility}, in_reply_to, _)
	when visibility in ~w{public local unlisted private direct},
	do: {visibility, get_replied_to_visibility(in_reply_to)}

	def get_visibility(%{visibility: "list:" <> list_id}, in_reply_to, _) do
	visibility = {:list, String.to_integer(list_id)}
	{visibility, get_replied_to_visibility(in_reply_to)}
	end

	def get_visibility(_, in_reply_to, _) when not is_nil(in_reply_to) do
	visibility = get_replied_to_visibility(in_reply_to)
	{visibility, visibility}
	end

	def get_visibility(_, in_reply_to, _), do: {"public", get_replied_to_visibility(in_reply_to)}

	@spec get_replied_to_visibility(Activity.t() \| nil) :: String.t() \| nil
	def get_replied_to_visibility(nil), do: nil

	def get_replied_to_visibility(activity) do
	with %Object{} = object <- Object.normalize(activity, fetch: false) do
	Visibility.get_visibility(object)
	end
	end

	@spec check_expiry_date({:ok, nil \| integer()} \| String.t()) ::
	{:ok, boolean() \| nil} \| {:error, String.t()}
	def check_expiry_date({:ok, nil} = res), do: res

	def check_expiry_date({:ok, in_seconds}) do
	expiry = DateTime.add(DateTime.utc_now(), in_seconds)

	if Pleroma.Workers.PurgeExpiredActivity.expires_late_enough?(expiry) do
	{:ok, expiry}
	else
	{:error, "Expiry date is too soon"}
	end
	end

	def check_expiry_date(expiry_str) do
	Ecto.Type.cast(:integer, expiry_str)
	\|> check_expiry_date()
	end

	@spec listen(User.t(), map()) :: {:ok, Activity.t()} \| {:error, any()}
	def listen(user, data) do
	with {:ok, draft} <- ActivityDraft.listen(user, data) do
	ActivityPub.listen(draft.changes)
	end
	end

	@spec post(User.t(), map()) :: {:ok, Activity.t()} \| {:error, any()}
	def post(user, %{status: _} = data) do
	with {:ok, draft} <- ActivityDraft.create(user, data) do
	ActivityPub.create(draft.changes, draft.preview?)
	end
	end

	@spec update(Activity.t(), User.t(), map()) :: {:ok, Activity.t()} \| {:error, nil}
	def update(orig_activity, %User{} = user, changes) do
	with orig_object <- Object.normalize(orig_activity),
	{:ok, new_object} <- make_update_data(user, orig_object, changes),
	{:ok, update_data, _} <- Builder.update(user, new_object),
	{:ok, update, _} <- Pipeline.common_pipeline(update_data, local: true) do
	{:ok, update}
	else
	_ -> {:error, nil}
	end
	end

	defp make_update_data(user, orig_object, changes) do
	kept_params = %{
	visibility: Visibility.get_visibility(orig_object),
	in_reply_to_id:
	with replied_id when is_binary(replied_id) <- orig_object.data["inReplyTo"],
	%Activity{id: activity_id} <- Activity.get_create_by_object_ap_id(replied_id) do
	activity_id
	else
	_ -> nil
	end
	}

	params = Map.merge(changes, kept_params)

	with {:ok, draft} <- ActivityDraft.create(user, params) do
	change =
	Object.Updater.make_update_object_data(orig_object.data, draft.object, Utils.make_date())

	{:ok, change}
	else
	_ -> {:error, nil}
	end
	end

	@spec pin(String.t(), User.t()) :: {:ok, Activity.t()} \| Pipeline.errors()
	def pin(id, %User{} = user) do
	with %Activity{} = activity <- create_activity_by_id(id),
	true <- activity_visible_to_actor(activity, user),
	true <- activity_belongs_to_actor(activity, user.ap_id),
	true <- object_type_is_allowed_for_pin(activity.object),
	true <- activity_is_public(activity),
	{:ok, pin_data, _} <- Builder.pin(user, activity.object),
	{:ok, _pin, _} <-
	Pipeline.common_pipeline(pin_data,
	local: true,
	activity_id: id
	) do
	{:ok, activity}
	else
	{:error, {:side_effects, error}} -> error
	error -> error
	end
	end

	defp create_activity_by_id(id) do
	with nil <- Activity.create_by_id_with_object(id) do
	{:error, :not_found}
	end
	end

	defp activity_belongs_to_actor(%{actor: actor}, actor), do: true
	defp activity_belongs_to_actor(_, _), do: {:error, :ownership_error}

	defp activity_visible_to_actor(activity, %User{} = user) do
	if Visibility.visible_for_user?(activity, user) do
	true
	else
	{:error, :visibility_error}
	end
	end

	defp object_type_is_allowed_for_pin(%{data: %{"type" => type}}) do
	with false <- type in ["Note", "Article", "Question"] do
	{:error, :not_allowed}
	end
	end

	defp activity_is_public(activity) do
	with false <- Visibility.public?(activity) do
	{:error, :non_public_error}
	end
	end

	@spec unpin(String.t(), User.t()) :: {:ok, Activity.t()} \| Pipeline.errors()
	def unpin(id, user) do
	# Order of visibility/belonging matters for MastoAPI responses.
	# post not visible -> 404
	# post visible, not owned -> 422
	with %Activity{} = activity <- create_activity_by_id(id),
	true <- activity_visible_to_actor(activity, user),
	true <- activity_belongs_to_actor(activity, user.ap_id),
	{:ok, unpin_data, _} <- Builder.unpin(user, activity.object),
	{:ok, _unpin, _} <-
	Pipeline.common_pipeline(unpin_data,
	local: true,
	activity_id: activity.id,
	expires_at: activity.data["expires_at"],
	featured_address: user.featured_address
	) do
	{:ok, activity}
	end
	end

	@spec add_mute(Activity.t(), User.t(), map()) :: {:ok, Activity.t()} \| {:error, String.t()}
	def add_mute(activity, user, params \\ %{}) do
	expires_in = Map.get(params, :expires_in, 0)

	with true <- activity_visible_to_actor(activity, user),
	{:ok, _} <- ThreadMute.add_mute(user.id, activity.data["context"]),
	_ <- Pleroma.Notification.mark_context_as_read(user, activity.data["context"]) do
	if expires_in > 0 do
	Pleroma.Workers.MuteExpireWorker.new(
	%{"op" => "unmute_conversation", "user_id" => user.id, "activity_id" => activity.id},
	schedule_in: expires_in
	)
	\|> Oban.insert()
	end

	{:ok, activity}
	else
	{:error, :visibility_error} -> {:error, :visibility_error}
	{:error, _} -> {:error, dgettext("errors", "conversation is already muted")}
	end
	end

	@spec remove_mute(Activity.t(), User.t()) :: {:ok, Activity.t()} \| {:error, any()}
	def remove_mute(%Activity{} = activity, %User{} = user) do
	case activity_visible_to_actor(activity, user) do
	true ->
	ThreadMute.remove_mute(user.id, activity.data["context"])
	{:ok, activity}

	error ->
	error
	end
	end

	@spec remove_mute(String.t(), String.t()) :: {:ok, Activity.t()} \| {:error, any()}
	def remove_mute(activity_id, user_id) do
	with {:user, %User{} = user} <- {:user, User.get_by_id(user_id)},
	{:activity, %Activity{} = activity} <- {:activity, Activity.get_by_id(activity_id)} do
	remove_mute(activity, user)
	else
	{what, result} = error ->
	Logger.warning(
	"CommonAPI.remove_mute/2 failed. #{what}: #{result}, user_id: #{user_id}, activity_id: #{activity_id}"
	)

	{:error, error}
	end
	end

	@spec thread_muted?(Activity.t(), User.t()) :: boolean()
	def thread_muted?(%{data: %{"context" => context}}, %User{id: user_id})
	when is_binary(context) do
	ThreadMute.exists?(user_id, context)
	end

	def thread_muted?(_, _), do: false

	@spec report(User.t(), map()) :: {:ok, Activity.t()} \| {:error, any()}
	def report(user, data) do
	with {:ok, account} <- get_reported_account(data.account_id),
	{:ok, {content_html, _, _}} <- make_report_content_html(data[:comment]),
	{:ok, statuses} <- get_report_statuses(account, data),
	true <- check_statuses_visibility(user, statuses),
	rules <- get_report_rules(Map.get(data, :rule_ids, nil)) do
	ActivityPub.flag(%{
	context: Utils.generate_context_id(),
	actor: user,
	account: account,
	statuses: statuses,
	content: content_html,
	forward: Map.get(data, :forward, false),
	rules: rules
	})
	else
	false ->
	{:error, :visibility_error}

	error ->
	error
	end
	end

	defp check_statuses_visibility(user, statuses) when is_list(statuses) do
	visibility = for status <- statuses, do: Visibility.visible_for_user?(status, user)

	case Enum.all?(visibility) do
	true -> true
	_ -> false
	end
	end

	# There are no statuses associated with the report, pass!
	defp check_statuses_visibility(_, status) when status == nil, do: true

	defp get_reported_account(account_id) do
	case User.get_cached_by_id(account_id) do
	%User{} = account -> {:ok, account}
	_ -> {:error, dgettext("errors", "Account not found")}
	end
	end

	defp get_report_rules(nil) do
	nil
	end

	defp get_report_rules(rule_ids) do
	rule_ids
	\|> Enum.filter(&Rule.exists?/1)
	end

	@spec update_report_state(String.t() \| [String.t()], String.t()) ::
	{:ok, any()} \| {:error, any()}
	def update_report_state(activity_ids, state) when is_list(activity_ids) do
	case Utils.update_report_state(activity_ids, state) do
	:ok -> {:ok, activity_ids}
	_ -> {:error, dgettext("errors", "Could not update state")}
	end
	end

	def update_report_state(activity_id, state) do
	with %Activity{} = activity <- Activity.get_by_id(activity_id, filter: []) do
	Utils.update_report_state(activity, state)
	else
	nil -> {:error, :not_found}
	end
	end

	def assign_report_to_account(activity_ids, user) when is_list(activity_ids) do
	case Utils.assign_report_to_account(activity_ids, user) do
	:ok -> {:ok, activity_ids}
	_ -> {:error, dgettext("errors", "Could not assign account")}
	end
	end

	def assign_report_to_account(activity_id, user) do
	with %Activity{} = activity <- Activity.get_by_id(activity_id) do
	Utils.assign_report_to_account(activity, user)
	else
	nil -> {:error, :not_found}
	_ -> {:error, dgettext("errors", "Could not assign account")}
	end
	end

	@spec update_activity_scope(String.t(), map()) :: {:ok, any()} \| {:error, any()}
	def update_activity_scope(activity_id, opts \\ %{}) do
	with %Activity{} = activity <- Activity.get_by_id_with_object(activity_id),
	{:ok, activity} <- toggle_sensitive(activity, opts) do
	set_visibility(activity, opts)
	else
	nil -> {:error, :not_found}
	end
	end

	defp toggle_sensitive(activity, %{sensitive: sensitive}) when sensitive in ~w(true false) do
	toggle_sensitive(activity, %{sensitive: String.to_existing_atom(sensitive)})
	end

	defp toggle_sensitive(%Activity{object: object} = activity, %{sensitive: sensitive})
	when is_boolean(sensitive) do
	new_data = Map.put(object.data, "sensitive", sensitive)

	{:ok, object} =
	object
	\|> Object.change(%{data: new_data})
	\|> Object.update_and_set_cache()

	{:ok, Map.put(activity, :object, object)}
	end

	defp toggle_sensitive(activity, _), do: {:ok, activity}

	defp set_visibility(activity, %{visibility: visibility}) do
	Utils.update_activity_visibility(activity, visibility)
	end

	defp set_visibility(activity, _), do: {:ok, activity}

	@spec hide_reblogs(User.t(), User.t()) :: {:ok, any()} \| {:error, any()}
	def hide_reblogs(%User{} = target, %User{} = user) do
	UserRelationship.create_reblog_mute(user, target)
	end

	@spec show_reblogs(User.t(), User.t()) :: {:ok, any()} \| {:error, any()}
	def show_reblogs(%User{} = target, %User{} = user) do
	UserRelationship.delete_reblog_mute(user, target)
	end

	@spec get_user(String.t(), boolean()) :: User.t() \| nil
	def get_user(ap_id, fake_record_fallback \\ true) do
	cond do
	user = User.get_cached_by_ap_id(ap_id) ->
	user

	user = User.get_by_guessed_nickname(ap_id) ->
	user

	fake_record_fallback ->
	# TODO: refactor (fake records is never a good idea)
	User.error_user(ap_id)

	true ->
	nil
	end
	end

	defp maybe_cancel_jobs(%Activity{id: activity_id}) do
	Oban.Job
	\|> where([j], j.worker == "Pleroma.Workers.PublisherWorker")
	\|> where([j], j.args["op"] == "publish_one")
	\|> where([j], j.args["params"]["activity_id"] == ^activity_id)
	\|> Oban.cancel_all_jobs()
	end

	defp maybe_cancel_jobs(_), do: {:ok, 0}
	end
	diff --git a/lib/pleroma/web/common_api/utils.ex b/lib/pleroma/web/common_api/utils.ex
	index 91bf9c502..32572a721 100644
	--- a/lib/pleroma/web/common_api/utils.ex
	+++ b/lib/pleroma/web/common_api/utils.ex
	@@ -1,497 +1,519 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Web.CommonAPI.Utils do
	import Pleroma.Web.Gettext

	alias Calendar.Strftime
	alias Pleroma.Activity
	alias Pleroma.Config
	alias Pleroma.Conversation.Participation
	alias Pleroma.Formatter
	alias Pleroma.Object
	alias Pleroma.Repo
	alias Pleroma.User
	alias Pleroma.Web.ActivityPub.Utils
	alias Pleroma.Web.ActivityPub.Visibility
	alias Pleroma.Web.CommonAPI.ActivityDraft
	alias Pleroma.Web.MediaProxy
	alias Pleroma.Web.Plugs.AuthenticationPlug
	alias Pleroma.Web.Utils.Params

	require Logger
	require Pleroma.Constants

	def attachments_from_ids(%{media_ids: ids, descriptions: desc}, user) do
	attachments_from_ids_descs(ids, desc, user)
	end

	def attachments_from_ids(%{media_ids: ids}, user) do
	attachments_from_ids_no_descs(ids, user)
	end

	def attachments_from_ids(_, _), do: []

	def attachments_from_ids_no_descs([], _), do: []

	def attachments_from_ids_no_descs(ids, user) do
	Enum.map(ids, fn media_id ->
	case get_attachment(media_id, user) do
	%Object{data: data} -> data
	_ -> nil
	end
	end)
	\|> Enum.reject(&is_nil/1)
	end

	def attachments_from_ids_descs([], _, _), do: []

	def attachments_from_ids_descs(ids, descs_str, user) do
	{_, descs} = Jason.decode(descs_str)

	Enum.map(ids, fn media_id ->
	with %Object{data: data} <- get_attachment(media_id, user) do
	Map.put(data, "name", descs[media_id])
	end
	end)
	\|> Enum.reject(&is_nil/1)
	end

	defp get_attachment(media_id, user) do
	with %Object{data: data} = object <- Repo.get(Object, media_id),
	%{"type" => type} when type in Pleroma.Constants.upload_object_types() <- data,
	:ok <- Object.authorize_access(object, user) do
	object
	else
	_ -> nil
	end
	end

	@spec get_to_and_cc(ActivityDraft.t()) :: {list(String.t()), list(String.t())}

	def get_to_and_cc(%{in_reply_to_conversation: %Participation{} = participation}) do
	participation = Repo.preload(participation, :recipients)
	{Enum.map(participation.recipients, & &1.ap_id), []}
	end

	- def get_to_and_cc(%{visibility: visibility} = draft) when visibility in ["public", "local"] do
	- to =
	- case visibility do
	- "public" -> [Pleroma.Constants.as_public() \| draft.mentions]
	- "local" -> [Utils.as_local_public() \| draft.mentions]
	+ def get_to_and_cc(%{visibility: visibility} = draft) do
	+ # If the OP is a DM already, add the implicit actor
	+ mentions =
	+ if visibility == "direct" && draft.in_reply_to && Visibility.direct?(draft.in_reply_to) do
	+ Enum.uniq([draft.in_reply_to.data["actor"] \| draft.mentions])
	+ else
	+ draft.mentions
	end

	- cc = [draft.user.follower_address]
	+ get_to_and_cc_for_visibility(
	+ visibility,
	+ draft.user.follower_address,
	+ draft.in_reply_to && draft.in_reply_to.data["actor"],
	+ mentions
	+ )
	+ end

	- if draft.in_reply_to do
	- {Enum.uniq([draft.in_reply_to.data["actor"] \| to]), cc}
	- else
	- {to, cc}
	- end
	+ def get_to_and_cc_for_visibility("public", follower_collection, parent_actor, mentions) do
	+ scope_addr = Pleroma.Constants.as_public()
	+
	+ to =
	+ if parent_actor,
	+ do: Enum.uniq([parent_actor, scope_addr \| mentions]),
	+ else: [scope_addr \| mentions]
	+
	+ {to, [follower_collection]}
	end

	- def get_to_and_cc(%{visibility: "unlisted"} = draft) do
	- to = [draft.user.follower_address \| draft.mentions]
	- cc = [Pleroma.Constants.as_public()]
	+ def get_to_and_cc_for_visibility("local", follower_collection, parent_actor, mentions) do
	+ recipients =
	+ if parent_actor,
	+ do: Enum.uniq([parent_actor \| mentions]),
	+ else: mentions

	- if draft.in_reply_to do
	- {Enum.uniq([draft.in_reply_to.data["actor"] \| to]), cc}
	- else
	- {to, cc}
	- end
	+ to = [
	+ Utils.as_local_public()
	+ \| Enum.filter(recipients, fn addr ->
	+ String.starts_with?(addr, Pleroma.Web.Endpoint.url() <> "/")
	+ end)
	+ ]
	+
	+ {to, [follower_collection]}
	end

	- def get_to_and_cc(%{visibility: "private"} = draft) do
	- {to, cc} = get_to_and_cc(struct(draft, visibility: "direct"))
	- {[draft.user.follower_address \| to], cc}
	+ def get_to_and_cc_for_visibility("unlisted", follower_collection, parent_actor, mentions) do
	+ to =
	+ if parent_actor,
	+ do: Enum.uniq([parent_actor, follower_collection \| mentions]),
	+ else: [follower_collection \| mentions]
	+
	+ {to, [Pleroma.Constants.as_public()]}
	end

	- def get_to_and_cc(%{visibility: "direct"} = draft) do
	- # If the OP is a DM already, add the implicit actor.
	- if draft.in_reply_to && Visibility.direct?(draft.in_reply_to) do
	- {Enum.uniq([draft.in_reply_to.data["actor"] \| draft.mentions]), []}
	- else
	- {draft.mentions, []}
	- end
	+ def get_to_and_cc_for_visibility("private", follower_collection, _, mentions) do
	+ {[follower_collection \| mentions], []}
	+ end
	+
	+ def get_to_and_cc_for_visibility("direct", _, _, mentions) do
	+ {mentions, []}
	end

	- def get_to_and_cc(%{visibility: {:list, _}, mentions: mentions}), do: {mentions, []}
	+ def get_to_and_cc_for_visibility({:list, _}, _, _, mentions) do
	+ {mentions, []}
	+ end

	def get_addressed_users(_, to) when is_list(to) do
	User.get_ap_ids_by_nicknames(to)
	end

	def get_addressed_users(mentioned_users, _), do: mentioned_users

	def maybe_add_list_data(activity_params, user, {:list, list_id}) do
	case Pleroma.List.get(list_id, user) do
	%Pleroma.List{} = list ->
	activity_params
	\|> put_in([:additional, "bcc"], [list.ap_id])
	\|> put_in([:additional, "listMessage"], list.ap_id)
	\|> put_in([:object, "listMessage"], list.ap_id)

	_ ->
	activity_params
	end
	end

	def maybe_add_list_data(activity_params, _, _), do: activity_params

	def make_poll_data(%{"poll" => %{"expires_in" => expires_in}} = data)
	when is_binary(expires_in) do
	# In some cases mastofe sends out strings instead of integers
	data
	\|> put_in(["poll", "expires_in"], String.to_integer(expires_in))
	\|> make_poll_data()
	end

	def make_poll_data(%{poll: %{options: options, expires_in: expires_in}} = data)
	when is_list(options) do
	limits = Config.get([:instance, :poll_limits])

	options = options \|> Enum.uniq()

	with :ok <- validate_poll_expiration(expires_in, limits),
	:ok <- validate_poll_options_amount(options, limits),
	:ok <- validate_poll_options_length(options, limits) do
	{option_notes, emoji} =
	Enum.map_reduce(options, %{}, fn option, emoji ->
	note = %{
	"name" => option,
	"type" => "Note",
	"replies" => %{"type" => "Collection", "totalItems" => 0}
	}

	{note, Map.merge(emoji, Pleroma.Emoji.Formatter.get_emoji_map(option))}
	end)

	end_time =
	DateTime.utc_now()
	\|> DateTime.add(expires_in)
	\|> DateTime.to_iso8601()

	key = if Params.truthy_param?(data.poll[:multiple]), do: "anyOf", else: "oneOf"
	poll = %{"type" => "Question", key => option_notes, "closed" => end_time}

	{:ok, {poll, emoji}}
	end
	end

	def make_poll_data(%{"poll" => poll}) when is_map(poll) do
	{:error, "Invalid poll"}
	end

	def make_poll_data(_data) do
	{:ok, {%{}, %{}}}
	end

	defp validate_poll_options_amount(options, %{max_options: max_options}) do
	cond do
	Enum.count(options) < 2 ->
	{:error, "Poll must contain at least 2 options"}

	Enum.count(options) > max_options ->
	{:error, "Poll can't contain more than #{max_options} options"}

	true ->
	:ok
	end
	end

	defp validate_poll_options_length(options, %{max_option_chars: max_option_chars}) do
	if Enum.any?(options, &(String.length(&1) > max_option_chars)) do
	{:error, "Poll options cannot be longer than #{max_option_chars} characters each"}
	else
	:ok
	end
	end

	defp validate_poll_expiration(expires_in, %{min_expiration: min, max_expiration: max}) do
	cond do
	expires_in > max -> {:error, "Expiration date is too far in the future"}
	expires_in < min -> {:error, "Expiration date is too soon"}
	true -> :ok
	end
	end

	def make_content_html(%ActivityDraft{} = draft) do
	attachment_links =
	draft.params
	\|> Map.get("attachment_links", Config.get([:instance, :attachment_links]))
	\|> Params.truthy_param?()

	content_type = get_content_type(draft.params[:content_type])

	options =
	if draft.visibility == "direct" && Config.get([:instance, :safe_dm_mentions]) do
	[safe_mention: true]
	else
	[]
	end

	draft.status
	\|> format_input(content_type, options)
	\|> maybe_add_attachments(draft.attachments, attachment_links)
	end

	def get_content_type(content_type) do
	if Enum.member?(Config.get([:instance, :allowed_post_formats]), content_type) do
	content_type
	else
	"text/plain"
	end
	end

	def make_context(_, %Participation{} = participation) do
	Repo.preload(participation, :conversation).conversation.ap_id
	end

	def make_context(%Activity{data: %{"context" => context}}, _), do: context
	def make_context(_, _), do: Utils.generate_context_id()

	def maybe_add_attachments(parsed, _attachments, false = _no_links), do: parsed

	def maybe_add_attachments({text, mentions, tags}, attachments, _no_links) do
	text = add_attachments(text, attachments)
	{text, mentions, tags}
	end

	def add_attachments(text, attachments) do
	attachment_text = Enum.map(attachments, &build_attachment_link/1)
	Enum.join([text \| attachment_text], "<br>")
	end

	defp build_attachment_link(%{"url" => [%{"href" => href} \| _]} = attachment) do
	name = attachment["name"] \|\| URI.decode(Path.basename(href))
	href = MediaProxy.url(href)
	"<a href=\"#{href}\" class='attachment'>#{shortname(name)}</a>"
	end

	defp build_attachment_link(_), do: ""

	def format_input(text, format, options \\ [])

	@doc """
	Formatting text to plain text, BBCode, HTML, or Markdown
	"""
	def format_input(text, "text/plain", options) do
	text
	\|> Formatter.html_escape("text/plain")
	\|> Formatter.linkify(options)
	\|> (fn {text, mentions, tags} ->
	{String.replace(text, ~r/\r?\n/, "<br>"), mentions, tags}
	end).()
	end

	def format_input(text, "text/bbcode", options) do
	text
	\|> String.replace(~r/\r/, "")
	\|> Formatter.html_escape("text/plain")
	\|> BBCode.to_html()
	\|> (fn {:ok, html} -> html end).()
	\|> Formatter.linkify(options)
	end

	def format_input(text, "text/html", options) do
	text
	\|> Formatter.html_escape("text/html")
	\|> Formatter.linkify(options)
	end

	def format_input(text, "text/markdown", options) do
	text
	\|> Formatter.mentions_escape(options)
	\|> Formatter.markdown_to_html()
	\|> Formatter.linkify(options)
	\|> Formatter.html_escape("text/html")
	end

	def format_naive_asctime(date) do
	date \|> DateTime.from_naive!("Etc/UTC") \|> format_asctime
	end

	def format_asctime(date) do
	Strftime.strftime!(date, "%a %b %d %H:%M:%S %z %Y")
	end

	def date_to_asctime(date) when is_binary(date) do
	with {:ok, date, _offset} <- DateTime.from_iso8601(date) do
	format_asctime(date)
	else
	_e ->
	Logger.warning("Date #{date} in wrong format, must be ISO 8601")
	""
	end
	end

	def date_to_asctime(date) do
	Logger.warning("Date #{date} in wrong format, must be ISO 8601")
	""
	end

	def to_masto_date(%NaiveDateTime{} = date) do
	date
	\|> NaiveDateTime.to_iso8601()
	\|> String.replace(~r/(\.\d+)?$/, ".000Z", global: false)
	end

	def to_masto_date(date) when is_binary(date) do
	with {:ok, date} <- NaiveDateTime.from_iso8601(date) do
	to_masto_date(date)
	else
	_ -> ""
	end
	end

	def to_masto_date(_), do: ""

	defp shortname(name) do
	with max_length when max_length > 0 <-
	Config.get([Pleroma.Upload, :filename_display_max_length], 30),
	true <- String.length(name) > max_length do
	String.slice(name, 0..max_length) <> "…"
	else
	_ -> name
	end
	end

	@spec confirm_current_password(User.t(), String.t()) :: {:ok, User.t()} \| {:error, String.t()}
	def confirm_current_password(user, password) do
	with %User{local: true} = db_user <- User.get_cached_by_id(user.id),
	true <- AuthenticationPlug.checkpw(password, db_user.password_hash) do
	{:ok, db_user}
	else
	_ -> {:error, dgettext("errors", "Invalid password.")}
	end
	end

	def maybe_notify_to_recipients(
	recipients,
	%Activity{data: %{"to" => to, "type" => _type}} = _activity
	) do
	recipients ++ to
	end

	def maybe_notify_to_recipients(recipients, _), do: recipients

	def maybe_notify_mentioned_recipients(
	recipients,
	%Activity{data: %{"to" => _to, "type" => type} = data} = activity
	)
	when type == "Create" do
	object = Object.normalize(activity, fetch: false)

	object_data =
	cond do
	not is_nil(object) ->
	object.data

	is_map(data["object"]) ->
	data["object"]

	true ->
	%{}
	end

	tagged_mentions = maybe_extract_mentions(object_data)

	recipients ++ tagged_mentions
	end

	def maybe_notify_mentioned_recipients(recipients, _), do: recipients

	def maybe_notify_followers(recipients, %Activity{data: %{"type" => "Move"}} = activity) do
	with %User{} = user <- User.get_cached_by_ap_id(activity.actor) do
	user
	\|> User.get_followers()
	\|> Enum.map(& &1.ap_id)
	\|> Enum.concat(recipients)
	else
	_e -> recipients
	end
	end

	def maybe_notify_followers(recipients, _), do: recipients

	def get_notified_subscribers(
	%Activity{data: %{"actor" => actor, "type" => "Create"}} = activity
	) do
	# Do not notify subscribers if author is making a reply
	with %Object{data: object} <- Object.normalize(activity, fetch: false),
	nil <- object["inReplyTo"],
	%User{} = user <- User.get_cached_by_ap_id(actor) do
	subscriber_ids =
	user
	\|> User.subscriber_users()
	\|> Enum.filter(&Visibility.visible_for_user?(activity, &1))
	\|> Enum.map(& &1.ap_id)

	subscriber_ids
	else
	_e -> []
	end
	end

	def get_notified_subscribers(_), do: []

	def maybe_extract_mentions(%{"tag" => tag}) do
	tag
	\|> Enum.filter(fn x -> is_map(x) && x["type"] == "Mention" end)
	\|> Enum.map(fn x -> x["href"] end)
	\|> Enum.uniq()
	end

	def maybe_extract_mentions(_), do: []

	def make_report_content_html(nil), do: {:ok, {nil, [], []}}

	def make_report_content_html(comment) do
	max_size = Config.get([:instance, :max_report_comment_size], 1000)

	if String.length(comment) <= max_size do
	{:ok, format_input(comment, "text/plain")}
	else
	{:error,
	dgettext("errors", "Comment must be up to %{max_size} characters", max_size: max_size)}
	end
	end

	def get_report_statuses(%User{ap_id: actor}, %{status_ids: status_ids})
	when is_list(status_ids) do
	{:ok, Activity.all_by_actor_and_id(actor, status_ids)}
	end

	def get_report_statuses(_, _), do: {:ok, nil}

	def validate_character_limit("" = _full_payload, [] = _attachments) do
	{:error, dgettext("errors", "Cannot post an empty status without attachments")}
	end

	def validate_character_limit(full_payload, _attachments) do
	limit = Config.get([:instance, :limit])
	length = String.length(full_payload)

	if length <= limit do
	:ok
	else
	{:error, dgettext("errors", "The status is over the character limit")}
	end
	end

	def validate_attachments_count([] = _attachments) do
	:ok
	end

	def validate_attachments_count(attachments) do
	limit = Config.get([:instance, :max_media_attachments])
	count = length(attachments)

	if count <= limit do
	:ok
	else
	{:error, dgettext("errors", "Too many attachments")}
	end
	end
	end
	diff --git a/test/pleroma/web/activity_pub/object_validators/announce_validation_test.exs b/test/pleroma/web/activity_pub/object_validators/announce_validation_test.exs
	index 5b2fcb26d..1ca4f04f6 100644
	--- a/test/pleroma/web/activity_pub/object_validators/announce_validation_test.exs
	+++ b/test/pleroma/web/activity_pub/object_validators/announce_validation_test.exs
	@@ -1,108 +1,117 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Web.ActivityPub.ObjectValidators.AnnounceValidationTest do
	use Pleroma.DataCase, async: true

	alias Pleroma.Object
	alias Pleroma.Web.ActivityPub.Builder
	alias Pleroma.Web.ActivityPub.ObjectValidator
	alias Pleroma.Web.CommonAPI

	import Pleroma.Factory

	describe "announces" do
	setup do
	user = insert(:user)
	announcer = insert(:user)
	{:ok, post_activity} = CommonAPI.post(user, %{status: "uguu"})

	object = Object.normalize(post_activity, fetch: false)
	{:ok, valid_announce, []} = Builder.announce(announcer, object)

	%{
	valid_announce: valid_announce,
	user: user,
	post_activity: post_activity,
	announcer: announcer
	}
	end

	test "returns ok for a valid announce", %{valid_announce: valid_announce} do
	assert {:ok, _object, _meta} = ObjectValidator.validate(valid_announce, [])
	end

	test "keeps announced object context", %{valid_announce: valid_announce} do
	assert %Object{data: %{"context" => object_context}} =
	Object.get_cached_by_ap_id(valid_announce["object"])

	{:ok, %{"context" => context}, _} =
	valid_announce
	\|> Map.put("context", "https://example.org/invalid_context_id")
	\|> ObjectValidator.validate([])

	assert context == object_context
	end

	test "returns an error if the object can't be found", %{valid_announce: valid_announce} do
	without_object =
	valid_announce
	\|> Map.delete("object")

	{:error, cng} = ObjectValidator.validate(without_object, [])

	assert {:object, {"can't be blank", [validation: :required]}} in cng.errors

	nonexisting_object =
	valid_announce
	\|> Map.put("object", "https://gensokyo.2hu/objects/99999999")

	{:error, cng} = ObjectValidator.validate(nonexisting_object, [])

	assert {:object, {"can't find object", []}} in cng.errors
	end

	test "returns an error if the actor already announced the object", %{
	valid_announce: valid_announce,
	announcer: announcer,
	post_activity: post_activity
	} do
	_announce = CommonAPI.repeat(post_activity.id, announcer)

	{:error, cng} = ObjectValidator.validate(valid_announce, [])

	assert {:actor, {"already announced this object", []}} in cng.errors
	assert {:object, {"already announced by this actor", []}} in cng.errors
	end

	test "returns an error if the actor can't announce the object", %{
	announcer: announcer,
	user: user
	} do
	{:ok, post_activity} =
	CommonAPI.post(user, %{status: "a secret post", visibility: "private"})

	object = Object.normalize(post_activity, fetch: false)

	# Another user can't announce it
	- {:ok, announce, []} = Builder.announce(announcer, object, public: false)
	+ {:ok, announce, []} = Builder.announce(announcer, object, visibility: "private")

	{:error, cng} = ObjectValidator.validate(announce, [])

	assert {:actor, {"can not announce this object", []}} in cng.errors

	- # The actor of the object can announce it
	- {:ok, announce, []} = Builder.announce(user, object, public: false)
	+ # The actor of the object can announce it with a restrictive scope
	+ {:ok, announce, []} = Builder.announce(user, object, visibility: "private")
	+ assert {:ok, _, _} = ObjectValidator.validate(announce, [])

	+ {:ok, announce, []} = Builder.announce(user, object, visibility: "direct")
	assert {:ok, _, _} = ObjectValidator.validate(announce, [])

	# The actor of the object can not announce it publicly
	- {:ok, announce, []} = Builder.announce(user, object, public: true)
	+ {:ok, announce, []} = Builder.announce(user, object, visibility: "public")
	+ {:error, cng1} = ObjectValidator.validate(announce, [])

	- {:error, cng} = ObjectValidator.validate(announce, [])
	+ {:ok, announce, []} = Builder.announce(user, object, visibility: "unlisted")
	+ {:error, cng2} = ObjectValidator.validate(announce, [])
	+
	+ {:ok, announce, []} = Builder.announce(user, object, visibility: "local")
	+ {:error, cng3} = ObjectValidator.validate(announce, [])

	- assert {:actor, {"can not announce this object publicly", []}} in cng.errors
	+ for cng <- [cng1, cng2, cng3] do
	+ assert {:actor, {"can not announce this object publicly", []}} in cng.errors
	+ end
	end
	end
	end
	diff --git a/test/pleroma/web/activity_pub/side_effects_test.exs b/test/pleroma/web/activity_pub/side_effects_test.exs
	index 4a18cab68..6d20c591c 100644
	--- a/test/pleroma/web/activity_pub/side_effects_test.exs
	+++ b/test/pleroma/web/activity_pub/side_effects_test.exs
	@@ -1,979 +1,981 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Web.ActivityPub.SideEffectsTest do
	use Oban.Testing, repo: Pleroma.Repo
	use Pleroma.DataCase

	alias Pleroma.Activity
	alias Pleroma.Chat
	alias Pleroma.Chat.MessageReference
	alias Pleroma.Notification
	alias Pleroma.Object
	alias Pleroma.Repo
	alias Pleroma.Tests.ObanHelpers
	alias Pleroma.User
	alias Pleroma.Web.ActivityPub.ActivityPub
	alias Pleroma.Web.ActivityPub.Builder
	alias Pleroma.Web.ActivityPub.SideEffects
	alias Pleroma.Web.ActivityPub.Utils
	alias Pleroma.Web.CommonAPI
	alias Pleroma.Web.CommonAPI.ActivityDraft

	import Mock
	import Pleroma.Factory

	defp get_announces_of_object(%{data: %{"id" => id}} = _object) do
	Pleroma.Activity.Queries.by_type("Announce")
	\|> Pleroma.Activity.Queries.by_object_id(id)
	\|> Pleroma.Repo.all()
	end

	describe "handle_after_transaction" do
	test "it streams out notifications and streams" do
	author = insert(:user, local: true)
	recipient = insert(:user, local: true)

	{:ok, chat_message_data, _meta} = Builder.chat_message(author, recipient.ap_id, "hey")

	{:ok, create_activity_data, _meta} =
	Builder.create(author, chat_message_data["id"], [recipient.ap_id])

	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, meta} =
	SideEffects.handle(create_activity, local: false, object_data: chat_message_data)

	assert [notification] = meta[:notifications]

	with_mocks([
	{
	Pleroma.Web.Streamer,
	[],
	[
	stream: fn _, _ -> nil end
	]
	}
	]) do
	SideEffects.handle_after_transaction(meta)

	assert called(Pleroma.Web.Streamer.stream(["user", "user:notification"], notification))
	assert called(Pleroma.Web.Streamer.stream(["user", "user:pleroma_chat"], :_))

	assert_enqueued(
	worker: "Pleroma.Workers.WebPusherWorker",
	args: %{"notification_id" => notification.id, "op" => "web_push"}
	)
	end
	end
	end

	describe "blocking users" do
	setup do
	user = insert(:user)
	blocked = insert(:user)
	User.follow(blocked, user)
	User.follow(user, blocked)

	{:ok, block_data, []} = Builder.block(user, blocked)
	{:ok, block, _meta} = ActivityPub.persist(block_data, local: true)

	%{user: user, blocked: blocked, block: block}
	end

	test "it unfollows and blocks", %{user: user, blocked: blocked, block: block} do
	assert User.following?(user, blocked)
	assert User.following?(blocked, user)

	{:ok, _, _} = SideEffects.handle(block)

	refute User.following?(user, blocked)
	refute User.following?(blocked, user)
	assert User.blocks?(user, blocked)
	end

	test "it updates following relationship", %{user: user, blocked: blocked, block: block} do
	{:ok, _, _} = SideEffects.handle(block)

	refute Pleroma.FollowingRelationship.get(user, blocked)
	assert User.get_follow_state(user, blocked) == nil
	assert User.get_follow_state(blocked, user) == nil
	assert User.get_follow_state(user, blocked, nil) == nil
	assert User.get_follow_state(blocked, user, nil) == nil
	end

	test "it blocks but does not unfollow if the relevant setting is set", %{
	user: user,
	blocked: blocked,
	block: block
	} do
	clear_config([:activitypub, :unfollow_blocked], false)
	assert User.following?(user, blocked)
	assert User.following?(blocked, user)

	{:ok, _, _} = SideEffects.handle(block)

	refute User.following?(user, blocked)
	assert User.following?(blocked, user)
	assert User.blocks?(user, blocked)
	end
	end

	describe "update users" do
	setup do
	user = insert(:user, local: false)

	{:ok, update_data, []} =
	Builder.update(user, %{"id" => user.ap_id, "type" => "Person", "name" => "new name!"})

	{:ok, update, _meta} = ActivityPub.persist(update_data, local: true)

	%{user: user, update_data: update_data, update: update}
	end

	test "it updates the user", %{user: user, update: update} do
	{:ok, _, _} = SideEffects.handle(update)
	user = User.get_by_id(user.id)
	assert user.name == "new name!"
	end

	test "it uses a given changeset to update", %{user: user, update: update} do
	changeset = Ecto.Changeset.change(user, %{default_scope: "direct"})

	assert user.default_scope == "public"
	{:ok, _, _} = SideEffects.handle(update, user_update_changeset: changeset)
	user = User.get_by_id(user.id)
	assert user.default_scope == "direct"
	end
	end

	describe "update notes" do
	setup do
	make_time = fn ->
	Pleroma.Web.ActivityPub.Utils.make_date()
	end

	user = insert(:user)
	note = insert(:note, user: user, data: %{"published" => make_time.()})
	_note_activity = insert(:note_activity, note: note)

	updated_note =
	note.data
	\|> Map.put("summary", "edited summary")
	\|> Map.put("content", "edited content")
	\|> Map.put("updated", make_time.())

	{:ok, update_data, []} = Builder.update(user, updated_note)
	{:ok, update, _meta} = ActivityPub.persist(update_data, local: true)

	%{
	user: user,
	note: note,
	object_id: note.id,
	update_data: update_data,
	update: update,
	updated_note: updated_note
	}
	end

	test "it updates the note", %{
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	updated_time = updated_note["updated"]

	new_note = Pleroma.Object.get_by_id(object_id)

	assert %{
	"summary" => "edited summary",
	"content" => "edited content",
	"updated" => ^updated_time
	} = new_note.data
	end

	test "it rejects updates with no updated attribute in object", %{
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	old_note = Pleroma.Object.get_by_id(object_id)
	updated_note = Map.drop(updated_note, ["updated"])
	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	new_note = Pleroma.Object.get_by_id(object_id)
	assert old_note.data == new_note.data
	end

	test "it rejects updates with updated attribute older than what we have in the original object",
	%{
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	old_note = Pleroma.Object.get_by_id(object_id)
	{:ok, creation_time, _} = DateTime.from_iso8601(old_note.data["published"])

	updated_note =
	Map.put(updated_note, "updated", DateTime.to_iso8601(DateTime.add(creation_time, -10)))

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	new_note = Pleroma.Object.get_by_id(object_id)
	assert old_note.data == new_note.data
	end

	test "it rejects updates with updated attribute older than the last Update", %{
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	old_note = Pleroma.Object.get_by_id(object_id)
	{:ok, creation_time, _} = DateTime.from_iso8601(old_note.data["published"])

	updated_note =
	Map.put(updated_note, "updated", DateTime.to_iso8601(DateTime.add(creation_time, +10)))

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)

	old_note = Pleroma.Object.get_by_id(object_id)
	{:ok, update_time, _} = DateTime.from_iso8601(old_note.data["updated"])

	updated_note =
	Map.put(updated_note, "updated", DateTime.to_iso8601(DateTime.add(update_time, -5)))

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)

	new_note = Pleroma.Object.get_by_id(object_id)
	assert old_note.data == new_note.data
	end

	test "it updates using object_data", %{
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	updated_note = Map.put(updated_note, "summary", "mew mew")
	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	new_note = Pleroma.Object.get_by_id(object_id)
	assert %{"summary" => "mew mew", "content" => "edited content"} = new_note.data
	end

	test "it records the original note in formerRepresentations", %{
	note: note,
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	%{data: new_note} = Pleroma.Object.get_by_id(object_id)
	assert %{"summary" => "edited summary", "content" => "edited content"} = new_note

	assert [Map.drop(note.data, ["id", "formerRepresentations"])] ==
	new_note["formerRepresentations"]["orderedItems"]

	assert new_note["formerRepresentations"]["totalItems"] == 1
	end

	test "it puts the original note at the front of formerRepresentations", %{
	user: user,
	note: note,
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	%{data: first_edit} = Pleroma.Object.get_by_id(object_id)

	second_updated_note =
	note.data
	\|> Map.put("summary", "edited summary 2")
	\|> Map.put("content", "edited content 2")
	\|> Map.put(
	"updated",
	first_edit["updated"]
	\|> DateTime.from_iso8601()
	\|> elem(1)
	\|> DateTime.add(10)
	\|> DateTime.to_iso8601()
	)

	{:ok, second_update_data, []} = Builder.update(user, second_updated_note)
	{:ok, update, _meta} = ActivityPub.persist(second_update_data, local: true)
	{:ok, _, _} = SideEffects.handle(update, object_data: second_updated_note)
	%{data: new_note} = Pleroma.Object.get_by_id(object_id)
	assert %{"summary" => "edited summary 2", "content" => "edited content 2"} = new_note

	original_version = Map.drop(note.data, ["id", "formerRepresentations"])
	first_edit = Map.drop(first_edit, ["id", "formerRepresentations"])

	assert [first_edit, original_version] ==
	new_note["formerRepresentations"]["orderedItems"]

	assert new_note["formerRepresentations"]["totalItems"] == 2
	end

	test "it does not prepend to formerRepresentations if no actual changes are made", %{
	note: note,
	object_id: object_id,
	update: update,
	updated_note: updated_note
	} do
	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	%{data: first_edit} = Pleroma.Object.get_by_id(object_id)

	updated_note =
	updated_note
	\|> Map.put(
	"updated",
	first_edit["updated"]
	\|> DateTime.from_iso8601()
	\|> elem(1)
	\|> DateTime.add(10)
	\|> DateTime.to_iso8601()
	)

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_note)
	%{data: new_note} = Pleroma.Object.get_by_id(object_id)
	assert %{"summary" => "edited summary", "content" => "edited content"} = new_note

	original_version = Map.drop(note.data, ["id", "formerRepresentations"])

	assert [original_version] ==
	new_note["formerRepresentations"]["orderedItems"]

	assert new_note["formerRepresentations"]["totalItems"] == 1
	end
	end

	describe "update questions" do
	setup do
	user = insert(:user)

	question =
	insert(:question,
	user: user,
	data: %{"published" => Pleroma.Web.ActivityPub.Utils.make_date()}
	)

	%{user: user, data: question.data, id: question.id}
	end

	test "allows updating choice count without generating edit history", %{
	user: user,
	data: data,
	id: id
	} do
	new_choices =
	data["oneOf"]
	\|> Enum.map(fn choice -> put_in(choice, ["replies", "totalItems"], 5) end)

	updated_question =
	data
	\|> Map.put("oneOf", new_choices)
	\|> Map.put("updated", Pleroma.Web.ActivityPub.Utils.make_date())

	{:ok, update_data, []} = Builder.update(user, updated_question)
	{:ok, update, _meta} = ActivityPub.persist(update_data, local: true)

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_question)

	%{data: new_question} = Pleroma.Object.get_by_id(id)

	assert [%{"replies" => %{"totalItems" => 5}}, %{"replies" => %{"totalItems" => 5}}] =
	new_question["oneOf"]

	refute Map.has_key?(new_question, "formerRepresentations")
	end

	test "allows updating choice count without updated field", %{
	user: user,
	data: data,
	id: id
	} do
	new_choices =
	data["oneOf"]
	\|> Enum.map(fn choice -> put_in(choice, ["replies", "totalItems"], 5) end)

	updated_question =
	data
	\|> Map.put("oneOf", new_choices)

	{:ok, update_data, []} = Builder.update(user, updated_question)
	{:ok, update, _meta} = ActivityPub.persist(update_data, local: true)

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_question)

	%{data: new_question} = Pleroma.Object.get_by_id(id)

	assert [%{"replies" => %{"totalItems" => 5}}, %{"replies" => %{"totalItems" => 5}}] =
	new_question["oneOf"]

	refute Map.has_key?(new_question, "formerRepresentations")
	end

	test "allows updating choice count with updated field same as the creation date", %{
	user: user,
	data: data,
	id: id
	} do
	new_choices =
	data["oneOf"]
	\|> Enum.map(fn choice -> put_in(choice, ["replies", "totalItems"], 5) end)

	updated_question =
	data
	\|> Map.put("oneOf", new_choices)
	\|> Map.put("updated", data["published"])

	{:ok, update_data, []} = Builder.update(user, updated_question)
	{:ok, update, _meta} = ActivityPub.persist(update_data, local: true)

	{:ok, _, _} = SideEffects.handle(update, object_data: updated_question)

	%{data: new_question} = Pleroma.Object.get_by_id(id)

	assert [%{"replies" => %{"totalItems" => 5}}, %{"replies" => %{"totalItems" => 5}}] =
	new_question["oneOf"]

	refute Map.has_key?(new_question, "formerRepresentations")
	end
	end

	describe "EmojiReact objects" do
	setup do
	poster = insert(:user)
	user = insert(:user)

	{:ok, post} = CommonAPI.post(poster, %{status: "hey"})

	{:ok, emoji_react_data, []} = Builder.emoji_react(user, post.object, "👌")
	{:ok, emoji_react, _meta} = ActivityPub.persist(emoji_react_data, local: true)

	%{emoji_react: emoji_react, user: user, poster: poster}
	end

	test "adds the reaction to the object", %{emoji_react: emoji_react, user: user} do
	{:ok, emoji_react, _} = SideEffects.handle(emoji_react)
	object = Object.get_by_ap_id(emoji_react.data["object"])

	assert object.data["reaction_count"] == 1
	assert ["👌", [user.ap_id], nil] in object.data["reactions"]
	end

	test "creates a notification", %{emoji_react: emoji_react, poster: poster} do
	{:ok, emoji_react, _} = SideEffects.handle(emoji_react)
	assert Repo.get_by(Notification, user_id: poster.id, activity_id: emoji_react.id)
	end
	end

	describe "Question objects" do
	setup do
	user = insert(:user)
	question = build(:question, user: user)
	question_activity = build(:question_activity, question: question)
	activity_data = Map.put(question_activity.data, "object", question.data["id"])
	meta = [object_data: question.data, local: false]

	{:ok, activity, meta} = ActivityPub.persist(activity_data, meta)

	%{activity: activity, meta: meta}
	end

	test "enqueues the poll end", %{activity: activity, meta: meta} do
	{:ok, activity, meta} = SideEffects.handle(activity, meta)

	assert_enqueued(
	worker: Pleroma.Workers.PollWorker,
	args: %{op: "poll_end", activity_id: activity.id},
	scheduled_at: NaiveDateTime.from_iso8601!(meta[:object_data]["closed"])
	)
	end
	end

	describe "delete users with confirmation pending" do
	setup do
	user = insert(:user, is_confirmed: false)
	{:ok, delete_user_data, _meta} = Builder.delete(user, user.ap_id)
	{:ok, delete_user, _meta} = ActivityPub.persist(delete_user_data, local: true)
	{:ok, delete: delete_user, user: user}
	end

	test "when activation is required", %{delete: delete, user: user} do
	clear_config([:instance, :account_activation_required], true)
	{:ok, _, _} = SideEffects.handle(delete)
	ObanHelpers.perform_all()

	refute User.get_cached_by_id(user.id)
	end
	end

	describe "Undo objects" do
	setup do
	poster = insert(:user)
	user = insert(:user)
	{:ok, post} = CommonAPI.post(poster, %{status: "hey"})
	{:ok, like} = CommonAPI.favorite(post.id, user)
	{:ok, reaction} = CommonAPI.react_with_emoji(post.id, user, "👍")
	{:ok, announce} = CommonAPI.repeat(post.id, user)
	{:ok, block} = CommonAPI.block(poster, user)

	{:ok, undo_data, _meta} = Builder.undo(user, like)
	{:ok, like_undo, _meta} = ActivityPub.persist(undo_data, local: true)

	{:ok, undo_data, _meta} = Builder.undo(user, reaction)
	{:ok, reaction_undo, _meta} = ActivityPub.persist(undo_data, local: true)

	{:ok, undo_data, _meta} = Builder.undo(user, announce)
	{:ok, announce_undo, _meta} = ActivityPub.persist(undo_data, local: true)

	{:ok, undo_data, _meta} = Builder.undo(user, block)
	{:ok, block_undo, _meta} = ActivityPub.persist(undo_data, local: true)

	%{
	like_undo: like_undo,
	post: post,
	like: like,
	reaction_undo: reaction_undo,
	reaction: reaction,
	announce_undo: announce_undo,
	announce: announce,
	block_undo: block_undo,
	block: block,
	poster: poster,
	user: user
	}
	end

	test "deletes the original block", %{
	block_undo: block_undo,
	block: block
	} do
	{:ok, _block_undo, _meta} = SideEffects.handle(block_undo)

	refute Activity.get_by_id(block.id)
	end

	test "unblocks the blocked user", %{block_undo: block_undo, block: block} do
	blocker = User.get_by_ap_id(block.data["actor"])
	blocked = User.get_by_ap_id(block.data["object"])

	{:ok, _block_undo, _} = SideEffects.handle(block_undo)
	refute User.blocks?(blocker, blocked)
	end

	test "an announce undo removes the announce from the object", %{
	announce_undo: announce_undo,
	post: post
	} do
	{:ok, _announce_undo, _} = SideEffects.handle(announce_undo)

	object = Object.get_by_ap_id(post.data["object"])

	assert object.data["announcement_count"] == 0
	assert object.data["announcements"] == []
	end

	test "deletes the original announce", %{announce_undo: announce_undo, announce: announce} do
	{:ok, _announce_undo, _} = SideEffects.handle(announce_undo)
	refute Activity.get_by_id(announce.id)
	end

	test "a reaction undo removes the reaction from the object", %{
	reaction_undo: reaction_undo,
	post: post
	} do
	{:ok, _reaction_undo, _} = SideEffects.handle(reaction_undo)

	object = Object.get_by_ap_id(post.data["object"])

	assert object.data["reaction_count"] == 0
	assert object.data["reactions"] == []
	end

	test "deletes the original reaction", %{reaction_undo: reaction_undo, reaction: reaction} do
	{:ok, _reaction_undo, _} = SideEffects.handle(reaction_undo)
	refute Activity.get_by_id(reaction.id)
	end

	test "a like undo removes the like from the object", %{like_undo: like_undo, post: post} do
	{:ok, _like_undo, _} = SideEffects.handle(like_undo)

	object = Object.get_by_ap_id(post.data["object"])

	assert object.data["like_count"] == 0
	assert object.data["likes"] == []
	end

	test "deletes the original like", %{like_undo: like_undo, like: like} do
	{:ok, _like_undo, _} = SideEffects.handle(like_undo)
	refute Activity.get_by_id(like.id)
	end
	end

	describe "like objects" do
	setup do
	poster = insert(:user)
	user = insert(:user)
	{:ok, post} = CommonAPI.post(poster, %{status: "hey"})

	{:ok, like_data, _meta} = Builder.like(user, post.object)
	{:ok, like, _meta} = ActivityPub.persist(like_data, local: true)

	%{like: like, user: user, poster: poster}
	end

	test "add the like to the original object", %{like: like, user: user} do
	{:ok, like, _} = SideEffects.handle(like)
	object = Object.get_by_ap_id(like.data["object"])
	assert object.data["like_count"] == 1
	assert user.ap_id in object.data["likes"]
	end

	test "creates a notification", %{like: like, poster: poster} do
	{:ok, like, _} = SideEffects.handle(like)
	assert Repo.get_by(Notification, user_id: poster.id, activity_id: like.id)
	end
	end

	describe "creation of ChatMessages" do
	test "notifies the recipient" do
	author = insert(:user, local: false)
	recipient = insert(:user, local: true)

	{:ok, chat_message_data, _meta} = Builder.chat_message(author, recipient.ap_id, "hey")

	{:ok, create_activity_data, _meta} =
	Builder.create(author, chat_message_data["id"], [recipient.ap_id])

	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, _meta} =
	SideEffects.handle(create_activity, local: false, object_data: chat_message_data)

	assert Repo.get_by(Notification, user_id: recipient.id, activity_id: create_activity.id)
	end

	test "it streams the created ChatMessage" do
	author = insert(:user, local: true)
	recipient = insert(:user, local: true)

	{:ok, chat_message_data, _meta} = Builder.chat_message(author, recipient.ap_id, "hey")

	{:ok, create_activity_data, _meta} =
	Builder.create(author, chat_message_data["id"], [recipient.ap_id])

	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, meta} =
	SideEffects.handle(create_activity, local: false, object_data: chat_message_data)

	assert [_, _] = meta[:streamables]
	end

	test "it creates a Chat and MessageReferences for the local users and bumps the unread count, except for the author" do
	author = insert(:user, local: true)
	recipient = insert(:user, local: true)

	{:ok, chat_message_data, _meta} = Builder.chat_message(author, recipient.ap_id, "hey")

	{:ok, create_activity_data, _meta} =
	Builder.create(author, chat_message_data["id"], [recipient.ap_id])

	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	with_mocks([
	{
	Pleroma.Web.Streamer,
	[],
	[
	stream: fn _, _ -> nil end
	]
	},
	{
	Pleroma.Web.Push,
	[],
	[
	send: fn _ -> nil end
	]
	}
	]) do
	{:ok, _create_activity, meta} =
	SideEffects.handle(create_activity, local: false, object_data: chat_message_data)

	# The notification gets created
	assert [notification] = meta[:notifications]
	assert notification.activity_id == create_activity.id

	# But it is not sent out
	refute called(Pleroma.Web.Streamer.stream(["user", "user:notification"], notification))
	refute called(Pleroma.Web.Push.send(notification))

	# Same for the user chat stream
	assert [{topics, _}, _] = meta[:streamables]
	assert topics == ["user", "user:pleroma_chat"]
	refute called(Pleroma.Web.Streamer.stream(["user", "user:pleroma_chat"], :_))

	chat = Chat.get(author.id, recipient.ap_id)

	[cm_ref] = MessageReference.for_chat_query(chat) \|> Repo.all()

	assert cm_ref.object.data["content"] == "hey"
	assert cm_ref.unread == false

	chat = Chat.get(recipient.id, author.ap_id)

	[cm_ref] = MessageReference.for_chat_query(chat) \|> Repo.all()

	assert cm_ref.object.data["content"] == "hey"
	assert cm_ref.unread == true
	end
	end

	test "it creates a Chat for the local users and bumps the unread count" do
	author = insert(:user, local: false)
	recipient = insert(:user, local: true)

	{:ok, chat_message_data, _meta} = Builder.chat_message(author, recipient.ap_id, "hey")

	{:ok, create_activity_data, _meta} =
	Builder.create(author, chat_message_data["id"], [recipient.ap_id])

	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, _meta} =
	SideEffects.handle(create_activity, local: false, object_data: chat_message_data)

	# An object is created
	assert Object.get_by_ap_id(chat_message_data["id"])

	# The remote user won't get a chat
	chat = Chat.get(author.id, recipient.ap_id)
	refute chat

	# The local user will get a chat
	chat = Chat.get(recipient.id, author.ap_id)
	assert chat

	author = insert(:user, local: true)
	recipient = insert(:user, local: true)

	{:ok, chat_message_data, _meta} = Builder.chat_message(author, recipient.ap_id, "hey")

	{:ok, create_activity_data, _meta} =
	Builder.create(author, chat_message_data["id"], [recipient.ap_id])

	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, _meta} =
	SideEffects.handle(create_activity, local: false, object_data: chat_message_data)

	# Both users are local and get the chat
	chat = Chat.get(author.id, recipient.ap_id)
	assert chat

	chat = Chat.get(recipient.id, author.ap_id)
	assert chat
	end
	end

	describe "announce objects" do
	setup do
	poster = insert(:user)
	user = insert(:user)
	{:ok, post} = CommonAPI.post(poster, %{status: "hey"})
	{:ok, private_post} = CommonAPI.post(poster, %{status: "hey", visibility: "private"})

	- {:ok, announce_data, _meta} = Builder.announce(user, post.object, public: true)
	+ {:ok, announce_data, _meta} = Builder.announce(user, post.object, visibility: "public")

	{:ok, private_announce_data, _meta} =
	- Builder.announce(user, private_post.object, public: false)
	+ Builder.announce(user, private_post.object, visibility: "private")

	{:ok, relay_announce_data, _meta} =
	- Builder.announce(Pleroma.Web.ActivityPub.Relay.get_actor(), post.object, public: true)
	+ Builder.announce(Pleroma.Web.ActivityPub.Relay.get_actor(), post.object,
	+ visibility: "public"
	+ )

	{:ok, announce, _meta} = ActivityPub.persist(announce_data, local: true)
	{:ok, private_announce, _meta} = ActivityPub.persist(private_announce_data, local: true)
	{:ok, relay_announce, _meta} = ActivityPub.persist(relay_announce_data, local: true)

	%{
	announce: announce,
	user: user,
	poster: poster,
	private_announce: private_announce,
	relay_announce: relay_announce
	}
	end

	test "adds the announce to the original object", %{announce: announce, user: user} do
	{:ok, announce, _} = SideEffects.handle(announce)
	object = Object.get_by_ap_id(announce.data["object"])
	assert object.data["announcement_count"] == 1
	assert user.ap_id in object.data["announcements"]
	end

	test "does not add the announce to the original object if the actor is a service actor", %{
	relay_announce: announce
	} do
	{:ok, announce, _} = SideEffects.handle(announce)
	object = Object.get_by_ap_id(announce.data["object"])
	assert object.data["announcement_count"] == nil
	end

	test "creates a notification", %{announce: announce, poster: poster} do
	{:ok, announce, _} = SideEffects.handle(announce)
	assert Repo.get_by(Notification, user_id: poster.id, activity_id: announce.id)
	end
	end

	describe "removing a follower" do
	setup do
	user = insert(:user)
	followed = insert(:user)

	{:ok, _, _, follow_activity} = CommonAPI.follow(followed, user)

	{:ok, reject_data, []} = Builder.reject(followed, follow_activity)
	{:ok, reject, _meta} = ActivityPub.persist(reject_data, local: true)

	%{user: user, followed: followed, reject: reject}
	end

	test "", %{user: user, followed: followed, reject: reject} do
	assert User.following?(user, followed)
	assert Pleroma.FollowingRelationship.get(user, followed)

	{:ok, _, _} = SideEffects.handle(reject)

	refute User.following?(user, followed)
	refute Pleroma.FollowingRelationship.get(user, followed)
	assert User.get_follow_state(user, followed) == nil
	assert User.get_follow_state(user, followed, nil) == nil
	end
	end

	describe "removing a follower from remote" do
	setup do
	user = insert(:user)
	followed = insert(:user, local: false)

	# Mock a local-to-remote follow
	{:ok, follow_data, []} = Builder.follow(user, followed)

	follow_data =
	follow_data
	\|> Map.put("state", "accept")

	{:ok, follow, _meta} = ActivityPub.persist(follow_data, local: true)
	{:ok, _, _} = SideEffects.handle(follow)

	# Mock a remote-to-local accept
	{:ok, accept_data, _} = Builder.accept(followed, follow)
	{:ok, accept, _} = ActivityPub.persist(accept_data, local: false)
	{:ok, _, _} = SideEffects.handle(accept)

	# Mock a remote-to-local reject
	{:ok, reject_data, []} = Builder.reject(followed, follow)
	{:ok, reject, _meta} = ActivityPub.persist(reject_data, local: false)

	%{user: user, followed: followed, reject: reject}
	end

	test "", %{user: user, followed: followed, reject: reject} do
	assert User.following?(user, followed)
	assert Pleroma.FollowingRelationship.get(user, followed)

	{:ok, _, _} = SideEffects.handle(reject)

	refute User.following?(user, followed)
	refute Pleroma.FollowingRelationship.get(user, followed)

	assert Pleroma.Web.ActivityPub.Utils.fetch_latest_follow(user, followed).data["state"] ==
	"reject"

	assert User.get_follow_state(user, followed) == nil
	assert User.get_follow_state(user, followed, nil) == nil
	end
	end

	describe "Group actors" do
	setup do
	poster =
	insert(:user,
	local: false,
	nickname: "poster@example.com",
	ap_id: "https://example.com/users/poster"
	)

	group = insert(:user, actor_type: "Group")

	make_create = fn mentioned_users ->
	mentions = mentioned_users \|> Enum.map(fn u -> "@#{u.nickname}" end) \|> Enum.join(" ")
	{:ok, draft} = ActivityDraft.create(poster, %{status: "#{mentions} hey"})

	create_activity_data =
	Utils.make_create_data(draft.changes \|> Map.put(:published, nil), %{})
	\|> put_in(["object", "id"], "https://example.com/object")
	\|> put_in(["id"], "https://example.com/activity")

	assert Enum.all?(mentioned_users, fn u -> u.ap_id in create_activity_data["to"] end)

	create_activity_data
	end

	%{poster: poster, group: group, make_create: make_create}
	end

	test "group should boost it", %{make_create: make_create, group: group} do
	create_activity_data = make_create.([group])
	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, _meta} =
	SideEffects.handle(create_activity,
	local: false,
	object_data: create_activity_data["object"]
	)

	object = Object.normalize(create_activity, fetch: false)
	assert [announce] = get_announces_of_object(object)
	assert announce.actor == group.ap_id
	end

	test "remote group should not boost it", %{make_create: make_create, group: group} do
	remote_group =
	insert(:user, actor_type: "Group", local: false, nickname: "remotegroup@example.com")

	create_activity_data = make_create.([group, remote_group])
	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, _meta} =
	SideEffects.handle(create_activity,
	local: false,
	object_data: create_activity_data["object"]
	)

	object = Object.normalize(create_activity, fetch: false)
	assert [announce] = get_announces_of_object(object)
	assert announce.actor == group.ap_id
	end

	test "group should not boost it if group is blocking poster", %{
	make_create: make_create,
	group: group,
	poster: poster
	} do
	{:ok, _} = CommonAPI.block(poster, group)
	create_activity_data = make_create.([group])
	{:ok, create_activity, _meta} = ActivityPub.persist(create_activity_data, local: false)

	{:ok, _create_activity, _meta} =
	SideEffects.handle(create_activity,
	local: false,
	object_data: create_activity_data["object"]
	)

	object = Object.normalize(create_activity, fetch: false)
	assert [] = get_announces_of_object(object)
	end
	end
	end

File Metadata

Mime Type: text/x-diff
Expires: Sun, Aug 30, 5:56 AM (1 d, 14 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1737812
Default Alt Text: (96 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions