Page MenuHomePhorge
Files F28687

D125.1726795306.diff
No OneTemporary
Actions

D125.1726795306.diff
View Options

diff --git a/src/contents/ui/Bubble.qml b/src/contents/ui/Bubble.qml
--- a/src/contents/ui/Bubble.qml
+++ b/src/contents/ui/Bubble.qml
@@ -50,6 +50,17 @@
}
}
+ property var confirmDeletionOverlay: Kazv.ConfirmationOverlay {
+ objectName: 'confirmDeletionPopup'
+ parent: roomPage.overlay
+ title: l10n.get('confirm-deletion-popup-title')
+ message: l10n.get('confirm-deletion-popup-message')
+ confirmActionText: l10n.get('confirm-deletion-popup-confirm-action')
+ cancelActionText: l10n.get('confirm-deletion-popup-cancel-action')
+
+ onAccepted: eventView.redactSelf()
+ }
+
function getIsEditable(event) {
return event.sender === matrixSdk.userId
&& event.type === 'm.room.message'
@@ -78,7 +89,7 @@
Kirigami.Action {
objectName: 'deleteMenuItem'
text: l10n.get('event-delete')
- onTriggered: eventView.redactSelf()
+ onTriggered: upper.confirmDeletionOverlay.open()
enabled: event && !event.redacted
},
Kirigami.Action {
diff --git a/src/l10n/cmn-Hans/100-ui.ftl b/src/l10n/cmn-Hans/100-ui.ftl
--- a/src/l10n/cmn-Hans/100-ui.ftl
+++ b/src/l10n/cmn-Hans/100-ui.ftl
@@ -301,3 +301,8 @@
confirm-upload-popup-prompt-single-file = 即将上传「{ $file }」。
confirm-upload-popup-accept-button = 上传
confirm-upload-popup-cancel-button = 取消
+
+confirm-deletion-popup-title = 删除事件
+confirm-deletion-popup-message = 你确定要删除这个事件吗？
+confirm-deletion-popup-confirm-action = 删除
+confirm-deletion-popup-cancel-action = 取消
diff --git a/src/l10n/en/100-ui.ftl b/src/l10n/en/100-ui.ftl
--- a/src/l10n/en/100-ui.ftl
+++ b/src/l10n/en/100-ui.ftl
@@ -322,3 +322,8 @@
confirm-upload-popup-prompt-single-file = You are about to upload "{ $file }".
confirm-upload-popup-accept-button = Upload
confirm-upload-popup-cancel-button = Cancel
+
+confirm-deletion-popup-title = Delete event
+confirm-deletion-popup-message = Are you sure you want to delete this event?
+confirm-deletion-popup-confirm-action = Delete
+confirm-deletion-popup-cancel-action = Cancel
diff --git a/src/tests/quick-tests/tst_EventView.qml b/src/tests/quick-tests/tst_EventView.qml
--- a/src/tests/quick-tests/tst_EventView.qml
+++ b/src/tests/quick-tests/tst_EventView.qml
@@ -391,7 +391,11 @@
const menuComp = findChild(eventViewFailed, 'bubble').menuComp;
const menu = menuComp.createObject(menuComp.parent);
const deleteAction = findChild(menu, 'deleteMenuItem');
+ const deleteConfirmPopup = findChild(eventViewFailed, 'confirmDeletionPopup');
deleteAction.trigger();
+ // For unknown reasons this doesn't pass
+ // tryVerify(() => deleteConfirmPopup.visible);
+ deleteConfirmPopup.accepted();
tryVerify(() => item.room.removeLocalEcho.calledTimes() === 1);
tryVerify(() => item.room.removeLocalEcho.lastArgs()[0] === 'some-txn-id');

File Metadata

Mime Type
text/plain
Expires
Thu, Sep 19, 6:21 PM (9 h, 16 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
16061
Default Alt Text
D125.1726795306.diff (2 KB)

Event Timeline