D253.1765247741.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D253.1765247741.diff
View Options

	diff --git a/lilybuild/lilybuild/ci_steps.py b/lilybuild/lilybuild/ci_steps.py
	--- a/lilybuild/lilybuild/ci_steps.py
	+++ b/lilybuild/lilybuild/ci_steps.py
	@@ -75,18 +75,23 @@
	should_run = False
	for r in job.rules:
	try:
	+ when = r.get('when', 'on_success')
	+ if when == 'never':
	+ should_run_to_set = False
	+ else:
	+ should_run_to_set = True
	+
	rule_str = r.get('if')
	if not rule_str:
	- continue
	+ # No condition == always true
	+ # TODO: `changes` rule
	+ should_run = should_run_to_set
	+ break

	res = ci_rules.evaluate_rule(ci_rules.parse_rule(rule_str), variables)
	if not res:
	continue
	- when = r.get('when', 'on_success')
	- if when == 'never':
	- should_run = False
	- else:
	- should_run = True
	+ should_run = should_run_to_set
	break
	except SyntaxError:
	self.addCompleteLog('error', f'Rule "{rule_str}" has syntax errors')