Page MenuHomePhorge
Differential D57

Fix DeviceListTest, DevicePopupTest and RoomListViewItemDelegateTest
ClosedPublic
Actions

Authored by tusooa on Jun 15 2024, 7:25 PM.
Tags
None
Referenced Files
F113822: D57.1732489163.diff
Sat, Nov 23, 2:59 PM
F113821: D57.1732489159.diff
Sat, Nov 23, 2:59 PM
F113820: D57.1732489155.diff
Sat, Nov 23, 2:59 PM
F113658: D57.1732488391.diff
Sat, Nov 23, 2:46 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK2288d5631166: Fix DeviceListTest, DevicePopupTest and RoomListViewItemDelegateTest
Summary

This fixes DeviceListTest, DevicePopupTest and RoomListViewItemDelegateTest on KF6. These tests failed because the items were clipped.

Type: fix

CCBUG: https://iron.lily-is.land/T85

Test Plan

Verify all tests pass on KF5 and KF6.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jun 15 2024, 7:25 PM
Owners added a reviewer: O1: the Kazv Project.Jun 15 2024, 7:25 PM
tusooa updated this revision to Diff 132.Jun 15 2024, 7:28 PM

Also fix RoomListViewItemDelegateTest

tusooa retitled this revision from Fix DeviceListTest and DevicePopupTest to Fix DeviceListTest, DevicePopupTest and RoomListViewItemDelegateTest.Jun 15 2024, 7:28 PM
tusooa edited the summary of this revision. (Show Details)
tusooa edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B84: Diff 131.Jun 15 2024, 7:34 PM
Harbormaster completed remote builds in B85: Diff 132.Jun 15 2024, 7:40 PM
tusooa requested review of this revision.Jun 15 2024, 7:40 PM
nannanko accepted this revision.Jun 28 2024, 8:13 AM
This revision is now accepted and ready to land.Jun 28 2024, 8:13 AM
Closed by commit rK2288d5631166: Fix DeviceListTest, DevicePopupTest and RoomListViewItemDelegateTest. · Explain WhyJun 28 2024, 11:28 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK2288d5631166: Fix DeviceListTest, DevicePopupTest and RoomListViewItemDelegateTest.

Revision Contents
Changeset List

Diff 174

View Options

src/contents/ui/device-mgmt/Device.qml

Loading...
View Options

src/tests/quick-tests/tst_DeviceList.qml

Loading...
View Options

src/tests/quick-tests/tst_DevicePopup.qml

Loading...
View Options

src/tests/quick-tests/tst_RoomListViewItemDelegate.qml

Loading...