Make SelfDestroyableOverlaySheet work with KF6
ClosedPublic
Actions

Authored by tusooa on Jun 15 2024, 12:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 7, 1:24 PM

	Unknown Object (File)
	Fri, Sep 6, 11:46 PM

	Unknown Object (File)
	Thu, Aug 29, 9:38 AM

	Unknown Object (File)
	Sat, Aug 24, 1:36 PM

	Unknown Object (File)
	Sat, Aug 24, 1:25 AM

	Unknown Object (File)
	Sat, Aug 24, 1:25 AM

	Unknown Object (File)
	Sat, Aug 24, 1:18 AM

	Unknown Object (File)
	Aug 14 2024, 3:59 AM

View All 52 Files

Subscribers

None

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rKc06701b25f98: Make SelfDestroyableOverlaySheet work with KF6

Summary

KF6 Kirigami's OverlaySheet is a QQC2.Popup, which does not has the onSheetOpenChanged signal but has the closed signal. This makes it work with both KF5 and KF6.

Type: fix

CCBUG: https://iron.lily-is.land/T85

Test Plan

Verify that unit tests pass under KF5.

Diff Detail

Repository

rK kazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jun 15 2024, 12:01 PM

Owners added a reviewer: O1: the Kazv Project.Jun 15 2024, 12:01 PM

Harbormaster completed remote builds in B75: Diff 122.Jun 15 2024, 12:10 PM

tusooa requested review of this revision.Jun 15 2024, 12:10 PM

nannanko accepted this revision.Jun 28 2024, 2:02 AM

This revision is now accepted and ready to land.Jun 28 2024, 2:02 AM

Closed by commit rKc06701b25f98: Make SelfDestroyableOverlaySheet work with KF6. · Explain WhyJun 28 2024, 11:28 AM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rKc06701b25f98: Make SelfDestroyableOverlaySheet work with KF6.

Revision Contents
Changeset List

Path

Size

Packages

src/

contents/

ui/

SelfDestroyableOverlaySheet.qml

20 lines

O1: the Kazv Project

Diff 168

View Options

src/contents/ui/SelfDestroyableOverlaySheet.qml

Make SelfDestroyableOverlaySheet work with KF6ClosedPublicActions