Page MenuHomePhorge
Differential D41

Jump to an event when clicking on a reply
ClosedPublic
Actions

Authored by tusooa on Jun 12 2024, 8:17 PM.
Tags
None
Referenced Files
F85665690: D41.1788785734.diff
Sun, Sep 6, 5:55 AM
F85665689: D41.1788785733.diff
Sun, Sep 6, 5:55 AM
F85665688: D41.1788785733.diff
Sun, Sep 6, 5:55 AM
F85665687: D41.1788785723.diff
Sun, Sep 6, 5:55 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKae712c154a85: Jump to an event when clicking on a reply
Summary

This commit implements jumping to the replied-to event when clicking on the quoted content.

Type: add

Test Plan

Verify that unit tests pass.

In the room timeline, click on a replied-to content, verify that the replied-to event is shown and highlighted.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jun 12 2024, 8:17 PM
Owners added a reviewer: O1: the Kazv Project.Jun 12 2024, 8:17 PM
Herald added a reviewer: servant. · View Herald TranscriptJun 12 2024, 8:17 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B65: Diff 112.Jun 12 2024, 8:27 PM
tusooa requested review of this revision.Jun 12 2024, 8:27 PM
tusooa edited the summary of this revision. (Show Details)Jun 12 2024, 8:28 PM
tusooa removed a reviewer: servant.
nannanko accepted this revision.Jun 22 2024, 9:14 AM
This revision is now accepted and ready to land.Jun 22 2024, 9:14 AM
Closed by commit rKae712c154a85: Jump to an event when clicking on a reply. · Explain WhyJun 22 2024, 7:46 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKae712c154a85: Jump to an event when clicking on a reply.

Revision Contents
Changeset List

Diff 142

View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/contents/ui/EventView.qml

Loading...
View Options

src/contents/ui/RoomTimelineView.qml

Loading...
View Options

src/contents/ui/event-types/Simple.qml

Loading...
View Options

src/matrix-room-timeline.hpp

Loading...
View Options

src/matrix-room-timeline.cpp

Loading...
View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/matrix-room-timeline-benchmark-test.cpp

Loading...
View Options

src/tests/matrix-room-timeline-test.cpp

Loading...