Paths

Table of Contentst

Differential D36

Open user page when clicking on a matrix link to a room member
ClosedPublic
Actions

Authored by tusooa on Jun 5 2024, 7:30 PM.

Tags

None

Referenced Files

	F9557: D36.1722176987.diff
	Sat, Jul 27, 7:29 AM

	Unknown Object (File)
	Wed, Jul 24, 3:12 PM

	Unknown Object (File)
	Tue, Jul 23, 1:18 AM

	Unknown Object (File)
	Mon, Jul 22, 10:58 PM

	Unknown Object (File)
	Mon, Jul 22, 10:58 PM

	Unknown Object (File)
	Mon, Jul 22, 10:53 PM

	Unknown Object (File)
	Mon, Jul 22, 10:34 PM

	Unknown Object (File)
	Sun, Jul 14, 4:32 AM

View All 40 Files

Subscribers

None

Details

Reviewers

Group Reviewers

O1: the Kazv Project

Commits

rK567f2f640d2c: Open user page when clicking on a matrix link to a room member

Summary

When clicking on a link, we first check whether it is a link to a user. If it is, we check if it is a room member of the current room. If so, we invoke the user page. Otherwise, open the link as we do for other links.

This behaviour when the pointed-to user is not in the room can be modified in the future to prompt the user to create/open a DM with that user.

Type: add

Test Plan

Mention someone in the room. Click the link. Verify that the user page is opened.
Mention someone not in the room. Click the link. Verify that the matrix.to link is opened in your browser.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jun 5 2024, 7:30 PM

Owners added a reviewer: O1: the Kazv Project.Jun 5 2024, 7:30 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

tusooa edited the summary of this revision. (Show Details)Jun 5 2024, 7:30 PM

tusooa removed a reviewer: servant.

Harbormaster completed remote builds in B60: Diff 102.Jun 5 2024, 7:39 PM

tusooa requested review of this revision.Jun 5 2024, 7:39 PM

nannanko accepted this revision.Jun 8 2024, 7:14 PM

This revision is now accepted and ready to land.Jun 8 2024, 7:14 PM

Closed by commit rK567f2f640d2c: Open user page when clicking on a matrix link to a room member. · Explain WhyJun 8 2024, 10:19 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK567f2f640d2c: Open user page when clicking on a matrix link to a room member.

tusooa mentioned this in T72: Open user page when clicking on a matrix.to link to a user.Fri, Jun 28, 3:00 PM

Revision Contents
Changeset List

Path

Size

Packages

src/

contents/

ui/

event-types/

TextTemplate.qml

31 lines

O1: the Kazv Project

4 lines

O1: the Kazv Project

11 lines

O1: the Kazv Project

tests/

quick-tests/

tst_EventView.qml

36 lines

O1: the Kazv Project

Diff 107

src/contents/ui/event-types/TextTemplate.qml

Loading...

src/kazv-util.hpp

Loading...

src/kazv-util.cpp

Loading...

src/tests/quick-tests/tst_EventView.qml

Loading...