Page MenuHomePhorge

Open user page when clicking on a matrix link to a room member
ClosedPublic

Authored by tusooa on Wed, Jun 5, 7:30 PM.
Tags
None
Referenced Files
F2868: D36.diff
Tue, Jun 11, 9:32 PM
F2854: D36.id102.diff
Tue, Jun 11, 7:32 PM
Unknown Object (File)
Mon, Jun 10, 2:48 PM
Unknown Object (File)
Mon, Jun 10, 11:48 AM
Unknown Object (File)
Sun, Jun 9, 8:20 PM
Unknown Object (File)
Sun, Jun 9, 5:35 PM
Unknown Object (File)
Sun, Jun 9, 11:53 AM
Unknown Object (File)
Sun, Jun 9, 11:53 AM
Subscribers
None

Details

Summary

When clicking on a link, we first check whether it is a link to a user. If it is, we check if it is a room member of the current room. If so, we invoke the user page. Otherwise, open the link as we do for other links.

This behaviour when the pointed-to user is not in the room can be modified in the future to prompt the user to create/open a DM with that user.

Type: add

Test Plan
  • Mention someone in the room. Click the link. Verify that the user page is opened.
  • Mention someone not in the room. Click the link. Verify that the matrix.to link is opened in your browser.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

tusooa removed a reviewer: servant.
tusooa requested review of this revision.Wed, Jun 5, 7:39 PM
This revision is now accepted and ready to land.Sat, Jun 8, 7:14 PM