Page MenuHomePhorge
Differential D338

Refactor room list to use ItemDelegate
ClosedPublic
Actions

Authored by tusooa on Tue, Jul 28, 9:21 PM.
Tags
None
Referenced Files
F85630695: D338.1786243026.diff
Fri, Aug 7, 7:37 PM
F85630694: D338.1786243021.diff
Fri, Aug 7, 7:37 PM
F85630669: D338.1786237651.diff
Fri, Aug 7, 6:07 PM
F85630491: D338.1786224175.diff
Fri, Aug 7, 2:22 PM
F85630490: D338.1786224171.diff
Fri, Aug 7, 2:22 PM
F85630051: D338.1786207817.diff
Fri, Aug 7, 9:50 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKf98786dbed52: Refactor room list to use ItemDelegate
Summary

SwipeListItem is buggy, so port away from it. The favourite indicator is shown as a pure indicator and all actions are moved into the context menu.

Type: add

CCBUG: https://iron.lily-is.land/T175

Test Plan

Check you can invoke the context menu for the RoomListViewItemDelegate via right click (desktop) / long press (mobile).

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Tue, Jul 28, 9:21 PM
Owners added a reviewer: O1: the Kazv Project.Tue, Jul 28, 9:21 PM
Herald added a reviewer: servant. · View Herald TranscriptTue, Jul 28, 9:21 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

tusooa edited the summary of this revision. (Show Details)Tue, Jul 28, 9:21 PM
tusooa removed a reviewer: servant.
tusooa edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B682: Diff 1049.Tue, Jul 28, 9:50 PM
tusooa requested review of this revision.Tue, Jul 28, 9:50 PM
nannanko accepted this revision.Sat, Aug 1, 7:39 PM
This revision is now accepted and ready to land.Sat, Aug 1, 7:39 PM
Closed by commit rKf98786dbed52: Refactor room list to use ItemDelegate. · Explain WhySat, Aug 1, 8:51 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKf98786dbed52: Refactor room list to use ItemDelegate.

Revision Contents
Changeset List

Diff 1056

View Options

CMakeLists.txt

Loading...
View Options

src/contents/ui/RoomListView.qml

Loading...
View Options

src/contents/ui/RoomListViewItemDelegate.qml

Loading...
View Options

src/tests/quick-tests/tst_RoomListViewItemDelegate.qml

Loading...