Differential D337

Query keys for unverifiable olm-encrypted events
ClosedPublic
Actions

Authored by tusooa on Tue, Jul 28, 3:26 PM.

Tags

None

Referenced Files

None

Subscribers

None

Details

Reviewers

Group Reviewers

O1: the Kazv Project

Commits

rL90102d137f78: Query keys for unverifiable olm-encrypted events

Summary

When an encrypted to-device message is unverifiable because there is no associated device key, make the next QueryKeysAction query keys for the sender. This should fix undecryptable events sent from new users that the current session did not yet receive a message from.

Type: fix

BUG: https://iron.lily-is.land/T141

Test Plan

Build kazv against this. Send an encrypted message from a user that this session never shared an encrypted room with. Check you can always decrypt their message.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Tue, Jul 28, 3:26 PM

Owners added a reviewer: O1: the Kazv Project.Tue, Jul 28, 3:26 PM

Harbormaster completed remote builds in B681: Diff 1048.Tue, Jul 28, 3:49 PM

tusooa requested review of this revision.Tue, Jul 28, 3:49 PM

nannanko accepted this revision.Sat, Aug 1, 7:32 PM

This revision is now accepted and ready to land.Sat, Aug 1, 7:32 PM

Closed by commit rL90102d137f78: Query keys for unverifiable olm-encrypted events. · Explain WhySat, Aug 1, 8:52 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL90102d137f78: Query keys for unverifiable olm-encrypted events.

Revision Contents
Changeset List

Path

Size

Packages

src/

client/

actions/

22 lines

O1: the Kazv Project

tests/

client/

encryption-test.cpp

13 lines

O1: the Kazv Project

Diff 1061

src/client/actions/encryption.cpp

Loading...

src/tests/client/encryption-test.cpp

Loading...