Page MenuHomePhorge
Differential D332

Improve video player UI
ClosedPublic
Actions

Authored by tusooa on Sat, Jul 18, 9:05 PM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKb2b0afa22b39: Improve video player UI
Summary

Add a little bit tweak to the UI, including: (1) focus ring to the play button, (2) making the play button focusable, (3) center the triangle in the circle, and (4) a "short-duration" animation for the play button.

Type: add

Test Plan

Verify you can see the above changes.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Sat, Jul 18, 9:05 PM
Owners added a reviewer: O1: the Kazv Project.Sat, Jul 18, 9:05 PM
Herald added a reviewer: servant. · View Herald TranscriptSat, Jul 18, 9:05 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B671: Diff 1030.Sat, Jul 18, 9:33 PM
tusooa requested review of this revision.Sat, Jul 18, 9:33 PM
tusooa edited the summary of this revision. (Show Details)Sat, Jul 18, 9:41 PM
tusooa removed a reviewer: servant.
tusooa updated this revision to Diff 1031.Sun, Jul 19, 8:00 AM

rebase

Harbormaster completed remote builds in B672: Diff 1031.Sun, Jul 19, 8:55 AM
nannanko accepted this revision.Sat, Jul 25, 8:06 PM
This revision is now accepted and ready to land.Sat, Jul 25, 8:06 PM
Closed by commit rKb2b0afa22b39: Improve video player UI. · Explain WhyMon, Jul 27, 10:58 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKb2b0afa22b39: Improve video player UI.

Revision Contents
Changeset List

PathSizePackages
src/
1 lineO1: the Kazv Project
contents/
ui/
event-types/
72 linesO1: the Kazv Project
media/
52 linesO1: the Kazv Project

Diff 1044

View Options

src/CMakeLists.txt

Loading...
View Options

src/contents/ui/event-types/Video.qml

Loading...
View Options

src/contents/ui/media/PlayButton.qml

Loading...