Page MenuHomePhorge
Differential D237

Add purging event support
AcceptedPublic
Actions

Authored by tusooa on Wed, Oct 1, 8:37 PM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Summary

This adds function to purge room events.

Type: add

CCBUG: https://iron.lily-is.land/T165

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rL libkazv
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 471
Build 925: GitLab CI for libkazv
Build 924: arc lint + arc unit

Event Timeline

tusooa created this revision.Wed, Oct 1, 8:37 PM
Owners added a reviewer: O1: the Kazv Project.Wed, Oct 1, 8:37 PM
Harbormaster completed remote builds in B451: Diff 707.Wed, Oct 1, 9:08 PM
tusooa requested review of this revision.Wed, Oct 1, 9:08 PM
nannanko subscribed.Sat, Oct 4, 7:44 PM
nannanko added inline comments.
src/client/room/room-model.hpp
348
tusooa added inline comments.Sun, Oct 5, 7:38 PM
src/client/room/room-model.hpp
348

iff is correct. it means if and only if. using if here will make the return condition incomplete because it does not specify what to return when the invariants are not satisfied.

nannanko accepted this revision.Sun, Oct 5, 10:52 PM
This revision is now accepted and ready to land.Sun, Oct 5, 10:52 PM
tusooa updated this revision to Diff 717.Tue, Oct 7, 2:44 PM

Add tests for purging

tusooa marked an inline comment as done.Tue, Oct 7, 2:45 PM
Harbormaster completed remote builds in B460: Diff 717.Tue, Oct 7, 3:18 PM
tusooa updated this revision to Diff 719.Wed, Oct 8, 3:14 PM

Change action to allow purging multiple rooms

tusooa edited the test plan for this revision. (Show Details)Wed, Oct 8, 3:18 PM
Harbormaster completed remote builds in B461: Diff 719.Wed, Oct 8, 3:44 PM
tusooa updated this revision to Diff 734.Mon, Oct 13, 5:40 PM

Rebase

Harbormaster completed remote builds in B471: Diff 734.Mon, Oct 13, 6:42 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
client/
actions/
1 line--O1: the Kazv Project
11 lines100%
Loading...
O1: the Kazv Project
8 lines92%
Loading...
O1: the Kazv Project
12 lines44%
Loading...
O1: the Kazv Project
5 lines47%
Loading...
O1: the Kazv Project
4 lines--O1: the Kazv Project
room/
25 lines82%
Loading...
O1: the Kazv Project
58 lines94%
Loading...
O1: the Kazv Project
tests/
1 line--O1: the Kazv Project
client/
50 lines--O1: the Kazv Project
room/
169 lines--O1: the Kazv Project

Diff 734

View Options

src/client/actions/storage.hpp

Loading...
View Options

src/client/actions/storage.cpp

Loading...
View Options

src/client/client-model.hpp

Loading...
View Options

src/client/client.hpp

Loading...
View Options

src/client/client.cpp

Loading...
View Options

src/client/clientfwd.hpp

Loading...
View Options

src/client/room/room-model.hpp

Loading...
View Options

src/client/room/room-model.cpp

Loading...
View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/client/action-mock-utils.hpp

Loading...
View Options

src/tests/client/room/purge-test.cpp

Loading...