Page MenuHomePhorge
Differential D208

Use json object instead of QSet for sets
ClosedPublic
Actions

Authored by tusooa on Wed, Dec 18, 2:28 PM.

Details

Reviewers
None
Group Reviewers
O1: the Kazv Project
Commits
rK49a898f6aad6: Use json object instead of QSet for sets
Summary

This is a workaround for a crash that is an upstream Qt bug. Also JS object is more performant in checking whether something exists as an element in the set, as QSet is converted to a JS array when passed to QML.

Type: fix

Upstream: https://bugreports.qt.io/browse/QTBUG-131961

Test Plan

Verify pinning and unpinning events still work. Verify timeline gaps still work.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Wed, Dec 18, 2:28 PM
Owners added a reviewer: O1: the Kazv Project.Wed, Dec 18, 2:28 PM
Harbormaster completed remote builds in B332: Diff 553.Wed, Dec 18, 2:45 PM
tusooa requested review of this revision.Wed, Dec 18, 2:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Dec 18, 5:02 PM
Closed by commit rK49a898f6aad6: Use json object instead of QSet for sets. · Explain Why
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK49a898f6aad6: Use json object instead of QSet for sets.

Revision Contents
Changeset List

Diff 555

View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/contents/ui/EventViewWrapper.qml

Loading...
View Options

src/contents/ui/RoomTimelineView.qml

Loading...
View Options

src/matrix-room-pinned-events-timeline.hpp

Loading...
View Options

src/matrix-room-pinned-events-timeline.cpp

Loading...
View Options

src/matrix-room-timeline.hpp

Loading...
View Options

src/matrix-room-timeline.cpp

Loading...
View Options

src/tests/quick-tests/tst_EventView.qml

Loading...
View Options

src/tests/quick-tests/tst_SendMessageBox.qml

Loading...
View Options

src/tests/quick-tests/tst_SendMessageBoxDrafts.qml

Loading...