Page MenuHomePhorge

Consider local read marker when checking whether a room is read
ClosedPublic

Authored by tusooa on Sat, Nov 16, 5:58 PM.
Tags
None
Referenced Files
F111984: D205.1732246600.diff
Wed, Nov 20, 7:36 PM
F111983: D205.1732246550.diff
Wed, Nov 20, 7:35 PM
F111958: D205.1732220589.diff
Wed, Nov 20, 12:23 PM
F111956: D205.1732218809.diff
Wed, Nov 20, 11:53 AM
F111954: D205.1732217803.diff
Wed, Nov 20, 11:36 AM
Subscribers
None

Details

Summary

This makes kazv consider an event as read when either the local read marker or the remote read receipt from sync has it.

Requires: https://iron.lily-is.land/D204

Type: fix

BUG: https://iron.lily-is.land/T113

Test Plan

Send from another session a message that generates a notification.
Open kazv to receive the message and the notification but do not mark it as read.
Reopen kazv with an invalid proxy (https_proxy=socks5://localhost:12345) such that you cannot make any internet requests, and switch to that room.
Verify the room is marked as read.
Reopen kazv removing the proxy, and switch to that room again. Verify a request is sent to the server updating the read receipt.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Nov 16, 6:19 PM
Harbormaster failed remote builds in B329: Diff 544!
This revision was not accepted when it landed; it landed in state Changes Planned.Sun, Nov 17, 7:43 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.