Page MenuHomePhorge
Differential D184

Set cryptopp as private link lib for libkazvcrypto
AcceptedPublic
Actions

Authored by tusooa on Fri, Sep 13, 7:16 PM.
Tags
None
Referenced Files
F28325: D184.1726780555.diff
Wed, Sep 18, 2:15 PM
F27809: D184.1726729181.diff
Tue, Sep 17, 11:59 PM
Unknown Object (File)
Tue, Sep 17, 2:01 PM
Unknown Object (File)
Sun, Sep 15, 5:12 PM
Unknown Object (File)
Sun, Sep 15, 7:44 AM
Unknown Object (File)
Sun, Sep 15, 7:14 AM
Unknown Object (File)
Sun, Sep 15, 3:42 AM
Unknown Object (File)
Sun, Sep 15, 1:59 AM
View All 9 Files
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Summary

The public interface of libkazvcrypto does not depend on cryptopp. Thus we can remove it from the find_dependency calls.

Type: fix

Test Plan

Verify kazv still compiles under this commit.

Diff Detail

Repository
rL libkazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 292
Build 572: GitLab CI for libkazv
Build 571: arc lint + arc unit

Event Timeline

tusooa created this revision.Fri, Sep 13, 7:16 PM
Owners added a reviewer: O1: the Kazv Project.Fri, Sep 13, 7:16 PM
Herald added a reviewer: servant. · View Herald TranscriptFri, Sep 13, 7:16 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B292: Diff 482.Fri, Sep 13, 7:53 PM
tusooa requested review of this revision.Fri, Sep 13, 7:53 PM
tusooa edited the summary of this revision. (Show Details)Sat, Sep 14, 8:19 AM
tusooa removed a reviewer: servant.
nannanko accepted this revision.Mon, Sep 16, 8:35 AM
This revision is now accepted and ready to land.Mon, Sep 16, 8:35 AM

Revision Contents
Changeset List

Diff 482

View Options

CMakeLists.txt

Loading...
View Options

cmake/libkazvConfig.cmake

Loading...
View Options

src/crypto/CMakeLists.txt

Loading...