Page MenuHomePhorge
Differential D184

Set cryptopp as private link lib for libkazvcrypto
ClosedPublic
Actions

Authored by tusooa on Sep 13 2024, 7:16 PM.
Tags
None
Referenced Files
F465702: D184.1745842381.diff
Sun, Apr 27, 5:13 AM
F464866: D184.1745839461.diff
Sun, Apr 27, 4:24 AM
F462294: D184.1745826921.diff
Sun, Apr 27, 12:55 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rLbc0f306b9a90: Set cryptopp as private link lib for libkazvcrypto
Summary

The public interface of libkazvcrypto does not depend on cryptopp. Thus we can remove it from the find_dependency calls.

Type: fix

Test Plan

Verify kazv still compiles under this commit.

Diff Detail

Repository
rL libkazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Sep 13 2024, 7:16 PM
Owners added a reviewer: O1: the Kazv Project.Sep 13 2024, 7:16 PM
Herald added a reviewer: servant. · View Herald TranscriptSep 13 2024, 7:16 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B292: Diff 482.Sep 13 2024, 7:53 PM
tusooa requested review of this revision.Sep 13 2024, 7:53 PM
tusooa edited the summary of this revision. (Show Details)Sep 14 2024, 8:19 AM
tusooa removed a reviewer: servant.
nannanko accepted this revision.Sep 16 2024, 8:35 AM
This revision is now accepted and ready to land.Sep 16 2024, 8:35 AM
Closed by commit rLbc0f306b9a90: Set cryptopp as private link lib for libkazvcrypto. · Explain WhySep 28 2024, 6:21 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rLbc0f306b9a90: Set cryptopp as private link lib for libkazvcrypto.

Revision Contents
Changeset List

Diff 491

View Options

CMakeLists.txt

Loading...
View Options

cmake/libkazvConfig.cmake

Loading...
View Options

src/crypto/CMakeLists.txt

Loading...