Page MenuHomePhorge

Enable edit room name and relevant tests
AcceptedPublic

Authored by nannanko on Sun, Sep 8, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 17, 11:13 AM
Unknown Object (File)
Mon, Sep 16, 4:00 PM
Unknown Object (File)
Sun, Sep 15, 12:27 PM
Unknown Object (File)
Sun, Sep 15, 11:55 AM
Unknown Object (File)
Sat, Sep 14, 6:46 PM
Unknown Object (File)
Fri, Sep 13, 12:45 PM
Unknown Object (File)
Fri, Sep 13, 3:42 AM
Unknown Object (File)
Thu, Sep 12, 8:34 PM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T120: Edit room name
Summary

This revision enables editing the room name in the room settings page, relevant tests are also added.

Type: add

Test Plan
  • Verify unit tests pass.
  • Open a room settings page and click the edit name button, check that the editing bar is displayed correctly.
  • Type the new room name and click the save name button in the editing bar, wait for completion and check it.
  • Click the discard name button in the editing bar, check that the original room name is displayed correctly.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 291
Build 570: GitLab CI for kazv
Build 569: arc lint + arc unit

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko removed a reviewer: servant.
This revision is now accepted and ready to land.Sat, Sep 14, 8:50 AM