Page MenuHomePhorge
Differential D140

Remove sourceSize from avatar items
ClosedPublic
Actions

Authored by tusooa on Jul 19 2024, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 5, 10:47 AM
Unknown Object (File)
Thu, Sep 5, 10:46 AM
Unknown Object (File)
Thu, Sep 5, 10:45 AM
Unknown Object (File)
Fri, Aug 30, 9:42 AM
Unknown Object (File)
Fri, Aug 30, 9:42 AM
Unknown Object (File)
Fri, Aug 30, 9:42 AM
Unknown Object (File)
Wed, Aug 28, 5:51 PM
Unknown Object (File)
Wed, Aug 28, 5:39 PM
View All 53 Files
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK491a71261872: Remove sourceSize from avatar items
Summary

The Avatar item from Kirigami-Addons.Components will automatically determine the source size, which is calculated properly according to the display size and DPI. This fixes the problem where avatars are blurry.

Type: fix

Test Plan

Using a HiDPI screen, verify that avatars are no longer blurry.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 19 2024, 10:00 AM
Owners added a reviewer: O1: the Kazv Project.Jul 19 2024, 10:00 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2024, 10:05 AM
Harbormaster failed remote builds in B212: Diff 349!
Harbormaster completed remote builds in B212: Diff 349.Jul 19 2024, 8:08 PM
tusooa requested review of this revision.Jul 19 2024, 8:08 PM
nannanko accepted this revision.Jul 24 2024, 12:19 AM
This revision is now accepted and ready to land.Jul 24 2024, 12:19 AM
Closed by commit rK491a71261872: Remove sourceSize from avatar items. · Explain WhyJul 24 2024, 2:34 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK491a71261872: Remove sourceSize from avatar items.

Revision Contents
Changeset List

Diff 371

View Options

src/contents/ui/RoomListViewItemDelegate.qml

Loading...
View Options

src/contents/ui/RoomMemberListViewItemDelegate.qml

Loading...
View Options

src/contents/ui/UserPage.qml

Loading...
View Options

src/contents/ui/event-types/Simple.qml

Loading...
View Options

src/contents/ui/room-settings/RoomSettingsPage.qml

Loading...
View Options

src/contents/ui/settings/ProfileSettings.qml

Loading...