No OneTemporary
Actions

Authored By

Unknown

Size

36 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/lib/pleroma/config/deprecation_warnings.ex b/lib/pleroma/config/deprecation_warnings.ex
	index f38fb7f2f..ee3965b64 100644
	--- a/lib/pleroma/config/deprecation_warnings.ex
	+++ b/lib/pleroma/config/deprecation_warnings.ex
	@@ -1,460 +1,520 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Config.DeprecationWarnings do
	alias Pleroma.Config

	require Logger
	alias Pleroma.Config

	@type config_namespace() :: atom() \| [atom()]
	@type config_map() :: {config_namespace(), config_namespace(), String.t()}

	@mrf_config_map [
	{[:instance, :rewrite_policy], [:mrf, :policies],
	"\n* `config :pleroma, :instance, rewrite_policy` is now `config :pleroma, :mrf, policies`"},
	{[:instance, :mrf_transparency], [:mrf, :transparency],
	"\n* `config :pleroma, :instance, mrf_transparency` is now `config :pleroma, :mrf, transparency`"},
	{[:instance, :mrf_transparency_exclusions], [:mrf, :transparency_exclusions],
	"\n* `config :pleroma, :instance, mrf_transparency_exclusions` is now `config :pleroma, :mrf, transparency_exclusions`"}
	]

	def check_exiftool_filter do
	filters = Config.get([Pleroma.Upload]) \|> Keyword.get(:filters, [])

	if Pleroma.Upload.Filter.Exiftool in filters do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	Your config is using Exiftool as a filter instead of Exiftool.StripLocation. This should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, Pleroma.Upload,
	filters: [Pleroma.Upload.Filter.Exiftool]
	```

	Is now


	```
	config :pleroma, Pleroma.Upload,
	filters: [Pleroma.Upload.Filter.Exiftool.StripLocation]
	```
	""")

	new_config =
	filters
	\|> Enum.map(fn
	Pleroma.Upload.Filter.Exiftool -> Pleroma.Upload.Filter.Exiftool.StripLocation
	filter -> filter
	end)

	Config.put([Pleroma.Upload, :filters], new_config)

	:error
	else
	:ok
	end
	end

	def check_simple_policy_tuples do
	has_strings =
	Config.get([:mrf_simple])
	\|> Enum.any?(fn {_, v} -> Enum.any?(v, &is_binary/1) end)

	if has_strings do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	Your config is using strings in the SimplePolicy configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, :mrf_simple,
	media_removal: ["instance.tld"],
	media_nsfw: ["instance.tld"],
	federated_timeline_removal: ["instance.tld"],
	report_removal: ["instance.tld"],
	reject: ["instance.tld"],
	followers_only: ["instance.tld"],
	accept: ["instance.tld"],
	avatar_removal: ["instance.tld"],
	banner_removal: ["instance.tld"],
	reject_deletes: ["instance.tld"]
	```

	Is now


	```
	config :pleroma, :mrf_simple,
	media_removal: [{"instance.tld", "Reason for media removal"}],
	media_nsfw: [{"instance.tld", "Reason for media nsfw"}],
	federated_timeline_removal: [{"instance.tld", "Reason for federated timeline removal"}],
	report_removal: [{"instance.tld", "Reason for report removal"}],
	reject: [{"instance.tld", "Reason for reject"}],
	followers_only: [{"instance.tld", "Reason for followers only"}],
	accept: [{"instance.tld", "Reason for accept"}],
	avatar_removal: [{"instance.tld", "Reason for avatar removal"}],
	banner_removal: [{"instance.tld", "Reason for banner removal"}],
	reject_deletes: [{"instance.tld", "Reason for reject deletes"}]
	```
	""")

	new_config =
	Config.get([:mrf_simple])
	\|> Enum.map(fn {k, v} ->
	{k,
	Enum.map(v, fn
	{instance, reason} -> {instance, reason}
	instance -> {instance, ""}
	end)}
	end)

	Config.put([:mrf_simple], new_config)

	:error
	else
	:ok
	end
	end

	def check_quarantined_instances_tuples do
	has_strings = Config.get([:instance, :quarantined_instances]) \|> Enum.any?(&is_binary/1)

	if has_strings do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	Your config is using strings in the quarantined_instances configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, :instance,
	quarantined_instances: ["instance.tld"]
	```

	Is now


	```
	config :pleroma, :instance,
	quarantined_instances: [{"instance.tld", "Reason for quarantine"}]
	```
	""")

	new_config =
	Config.get([:instance, :quarantined_instances])
	\|> Enum.map(fn
	{instance, reason} -> {instance, reason}
	instance -> {instance, ""}
	end)

	Config.put([:instance, :quarantined_instances], new_config)

	:error
	else
	:ok
	end
	end

	def check_transparency_exclusions_tuples do
	has_strings = Config.get([:mrf, :transparency_exclusions]) \|> Enum.any?(&is_binary/1)

	if has_strings do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	Your config is using strings in the transparency_exclusions configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, :mrf,
	transparency_exclusions: ["instance.tld"]
	```

	Is now


	```
	config :pleroma, :mrf,
	transparency_exclusions: [{"instance.tld", "Reason to exclude transparency"}]
	```
	""")

	new_config =
	Config.get([:mrf, :transparency_exclusions])
	\|> Enum.map(fn
	{instance, reason} -> {instance, reason}
	instance -> {instance, ""}
	end)

	Config.put([:mrf, :transparency_exclusions], new_config)

	:error
	else
	:ok
	end
	end

	def check_hellthread_threshold do
	if Config.get([:mrf_hellthread, :threshold]) do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	You are using the old configuration mechanism for the hellthread filter. Please check config.md.
	""")

	:error
	else
	:ok
	end
	end

	def warn do
	[
	check_hellthread_threshold(),
	check_old_mrf_config(),
	check_media_proxy_whitelist_config(),
	check_welcome_message_config(),
	check_gun_pool_options(),
	check_activity_expiration_config(),
	check_remote_ip_plug_name(),
	check_uploaders_s3_public_endpoint(),
	check_old_chat_shoutbox(),
	check_quarantined_instances_tuples(),
	check_transparency_exclusions_tuples(),
	check_simple_policy_tuples(),
	check_exiftool_filter(),
	check_deprecated_logger_config()
	]
	\|> Enum.reduce(:ok, fn
	:ok, :ok -> :ok
	_, _ -> :error
	end)
	end

	def check_welcome_message_config do
	instance_config = Pleroma.Config.get([:instance])

	use_old_config =
	Keyword.has_key?(instance_config, :welcome_user_nickname) or
	Keyword.has_key?(instance_config, :welcome_message)

	if use_old_config do
	Logger.error("""
	!!!DEPRECATION WARNING!!!
	Your config is using the old namespace for Welcome messages configuration. You need to convert to the new namespace. e.g.,
	\n* `config :pleroma, :instance, welcome_user_nickname` and `config :pleroma, :instance, welcome_message` are now equal to:
	\n* `config :pleroma, :welcome, direct_message: [enabled: true, sender_nickname: "NICKNAME", message: "Your welcome message"]`"
	""")

	:error
	else
	:ok
	end
	end

	def check_old_mrf_config do
	warning_preface = """
	!!!DEPRECATION WARNING!!!
	Your config is using old namespaces for MRF configuration. They should work for now, but you are advised to change to new namespaces to prevent possible issues later:
	"""

	move_namespace_and_warn(@mrf_config_map, warning_preface)
	end

	@spec move_namespace_and_warn([config_map()], String.t()) :: :ok \| :error
	def move_namespace_and_warn(config_map, warning_preface) do
	warning =
	Enum.reduce(config_map, "", fn
	{old, new, err_msg}, acc ->
	old_config = Config.get(old)

	if old_config do
	Config.put(new, old_config)
	acc <> err_msg
	else
	acc
	end
	end)

	if warning == "" do
	:ok
	else
	Logger.warning(warning_preface <> warning)
	:error
	end
	end

	@spec check_media_proxy_whitelist_config() :: :ok \| :error
	def check_media_proxy_whitelist_config do
	whitelist = Config.get([:media_proxy, :whitelist])

	if Enum.any?(whitelist, &(not String.starts_with?(&1, "http"))) do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	Your config is using old format (only domain) for MediaProxy whitelist option. Setting should work for now, but you are advised to change format to scheme with port to prevent possible issues later.
	""")

	:error
	else
	:ok
	end
	end

	def check_gun_pool_options do
	pool_config = Config.get(:connections_pool)

	if timeout = pool_config[:await_up_timeout] do
	Logger.warning("""
	!!!DEPRECATION WARNING!!!
	Your config is using old setting `config :pleroma, :connections_pool, await_up_timeout`. Please change to `config :pleroma, :connections_pool, connect_timeout` to ensure compatibility with future releases.
	""")

	Config.put(:connections_pool, Keyword.put_new(pool_config, :connect_timeout, timeout))
	end

	pools_configs = Config.get(:pools)

	warning_preface = """
	!!!DEPRECATION WARNING!!!
	Your config is using old setting name `timeout` instead of `recv_timeout` in pool settings. The setting will not take effect until updated.
	"""

	updated_config =
	Enum.reduce(pools_configs, [], fn {pool_name, config}, acc ->
	if timeout = config[:timeout] do
	Keyword.put(acc, pool_name, Keyword.put_new(config, :recv_timeout, timeout))
	else
	acc
	end
	end)

	if updated_config != [] do
	pool_warnings =
	updated_config
	\|> Keyword.keys()
	\|> Enum.map(fn pool_name ->
	"\n* `:timeout` options in #{pool_name} pool is now `:recv_timeout`"
	end)

	Logger.warning(Enum.join([warning_preface \| pool_warnings]))

	Config.put(:pools, updated_config)
	:error
	else
	:ok
	end
	end

	@spec check_activity_expiration_config() :: :ok \| :error
	def check_activity_expiration_config do
	warning_preface = """
	!!!DEPRECATION WARNING!!!
	Your config is using old namespace for activity expiration configuration. Setting should work for now, but you are advised to change to new namespace to prevent possible issues later:
	"""

	move_namespace_and_warn(
	[
	{Pleroma.ActivityExpiration, Pleroma.Workers.PurgeExpiredActivity,
	"\n* `config :pleroma, Pleroma.ActivityExpiration` is now `config :pleroma, Pleroma.Workers.PurgeExpiredActivity`"}
	],
	warning_preface
	)
	end

	@spec check_remote_ip_plug_name() :: :ok \| :error
	def check_remote_ip_plug_name do
	warning_preface = """
	!!!DEPRECATION WARNING!!!
	Your config is using old namespace for RemoteIp Plug. Setting should work for now, but you are advised to change to new namespace to prevent possible issues later:
	"""

	move_namespace_and_warn(
	[
	{Pleroma.Plugs.RemoteIp, Pleroma.Web.Plugs.RemoteIp,
	"\n* `config :pleroma, Pleroma.Plugs.RemoteIp` is now `config :pleroma, Pleroma.Web.Plugs.RemoteIp`"}
	],
	warning_preface
	)
	end

	@spec check_uploaders_s3_public_endpoint() :: :ok \| :error
	def check_uploaders_s3_public_endpoint do
	s3_config = Pleroma.Config.get([Pleroma.Uploaders.S3])

	use_old_config = Keyword.has_key?(s3_config, :public_endpoint)

	if use_old_config do
	Logger.error("""
	!!!DEPRECATION WARNING!!!
	Your config is using the old setting for controlling the URL of media uploaded to your S3 bucket.\n
	Please make the following change at your earliest convenience.\n
	\n* `config :pleroma, Pleroma.Uploaders.S3, public_endpoint` is now equal to:
	\n* `config :pleroma, Pleroma.Upload, base_url`
	""")

	:error
	else
	:ok
	end
	end

	@spec check_old_chat_shoutbox() :: :ok \| :error
	def check_old_chat_shoutbox do
	instance_config = Pleroma.Config.get([:instance])
	chat_config = Pleroma.Config.get([:chat]) \|\| []

	use_old_config =
	Keyword.has_key?(instance_config, :chat_limit) or
	Keyword.has_key?(chat_config, :enabled)

	if use_old_config do
	Logger.error("""
	!!!DEPRECATION WARNING!!!
	Your config is using the old namespace for the Shoutbox configuration. You need to convert to the new namespace. e.g.,
	\n* `config :pleroma, :chat, enabled` and `config :pleroma, :instance, chat_limit` are now equal to:
	\n* `config :pleroma, :shout, enabled` and `config :pleroma, :shout, limit`
	""")

	:error
	else
	:ok
	end
	end

	@spec check_deprecated_logger_config() :: :ok \| :error
	def check_deprecated_logger_config do
	- backend = if Application.get_env(:logger, :backends) do
	- Logger.warning("""
	- !!!DEPRECATION WARNING!!!
	- Your configuration is using deprecated syntax for configuring backends of Elixir's logger.
	- `config :logger, backends: [...]` is deprecated syntax due to changes in Elixir.
	- Please update your configuration at your earliest convenience to use:
	- `config :logger, backends: [...]`
	- Pleroma's default configuration will be updated in the next release which WILL override your settings.
	-
	- Note: `:console` is no longer considered a backend and is used by default, you can disable it using:
	- `config :logger, :default_handler: false`
	- """)
	-
	- true
	- else
	- false
	- end
	-
	- console = if Application.get_env(:logger, :console) do
	- Logger.warning("""
	- !!!DEPRECATION WARNING!!!
	- Your configuration is using deprecated syntax for configuring logging to console.
	- `config :logger, :console` is deprecated syntax due to changes in Elixir.
	- Please update your configuration at your earliest convenience to use
	- `config :logger, default_handler` and `config :logger, :default_formatter`.
	- Pleroma's default configuration will be updated in the next release which WILL override your settings.
	-
	- Note: `:default_handler` is used only for the `level` setting. All other configurations go under
	- `:default_formatter`. For more info visit: https://hexdocs.pm/logger/Logger.html#module-backends-and-backwards-compatibility
	- """)
	-
	- true
	- else
	- false
	- end
	-
	- if backend or console, do: :error, else: :ok
	+ mix_env = Pleroma.Config.get(:env)
	+ config_file_name = "config/#{mix_env}.secret.exs"
	+ config_file = File.read(config_file_name)
	+
	+ config_file =
	+ case config_file do
	+ {:ok, contents} ->
	+ String.split(contents, "\n", trim: true)
	+ \|> Enum.reject(fn string -> String.starts_with?(string, "#") end)
	+ \|> Enum.join("\n")
	+
	+ _ ->
	+ false
	+ end
	+
	+ declared_deprecated_backend =
	+ if is_binary(config_file) do
	+ String.contains?(config_file, "config :logger, backends") or
	+ String.contains?(config_file, "config :logger,\n backends")
	+ else
	+ nil
	+ end
	+
	+ declared_deprecated_console =
	+ if is_binary(config_file) do
	+ String.contains?(config_file, "config :logger, :console") or
	+ String.contains?(config_file, "config :logger,\n console")
	+ else
	+ nil
	+ end
	+
	+ # We can't use Application.get_env/3, because by default default_formatter is populated
	+ declared_new_console =
	+ if is_binary(config_file) do
	+ String.contains?(config_file, "config :logger, :default_handler") or
	+ String.contains?(config_file, "config :logger,\n :default_handler") or
	+ String.contains?(config_file, "config :logger, :default_formatter") or
	+ String.contains?(config_file, "config :logger,\n :default_formatter")
	+ else
	+ nil
	+ end
	+
	+ use_new_backend_config = Pleroma.Config.get([:logger, :backends])
	+
	+ backend =
	+ if declared_deprecated_backend do
	+ Logger.warning("""
	+ !!!DEPRECATION WARNING!!!
	+ Your configuration is using deprecated syntax for configuring backends of Elixir's logger.
	+ `config :logger, backends: [...]` is deprecated syntax due to changes in Elixir.
	+ Please update your configuration at your earliest convenience to use:
	+ `config :logger, backends: [...]`
	+ Pleroma's default configuration will be updated in the next release which WILL override your settings.
	+
	+ Note: `:console` is no longer considered a backend and is used by default, you can disable it using:
	+ `config :logger, :default_handler: false`
	+ """)
	+
	+ true
	+ else
	+ false
	+ end
	+
	+ console =
	+ if declared_deprecated_console do
	+ Logger.warning("""
	+ !!!DEPRECATION WARNING!!!
	+ Your configuration is using deprecated syntax for configuring logging to console.
	+ `config :logger, :console` is deprecated syntax due to changes in Elixir.
	+ Please update your configuration at your earliest convenience to use
	+ `config :logger, default_handler` and `config :logger, :default_formatter`.
	+ Pleroma's default configuration will be updated in the next release which WILL override your settings.
	+
	+ Note: `:default_handler` is used only for the `level` setting. All other configurations go under
	+ `:default_formatter`. For more info visit: https://hexdocs.pm/logger/Logger.html#module-backends-and-backwards-compatibility
	+ """)
	+
	+ true
	+ else
	+ false
	+ end
	+
	+ conflict =
	+ if (!is_nil(use_new_backend_config) and declared_deprecated_backend) or
	+ (declared_new_console and declared_deprecated_console) do
	+ Logger.warning("""
	+ !!!CONFIGURATION CONFLICT!!!
	+ Pleroma has detected that both the deprecated way of configuring Logger and the new way are defined in your configuration.
	+ Delete the deprecated configuration syntax.
	+ """)
	+
	+ true
	+ else
	+ false
	+ end
	+
	+ if backend or console or conflict, do: :error, else: :ok
	end
	end
	diff --git a/test/pleroma/config/deprecation_warnings_test.exs b/test/pleroma/config/deprecation_warnings_test.exs
	index f5b9d76d3..cf2c6b4d2 100644
	--- a/test/pleroma/config/deprecation_warnings_test.exs
	+++ b/test/pleroma/config/deprecation_warnings_test.exs
	@@ -1,435 +1,436 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Config.DeprecationWarningsTest do
	use ExUnit.Case
	use Pleroma.Tests.Helpers

	import ExUnit.CaptureLog

	alias Pleroma.Config
	alias Pleroma.Config.DeprecationWarnings

	describe "filter exiftool" do
	test "gives warning when still used" do
	clear_config(
	[Pleroma.Upload, :filters],
	[Pleroma.Upload.Filter.Exiftool]
	)

	assert capture_log(fn -> DeprecationWarnings.check_exiftool_filter() end) =~
	"""
	!!!DEPRECATION WARNING!!!
	Your config is using Exiftool as a filter instead of Exiftool.StripLocation. This should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, Pleroma.Upload,
	filters: [Pleroma.Upload.Filter.Exiftool]
	```

	Is now


	```
	config :pleroma, Pleroma.Upload,
	filters: [Pleroma.Upload.Filter.Exiftool.StripLocation]
	```
	"""
	end

	test "changes setting to exiftool strip location" do
	clear_config(
	[Pleroma.Upload, :filters],
	[Pleroma.Upload.Filter.Exiftool, Pleroma.Upload.Filter.Exiftool.ReadDescription]
	)

	expected_config = [
	Pleroma.Upload.Filter.Exiftool.StripLocation,
	Pleroma.Upload.Filter.Exiftool.ReadDescription
	]

	capture_log(fn -> DeprecationWarnings.warn() end)

	assert Config.get([Pleroma.Upload]) \|> Keyword.get(:filters, []) == expected_config
	end

	test "doesn't give a warning with correct config" do
	clear_config(
	[Pleroma.Upload, :filters],
	[
	Pleroma.Upload.Filter.Exiftool.StripLocation,
	Pleroma.Upload.Filter.Exiftool.ReadDescription
	]
	)

	assert capture_log(fn -> DeprecationWarnings.check_exiftool_filter() end) == ""
	end
	end

	describe "simple policy tuples" do
	test "gives warning when there are still strings" do
	clear_config([:mrf_simple],
	media_removal: ["some.removal"],
	media_nsfw: ["some.nsfw"],
	federated_timeline_removal: ["some.tl.removal"],
	report_removal: ["some.report.removal"],
	reject: ["some.reject"],
	followers_only: ["some.followers.only"],
	accept: ["some.accept"],
	avatar_removal: ["some.avatar.removal"],
	banner_removal: ["some.banner.removal"],
	reject_deletes: ["some.reject.deletes"]
	)

	assert capture_log(fn -> DeprecationWarnings.check_simple_policy_tuples() end) =~
	"""
	!!!DEPRECATION WARNING!!!
	Your config is using strings in the SimplePolicy configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, :mrf_simple,
	media_removal: ["instance.tld"],
	media_nsfw: ["instance.tld"],
	federated_timeline_removal: ["instance.tld"],
	report_removal: ["instance.tld"],
	reject: ["instance.tld"],
	followers_only: ["instance.tld"],
	accept: ["instance.tld"],
	avatar_removal: ["instance.tld"],
	banner_removal: ["instance.tld"],
	reject_deletes: ["instance.tld"]
	```

	Is now


	```
	config :pleroma, :mrf_simple,
	media_removal: [{"instance.tld", "Reason for media removal"}],
	media_nsfw: [{"instance.tld", "Reason for media nsfw"}],
	federated_timeline_removal: [{"instance.tld", "Reason for federated timeline removal"}],
	report_removal: [{"instance.tld", "Reason for report removal"}],
	reject: [{"instance.tld", "Reason for reject"}],
	followers_only: [{"instance.tld", "Reason for followers only"}],
	accept: [{"instance.tld", "Reason for accept"}],
	avatar_removal: [{"instance.tld", "Reason for avatar removal"}],
	banner_removal: [{"instance.tld", "Reason for banner removal"}],
	reject_deletes: [{"instance.tld", "Reason for reject deletes"}]
	```
	"""
	end

	test "transforms config to tuples" do
	clear_config([:mrf_simple],
	media_removal: ["some.removal", {"some.other.instance", "Some reason"}]
	)

	expected_config =
	{:media_removal, [{"some.removal", ""}, {"some.other.instance", "Some reason"}]}

	capture_log(fn -> DeprecationWarnings.warn() end)

	assert expected_config in Config.get([:mrf_simple])
	end

	test "doesn't give a warning with correct config" do
	clear_config([:mrf_simple],
	media_removal: [{"some.removal", ""}, {"some.other.instance", "Some reason"}]
	)

	assert capture_log(fn -> DeprecationWarnings.check_simple_policy_tuples() end) == ""
	end
	end

	describe "quarantined_instances tuples" do
	test "gives warning when there are still strings" do
	clear_config([:instance, :quarantined_instances], [
	{"domain.com", "some reason"},
	"somedomain.tld"
	])

	assert capture_log(fn -> DeprecationWarnings.check_quarantined_instances_tuples() end) =~
	"""
	!!!DEPRECATION WARNING!!!
	Your config is using strings in the quarantined_instances configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, :instance,
	quarantined_instances: ["instance.tld"]
	```

	Is now


	```
	config :pleroma, :instance,
	quarantined_instances: [{"instance.tld", "Reason for quarantine"}]
	```
	"""
	end

	test "transforms config to tuples" do
	clear_config([:instance, :quarantined_instances], [
	{"domain.com", "some reason"},
	"some.tld"
	])

	expected_config = [{"domain.com", "some reason"}, {"some.tld", ""}]

	capture_log(fn -> DeprecationWarnings.warn() end)

	assert Config.get([:instance, :quarantined_instances]) == expected_config
	end

	test "doesn't give a warning with correct config" do
	clear_config([:instance, :quarantined_instances], [
	{"domain.com", "some reason"},
	{"some.tld", ""}
	])

	assert capture_log(fn -> DeprecationWarnings.check_quarantined_instances_tuples() end) == ""
	end
	end

	describe "transparency_exclusions tuples" do
	test "gives warning when there are still strings" do
	clear_config([:mrf, :transparency_exclusions], [
	{"domain.com", "some reason"},
	"somedomain.tld"
	])

	assert capture_log(fn -> DeprecationWarnings.check_transparency_exclusions_tuples() end) =~
	"""
	!!!DEPRECATION WARNING!!!
	Your config is using strings in the transparency_exclusions configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:

	```
	config :pleroma, :mrf,
	transparency_exclusions: ["instance.tld"]
	```

	Is now


	```
	config :pleroma, :mrf,
	transparency_exclusions: [{"instance.tld", "Reason to exclude transparency"}]
	```
	"""
	end

	test "transforms config to tuples" do
	clear_config([:mrf, :transparency_exclusions], [
	{"domain.com", "some reason"},
	"some.tld"
	])

	expected_config = [{"domain.com", "some reason"}, {"some.tld", ""}]

	capture_log(fn -> DeprecationWarnings.warn() end)

	assert Config.get([:mrf, :transparency_exclusions]) == expected_config
	end

	test "doesn't give a warning with correct config" do
	clear_config([:mrf, :transparency_exclusions], [
	{"domain.com", "some reason"},
	{"some.tld", ""}
	])

	assert capture_log(fn -> DeprecationWarnings.check_transparency_exclusions_tuples() end) ==
	""
	end
	end

	test "check_old_mrf_config/0" do
	clear_config([:instance, :rewrite_policy], [])
	clear_config([:instance, :mrf_transparency], true)
	clear_config([:instance, :mrf_transparency_exclusions], [])

	assert capture_log(fn -> DeprecationWarnings.check_old_mrf_config() end) =~
	"""
	!!!DEPRECATION WARNING!!!
	Your config is using old namespaces for MRF configuration. They should work for now, but you are advised to change to new namespaces to prevent possible issues later:

	* `config :pleroma, :instance, rewrite_policy` is now `config :pleroma, :mrf, policies`
	* `config :pleroma, :instance, mrf_transparency` is now `config :pleroma, :mrf, transparency`
	* `config :pleroma, :instance, mrf_transparency_exclusions` is now `config :pleroma, :mrf, transparency_exclusions`
	"""
	end

	test "move_namespace_and_warn/2" do
	old_group1 = [:group, :key]
	old_group2 = [:group, :key2]
	old_group3 = [:group, :key3]

	new_group1 = [:another_group, :key4]
	new_group2 = [:another_group, :key5]
	new_group3 = [:another_group, :key6]

	clear_config(old_group1, 1)
	clear_config(old_group2, 2)
	clear_config(old_group3, 3)

	clear_config(new_group1)
	clear_config(new_group2)
	clear_config(new_group3)

	config_map = [
	{old_group1, new_group1, "\n error :key"},
	{old_group2, new_group2, "\n error :key2"},
	{old_group3, new_group3, "\n error :key3"}
	]

	assert capture_log(fn ->
	DeprecationWarnings.move_namespace_and_warn(
	config_map,
	"Warning preface"
	)
	end) =~ "Warning preface\n error :key\n error :key2\n error :key3"

	assert Config.get(new_group1) == 1
	assert Config.get(new_group2) == 2
	assert Config.get(new_group3) == 3
	end

	test "check_media_proxy_whitelist_config/0" do
	clear_config([:media_proxy, :whitelist], ["https://example.com", "example2.com"])

	assert capture_log(fn ->
	DeprecationWarnings.check_media_proxy_whitelist_config()
	end) =~ "Your config is using old format (only domain) for MediaProxy whitelist option"
	end

	test "check_welcome_message_config/0" do
	clear_config([:instance, :welcome_user_nickname], "LainChan")

	assert capture_log(fn ->
	DeprecationWarnings.check_welcome_message_config()
	end) =~ "Your config is using the old namespace for Welcome messages configuration."
	end

	test "check_hellthread_threshold/0" do
	clear_config([:mrf_hellthread, :threshold], 16)

	assert capture_log(fn ->
	DeprecationWarnings.check_hellthread_threshold()
	end) =~ "You are using the old configuration mechanism for the hellthread filter."
	end

	test "check_activity_expiration_config/0" do
	clear_config([Pleroma.ActivityExpiration], enabled: true)

	assert capture_log(fn ->
	DeprecationWarnings.check_activity_expiration_config()
	end) =~ "Your config is using old namespace for activity expiration configuration."
	end

	test "check_uploaders_s3_public_endpoint/0" do
	clear_config([Pleroma.Uploaders.S3], public_endpoint: "https://fake.amazonaws.com/bucket/")

	assert capture_log(fn ->
	DeprecationWarnings.check_uploaders_s3_public_endpoint()
	end) =~
	"Your config is using the old setting for controlling the URL of media uploaded to your S3 bucket."
	end

	describe "check_gun_pool_options/0" do
	test "await_up_timeout" do
	config = Config.get(:connections_pool)
	clear_config(:connections_pool, Keyword.put(config, :await_up_timeout, 5_000))

	assert capture_log(fn ->
	DeprecationWarnings.check_gun_pool_options()
	end) =~
	"Your config is using old setting `config :pleroma, :connections_pool, await_up_timeout`."
	end

	test "pool timeout" do
	old_config = [
	federation: [
	size: 50,
	max_waiting: 10,
	timeout: 10_000
	],
	media: [
	size: 50,
	max_waiting: 10,
	timeout: 10_000
	],
	upload: [
	size: 25,
	max_waiting: 5,
	timeout: 15_000
	],
	default: [
	size: 10,
	max_waiting: 2,
	timeout: 5_000
	]
	]

	clear_config(:pools, old_config)

	assert capture_log(fn ->
	DeprecationWarnings.check_gun_pool_options()
	end) =~
	"Your config is using old setting name `timeout` instead of `recv_timeout` in pool settings"
	end
	end

	test "check_old_chat_shoutbox/0" do
	clear_config([:instance, :chat_limit], 1_000)
	clear_config([:chat, :enabled], true)

	assert capture_log(fn ->
	DeprecationWarnings.check_old_chat_shoutbox()
	end) =~
	"Your config is using the old namespace for the Shoutbox configuration."
	end

	describe "check_deprecated_logger_config" do
	setup do
	Application.put_env(:logger, :backends, [:console, {ExSyslogger, :ex_syslogger}])
	Application.put_env(:logger, :console, level: :warning)

	on_exit(fn ->
	Application.delete_env(:logger, :backends)
	Application.delete_env(:logger, :console)
	end)
	end

	test "warns on deprecated syntax" do
	- log = capture_log(fn ->
	- Pleroma.Config.DeprecationWarnings.check_deprecated_logger_config()
	- end)
	+ log =
	+ capture_log(fn ->
	+ Pleroma.Config.DeprecationWarnings.check_deprecated_logger_config()
	+ end)

	assert log =~
	- """
	- !!!DEPRECATION WARNING!!!
	- Your configuration is using deprecated syntax for configuring backends of Elixir's logger.
	- `config :logger, backends: [...]` is deprecated syntax due to changes in Elixir.
	- Please update your configuration at your earliest convenience to use:
	- `config :logger, backends: [...]`
	- Pleroma's default configuration will be updated in the next release which WILL override your settings.
	-
	- Note: `:console` is no longer considered a backend and is used by default, you can disable it using:
	- `config :logger, :default_handler: false`
	- """
	+ """
	+ !!!DEPRECATION WARNING!!!
	+ Your configuration is using deprecated syntax for configuring backends of Elixir's logger.
	+ `config :logger, backends: [...]` is deprecated syntax due to changes in Elixir.
	+ Please update your configuration at your earliest convenience to use:
	+ `config :logger, backends: [...]`
	+ Pleroma's default configuration will be updated in the next release which WILL override your settings.
	+
	+ Note: `:console` is no longer considered a backend and is used by default, you can disable it using:
	+ `config :logger, :default_handler: false`
	+ """

	assert log =~
	- """
	- !!!DEPRECATION WARNING!!!
	- Your configuration is using deprecated syntax for configuring logging to console.
	- `config :logger, :console` is deprecated syntax due to changes in Elixir.
	- Please update your configuration at your earliest convenience to use
	- `config :logger, default_handler` and `config :logger, :default_formatter`.
	- Pleroma's default configuration will be updated in the next release which WILL override your settings.
	-
	- Note: `:default_handler` is used only for the `level` setting. All other configurations go under
	- `:default_formatter`. For more info visit: https://hexdocs.pm/logger/Logger.html#module-backends-and-backwards-compatibility
	- """
	+ """
	+ !!!DEPRECATION WARNING!!!
	+ Your configuration is using deprecated syntax for configuring logging to console.
	+ `config :logger, :console` is deprecated syntax due to changes in Elixir.
	+ Please update your configuration at your earliest convenience to use
	+ `config :logger, default_handler` and `config :logger, :default_formatter`.
	+ Pleroma's default configuration will be updated in the next release which WILL override your settings.
	+
	+ Note: `:default_handler` is used only for the `level` setting. All other configurations go under
	+ `:default_formatter`. For more info visit: https://hexdocs.pm/logger/Logger.html#module-backends-and-backwards-compatibility
	+ """
	end
	end
	end

File Metadata

Mime Type: text/x-diff
Expires: Fri, Oct 30, 12:03 PM (19 h, 59 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1800101
Default Alt Text: (36 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions