No OneTemporary
Actions

Size

26 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/lib/pleroma/gun/connections.ex b/lib/pleroma/gun/connections.ex
	index 60ec68d89..d5a9d8607 100644
	--- a/lib/pleroma/gun/connections.ex
	+++ b/lib/pleroma/gun/connections.ex
	@@ -1,104 +1,125 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.Gun.Connections do
	use GenServer

	@type domain :: String.t()
	@type conn :: Gun.Conn.t()
	@type t :: %__MODULE__{
	conns: %{domain() => conn()}
	}

	defstruct conns: %{}

	def start_link(name \\ __MODULE__) do
	if Application.get_env(:tesla, :adapter) == Tesla.Adapter.Gun do
	GenServer.start_link(__MODULE__, [], name: name)
	else
	:ignore
	end
	end

	@impl true
	def init(_) do
	{:ok, %__MODULE__{conns: %{}}}
	end

	- @spec get_conn(atom(), String.t(), keyword()) :: pid()
	- def get_conn(name \\ __MODULE__, url, opts \\ []) do
	+ @spec get_conn(String.t(), keyword(), atom()) :: pid()
	+ def get_conn(url, opts \\ [], name \\ __MODULE__) do
	opts = Enum.into(opts, %{})
	uri = URI.parse(url)

	opts = if uri.scheme == "https", do: Map.put(opts, :transport, :tls), else: opts

	GenServer.call(
	name,
	{:conn, %{opts: opts, uri: uri}}
	)
	end

	+ # TODO: only for testing, add this parameter to the config
	+ @spec try_to_get_gun_conn(String.t(), keyword(), atom()) :: nil \| pid()
	+ def try_to_get_gun_conn(url, opts \\ [], name \\ __MODULE__),
	+ do: try_to_get_gun_conn(url, opts, name, 0)
	+
	+ @spec try_to_get_gun_conn(String.t(), keyword(), atom(), pos_integer()) :: nil \| pid()
	+ def try_to_get_gun_conn(_url, _, _, 3), do: nil
	+
	+ def try_to_get_gun_conn(url, opts, name, acc) do
	+ case Pleroma.Gun.Connections.get_conn(url, opts, name) do
	+ nil -> try_to_get_gun_conn(url, acc + 1)
	+ conn -> conn
	+ end
	+ end
	+
	+ @spec alive?(atom()) :: boolean()
	+ def alive?(name \\ __MODULE__) do
	+ pid = Process.whereis(name)
	+ if pid, do: Process.alive?(pid), else: false
	+ end
	+
	@spec get_state(atom()) :: t()
	def get_state(name \\ __MODULE__) do
	GenServer.call(name, {:state})
	end

	@impl true
	def handle_call({:conn, %{opts: opts, uri: uri}}, from, state) do
	key = compose_key(uri)

	case state.conns[key] do
	%{conn: conn, state: conn_state} when conn_state == :up ->
	{:reply, conn, state}

	%{state: conn_state, waiting_pids: pids} when conn_state in [:open, :down] ->
	state = put_in(state.conns[key].waiting_pids, [from \| pids])
	{:noreply, state}

	nil ->
	{:ok, conn} = Pleroma.Gun.API.open(to_charlist(uri.host), uri.port, opts)

	state =
	put_in(state.conns[key], %Pleroma.Gun.Conn{
	conn: conn,
	waiting_pids: [from],
	protocol: String.to_atom(uri.scheme)
	})

	{:noreply, state}
	end
	end

	@impl true
	def handle_call({:state}, _from, state), do: {:reply, state, state}

	@impl true
	def handle_info({:gun_up, conn_pid, protocol}, state) do
	{key, conn} = find_conn(state.conns, conn_pid, protocol)

	# Send to all waiting processes connection pid
	Enum.each(conn.waiting_pids, fn waiting_pid -> GenServer.reply(waiting_pid, conn_pid) end)

	# Update state of the current connection and set waiting_pids to empty list
	state = put_in(state.conns[key], %{conn \| state: :up, waiting_pids: []})
	{:noreply, state}
	end

	@impl true
	# Do we need to do something with killed & unprocessed references?
	def handle_info({:gun_down, conn_pid, protocol, _reason, _killed, _unprocessed}, state) do
	{key, conn} = find_conn(state.conns, conn_pid, protocol)

	# We don't want to block requests to GenServer if gun send down message, return nil, so we can make some retries, while connection is not up
	Enum.each(conn.waiting_pids, fn waiting_pid -> GenServer.reply(waiting_pid, nil) end)

	state = put_in(state.conns[key].state, :down)
	{:noreply, state}
	end

	defp compose_key(uri), do: uri.host <> ":" <> to_string(uri.port)

	defp find_conn(conns, conn_pid, protocol),
	do: Enum.find(conns, fn {_, conn} -> conn.conn == conn_pid and conn.protocol == protocol end)
	end
	diff --git a/lib/pleroma/http/http.ex b/lib/pleroma/http/http.ex
	index 6d7934841..1846749c0 100644
	--- a/lib/pleroma/http/http.ex
	+++ b/lib/pleroma/http/http.ex
	@@ -1,86 +1,109 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.HTTP do
	@moduledoc """

	"""

	alias Pleroma.HTTP.Connection
	alias Pleroma.HTTP.RequestBuilder, as: Builder

	@type t :: __MODULE__

	@doc """
	Builds and perform http request.

	# Arguments:
	`method` - :get, :post, :put, :delete
	`url`
	`body`
	`headers` - a keyworld list of headers, e.g. `[{"content-type", "text/plain"}]`
	`options` - custom, per-request middleware or adapter options

	# Returns:
	`{:ok, %Tesla.Env{}}` or `{:error, error}`

	"""
	def request(method, url, body \\ "", headers \\ [], options \\ []) do
	try do
	options =
	process_request_options(options)
	\|> process_sni_options(url)

	+ adapter_gun? = Application.get_env(:tesla, :adapter) == Tesla.Adapter.Gun
	+
	+ options =
	+ if adapter_gun? and Pleroma.Gun.Connections.alive?() do
	+ get_conn_for_gun(url, options)
	+ else
	+ options
	+ end
	+
	params = Keyword.get(options, :params, [])

	%{}
	\|> Builder.method(method)
	\|> Builder.headers(headers)
	\|> Builder.opts(options)
	\|> Builder.url(url)
	\|> Builder.add_param(:body, :body, body)
	\|> Builder.add_param(:query, :query, params)
	\|> Enum.into([])
	\|> (&Tesla.request(Connection.new(options), &1)).()
	rescue
	e ->
	{:error, e}
	catch
	:exit, e ->
	{:error, e}
	end
	end

	+ defp get_conn_for_gun(url, options) do
	+ case Pleroma.Gun.Connections.try_to_get_gun_conn(url) do
	+ nil ->
	+ options
	+
	+ conn ->
	+ adapter_opts =
	+ Keyword.get(options, :adapter, [])
	+ \|> Keyword.put(:conn, conn)
	+
	+ Keyword.put(options, :adapter, adapter_opts)
	+ end
	+ end
	+
	defp process_sni_options(options, nil), do: options

	defp process_sni_options(options, url) do
	uri = URI.parse(url)
	host = uri.host \|> to_charlist()

	case uri.scheme do
	"https" -> options ++ [ssl: [server_name_indication: host]]
	_ -> options
	end
	end

	def process_request_options(options) do
	Keyword.merge(Pleroma.HTTP.Connection.options([]), options)
	end

	@doc """
	Performs GET request.

	See `Pleroma.HTTP.request/5`
	"""
	def get(url, headers \\ [], options \\ []),
	do: request(:get, url, "", headers, options)

	@doc """
	Performs POST request.

	See `Pleroma.HTTP.request/5`
	"""
	def post(url, body, headers \\ [], options \\ []),
	do: request(:post, url, body, headers, options)
	end
	diff --git a/test/gun/connections_test.exs b/test/gun/connections_test.exs
	index 2ec8f3993..42354d330 100644
	--- a/test/gun/connections_test.exs
	+++ b/test/gun/connections_test.exs
	@@ -1,172 +1,205 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Gun.ConnectionsTest do
	- use ExUnit.Case, async: true
	+ use ExUnit.Case
	alias Pleroma.Gun.{Connections, Conn, API}

	setup do
	name = :test_gun_connections
	+ adapter = Application.get_env(:tesla, :adapter)
	+ Application.put_env(:tesla, :adapter, Tesla.Adapter.Gun)
	+ on_exit(fn -> Application.put_env(:tesla, :adapter, adapter) end)
	{:ok, pid} = Connections.start_link(name)

	{:ok, name: name, pid: pid}
	end

	+ describe "alive?/2" do
	+ test "is alive", %{name: name} do
	+ assert Connections.alive?(name)
	+ end
	+
	+ test "returns false if not started" do
	+ refute Connections.alive?(:some_random_name)
	+ end
	+ end
	+
	+ test "try_to_get_gun_conn/1 returns conn", %{name: name, pid: pid} do
	+ conn = Connections.try_to_get_gun_conn("http://some-domain.com", [genserver_pid: pid], name)
	+ assert is_pid(conn)
	+ assert Process.alive?(conn)
	+
	+ reused_conn = Connections.get_conn("http://some-domain.com", [genserver_pid: pid], name)
	+
	+ assert conn == reused_conn
	+
	+ %Connections{
	+ conns: %{
	+ "some-domain.com:80" => %Conn{
	+ conn: ^conn,
	+ state: :up,
	+ waiting_pids: []
	+ }
	+ }
	+ } = Connections.get_state(name)
	+ end
	+
	test "opens connection and reuse it on next request", %{name: name, pid: pid} do
	- conn = Connections.get_conn(name, "http://some-domain.com", genserver_pid: pid)
	+ conn = Connections.get_conn("http://some-domain.com", [genserver_pid: pid], name)

	assert is_pid(conn)
	assert Process.alive?(conn)

	- reused_conn = Connections.get_conn(name, "http://some-domain.com", genserver_pid: pid)
	+ reused_conn = Connections.get_conn("http://some-domain.com", [genserver_pid: pid], name)

	assert conn == reused_conn

	%Connections{
	conns: %{
	"some-domain.com:80" => %Conn{
	conn: ^conn,
	state: :up,
	waiting_pids: []
	}
	}
	} = Connections.get_state(name)
	end

	test "reuses connection based on protocol", %{name: name, pid: pid} do
	- conn = Connections.get_conn(name, "http://some-domain.com", genserver_pid: pid)
	+ conn = Connections.get_conn("http://some-domain.com", [genserver_pid: pid], name)
	assert is_pid(conn)
	assert Process.alive?(conn)

	- https_conn = Connections.get_conn(name, "https://some-domain.com", genserver_pid: pid)
	+ https_conn = Connections.get_conn("https://some-domain.com", [genserver_pid: pid], name)

	refute conn == https_conn

	- reused_https = Connections.get_conn(name, "https://some-domain.com", genserver_pid: pid)
	+ reused_https = Connections.get_conn("https://some-domain.com", [genserver_pid: pid], name)

	refute conn == reused_https

	assert reused_https == https_conn

	%Connections{
	conns: %{
	"some-domain.com:80" => %Conn{
	conn: ^conn,
	state: :up,
	waiting_pids: []
	},
	"some-domain.com:443" => %Conn{
	conn: ^https_conn,
	state: :up,
	waiting_pids: []
	}
	}
	} = Connections.get_state(name)
	end

	test "process gun_down message", %{name: name, pid: pid} do
	- conn = Connections.get_conn(name, "http://gun_down.com", genserver_pid: pid)
	+ conn = Connections.get_conn("http://gun_down.com", [genserver_pid: pid], name)

	refute conn

	%Connections{
	conns: %{
	"gun_down.com:80" => %Conn{
	conn: _,
	state: :down,
	waiting_pids: _
	}
	}
	} = Connections.get_state(name)
	end

	test "process gun_down message and then gun_up", %{name: name, pid: pid} do
	- conn = Connections.get_conn(name, "http://gun_down_and_up.com", genserver_pid: pid)
	+ conn = Connections.get_conn("http://gun_down_and_up.com", [genserver_pid: pid], name)

	refute conn

	%Connections{
	conns: %{
	"gun_down_and_up.com:80" => %Conn{
	conn: _,
	state: :down,
	waiting_pids: _
	}
	}
	} = Connections.get_state(name)

	- conn = Connections.get_conn(name, "http://gun_down_and_up.com", genserver_pid: pid)
	+ conn = Connections.get_conn("http://gun_down_and_up.com", [genserver_pid: pid], name)

	assert is_pid(conn)
	assert Process.alive?(conn)

	%Connections{
	conns: %{
	"gun_down_and_up.com:80" => %Conn{
	conn: _,
	state: :up,
	waiting_pids: []
	}
	}
	} = Connections.get_state(name)
	end

	test "async processes get same conn for same domain", %{name: name, pid: pid} do
	tasks =
	for _ <- 1..5 do
	Task.async(fn ->
	- Connections.get_conn(name, "http://some-domain.com", genserver_pid: pid)
	+ Connections.get_conn("http://some-domain.com", [genserver_pid: pid], name)
	end)
	end

	tasks_with_results = Task.yield_many(tasks)

	results =
	Enum.map(tasks_with_results, fn {task, res} ->
	res \|\| Task.shutdown(task, :brutal_kill)
	end)

	conns = for {:ok, value} <- results, do: value

	%Connections{
	conns: %{
	"some-domain.com:80" => %Conn{
	conn: conn,
	state: :up,
	waiting_pids: []
	}
	}
	} = Connections.get_state(name)

	assert Enum.all?(conns, fn res -> res == conn end)
	end

	describe "integration test" do
	@describetag :integration

	test "opens connection and reuse it on next request", %{name: name} do
	api = Pleroma.Config.get([API])
	Pleroma.Config.put([API], :gun)
	on_exit(fn -> Pleroma.Config.put([API], api) end)
	- conn = Connections.get_conn(name, "http://httpbin.org")
	+ conn = Connections.get_conn("http://httpbin.org", [], name)

	assert is_pid(conn)
	assert Process.alive?(conn)

	- reused_conn = Connections.get_conn(name, "http://httpbin.org")
	+ reused_conn = Connections.get_conn("http://httpbin.org", [], name)

	assert conn == reused_conn

	%Connections{
	conns: %{
	"httpbin.org:80" => %Conn{
	conn: ^conn,
	state: :up,
	waiting_pids: []
	}
	}
	} = Connections.get_state(name)
	end
	end
	end
	diff --git a/test/reverse_proxy/reverse_proxy_test.exs b/test/reverse_proxy/reverse_proxy_test.exs
	index 56ac8672b..2092b0dc3 100644
	--- a/test/reverse_proxy/reverse_proxy_test.exs
	+++ b/test/reverse_proxy/reverse_proxy_test.exs
	@@ -1,369 +1,374 @@
	# Pleroma: A lightweight social networking server
	# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
	# SPDX-License-Identifier: AGPL-3.0-only

	defmodule Pleroma.ReverseProxyTest do
	- use Pleroma.Web.ConnCase, async: true
	+ use Pleroma.Web.ConnCase
	import ExUnit.CaptureLog
	import Mox
	alias Pleroma.ReverseProxy
	alias Pleroma.ReverseProxy.ClientMock

	setup_all do
	{:ok, _} = Registry.start_link(keys: :unique, name: Pleroma.ReverseProxy.ClientMock)
	:ok
	end

	setup :verify_on_exit!

	defp user_agent_mock(user_agent, invokes) do
	json = Jason.encode!(%{"user-agent": user_agent})

	ClientMock
	\|> expect(:request, fn :get, url, _, _, _ ->
	Registry.register(Pleroma.ReverseProxy.ClientMock, url, 0)

	{:ok, 200,
	[
	{"content-type", "application/json"},
	{"content-length", byte_size(json) \|> to_string()}
	], %{url: url}}
	end)
	\|> expect(:stream_body, invokes, fn %{url: url} = client ->
	case Registry.lookup(Pleroma.ReverseProxy.ClientMock, url) do
	[{_, 0}] ->
	Registry.update_value(Pleroma.ReverseProxy.ClientMock, url, &(&1 + 1))
	{:ok, json, client}

	[{_, 1}] ->
	Registry.unregister(Pleroma.ReverseProxy.ClientMock, url)
	:done
	end
	end)
	end

	describe "user-agent" do
	test "don't keep", %{conn: conn} do
	user_agent_mock("hackney/1.15.1", 2)
	conn = ReverseProxy.call(conn, "/user-agent")
	assert json_response(conn, 200) == %{"user-agent" => "hackney/1.15.1"}
	end

	test "keep", %{conn: conn} do
	user_agent_mock(Pleroma.Application.user_agent(), 2)
	conn = ReverseProxy.call(conn, "/user-agent-keep", keep_user_agent: true)
	assert json_response(conn, 200) == %{"user-agent" => Pleroma.Application.user_agent()}
	end
	end

	test "closed connection", %{conn: conn} do
	ClientMock
	\|> expect(:request, fn :get, "/closed", _, _, _ -> {:ok, 200, [], %{}} end)
	\|> expect(:stream_body, fn _ -> {:error, :closed} end)
	\|> expect(:close, fn _ -> :ok end)

	conn = ReverseProxy.call(conn, "/closed")
	assert conn.halted
	end

	defp stream_mock(invokes, with_close? \\ false) do
	ClientMock
	\|> expect(:request, fn :get, "/stream-bytes/" <> length, _, _, _ ->
	Registry.register(Pleroma.ReverseProxy.ClientMock, "/stream-bytes/" <> length, 0)

	{:ok, 200, [{"content-type", "application/octet-stream"}],
	%{url: "/stream-bytes/" <> length}}
	end)
	\|> expect(:stream_body, invokes, fn %{url: "/stream-bytes/" <> length} = client ->
	max = String.to_integer(length)

	case Registry.lookup(Pleroma.ReverseProxy.ClientMock, "/stream-bytes/" <> length) do
	[{_, current}] when current < max ->
	Registry.update_value(
	Pleroma.ReverseProxy.ClientMock,
	"/stream-bytes/" <> length,
	&(&1 + 10)
	)

	{:ok, "0123456789", client}

	[{_, ^max}] ->
	Registry.unregister(Pleroma.ReverseProxy.ClientMock, "/stream-bytes/" <> length)
	:done
	end
	end)

	if with_close? do
	expect(ClientMock, :close, fn _ -> :ok end)
	end
	end

	describe "max_body " do
	test "length returns error if content-length more than option", %{conn: conn} do
	user_agent_mock("hackney/1.15.1", 0)

	assert capture_log(fn ->
	ReverseProxy.call(conn, "/user-agent", max_body_length: 4)
	end) =~
	"[error] Elixir.Pleroma.ReverseProxy: request to \"/user-agent\" failed: :body_too_large"
	end

	defp stream_mock(invokes, with_close? \\ false) do
	ClientMock
	\|> expect(:request, fn :get, "/stream-bytes/" <> length, _, _, _ ->
	Registry.register(Pleroma.ReverseProxy.ClientMock, "/stream-bytes/" <> length, 0)

	{:ok, 200, [{"content-type", "application/octet-stream"}],
	%{url: "/stream-bytes/" <> length}}
	end)
	\|> expect(:stream_body, invokes, fn %{url: "/stream-bytes/" <> length} ->
	max = String.to_integer(length)

	case Registry.lookup(Pleroma.ReverseProxy.ClientMock, "/stream-bytes/" <> length) do
	[{_, current}] when current < max ->
	Registry.update_value(
	Pleroma.ReverseProxy.ClientMock,
	"/stream-bytes/" <> length,
	&(&1 + 10)
	)

	{:ok, "0123456789"}

	[{_, ^max}] ->
	Registry.unregister(Pleroma.ReverseProxy.ClientMock, "/stream-bytes/" <> length)
	:done
	end
	end)

	if with_close? do
	expect(ClientMock, :close, fn _ -> :ok end)
	end
	end

	test "max_body_length returns error if streaming body more than that option", %{conn: conn} do
	stream_mock(3, true)

	assert capture_log(fn ->
	ReverseProxy.call(conn, "/stream-bytes/50", max_body_length: 30)
	end) =~
	"[warn] Elixir.Pleroma.ReverseProxy request to /stream-bytes/50 failed while reading/chunking: :body_too_large"
	end
	end

	describe "HEAD requests" do
	test "common", %{conn: conn} do
	ClientMock
	\|> expect(:request, fn :head, "/head", _, _, _ ->
	{:ok, 200, [{"content-type", "text/html; charset=utf-8"}]}
	end)

	conn = ReverseProxy.call(Map.put(conn, :method, "HEAD"), "/head")
	assert html_response(conn, 200) == ""
	end
	end

	defp error_mock(status) when is_integer(status) do
	ClientMock
	\|> expect(:request, fn :get, "/status/" <> _, _, _, _ ->
	{:error, status}
	end)
	end

	describe "returns error on" do
	test "500", %{conn: conn} do
	error_mock(500)

	capture_log(fn -> ReverseProxy.call(conn, "/status/500") end) =~
	"[error] Elixir.Pleroma.ReverseProxy: request to /status/500 failed with HTTP status 500"
	end

	test "400", %{conn: conn} do
	error_mock(400)

	capture_log(fn -> ReverseProxy.call(conn, "/status/400") end) =~
	"[error] Elixir.Pleroma.ReverseProxy: request to /status/400 failed with HTTP status 400"
	end

	test "204", %{conn: conn} do
	ClientMock
	\|> expect(:request, fn :get, "/status/204", _, _, _ -> {:ok, 204, [], %{}} end)

	capture_log(fn ->
	conn = ReverseProxy.call(conn, "/status/204")
	assert conn.resp_body == "Request failed: No Content"
	assert conn.halted
	end) =~
	"[error] Elixir.Pleroma.ReverseProxy: request to \"/status/204\" failed with HTTP status 204"
	end
	end

	test "streaming", %{conn: conn} do
	stream_mock(21)
	conn = ReverseProxy.call(conn, "/stream-bytes/200")
	assert conn.state == :chunked
	assert byte_size(conn.resp_body) == 200
	assert Plug.Conn.get_resp_header(conn, "content-type") == ["application/octet-stream"]
	end

	defp headers_mock(_) do
	ClientMock
	\|> expect(:request, fn :get, "/headers", headers, _, _ ->
	Registry.register(Pleroma.ReverseProxy.ClientMock, "/headers", 0)
	{:ok, 200, [{"content-type", "application/json"}], %{url: "/headers", headers: headers}}
	end)
	\|> expect(:stream_body, 2, fn %{url: url, headers: headers} = client ->
	case Registry.lookup(Pleroma.ReverseProxy.ClientMock, url) do
	[{_, 0}] ->
	Registry.update_value(Pleroma.ReverseProxy.ClientMock, url, &(&1 + 1))
	headers = for {k, v} <- headers, into: %{}, do: {String.capitalize(k), v}
	{:ok, Jason.encode!(%{headers: headers}), client}

	[{_, 1}] ->
	Registry.unregister(Pleroma.ReverseProxy.ClientMock, url)
	:done
	end
	end)

	:ok
	end

	describe "keep request headers" do
	setup [:headers_mock]

	test "header passes", %{conn: conn} do
	conn =
	Plug.Conn.put_req_header(
	conn,
	"accept",
	"text/html"
	)
	\|> ReverseProxy.call("/headers")

	%{"headers" => headers} = json_response(conn, 200)
	assert headers["Accept"] == "text/html"
	end

	test "header is filtered", %{conn: conn} do
	conn =
	Plug.Conn.put_req_header(
	conn,
	"accept-language",
	"en-US"
	)
	\|> ReverseProxy.call("/headers")

	%{"headers" => headers} = json_response(conn, 200)
	refute headers["Accept-Language"]
	end
	end

	test "returns 400 on non GET, HEAD requests", %{conn: conn} do
	conn = ReverseProxy.call(Map.put(conn, :method, "POST"), "/ip")
	assert conn.status == 400
	end

	describe "cache resp headers" do
	test "returns headers", %{conn: conn} do
	ClientMock
	\|> expect(:request, fn :get, "/cache/" <> ttl, _, _, _ ->
	{:ok, 200, [{"cache-control", "public, max-age=" <> ttl}], %{}}
	end)
	\|> expect(:stream_body, fn _ -> :done end)

	conn = ReverseProxy.call(conn, "/cache/10")
	assert {"cache-control", "public, max-age=10"} in conn.resp_headers
	end

	test "add cache-control", %{conn: conn} do
	ClientMock
	\|> expect(:request, fn :get, "/cache", _, _, _ ->
	{:ok, 200, [{"ETag", "some ETag"}], %{}}
	end)
	\|> expect(:stream_body, fn _ -> :done end)

	conn = ReverseProxy.call(conn, "/cache")
	assert {"cache-control", "public"} in conn.resp_headers
	end
	end

	defp disposition_headers_mock(headers) do
	ClientMock
	\|> expect(:request, fn :get, "/disposition", _, _, _ ->
	Registry.register(Pleroma.ReverseProxy.ClientMock, "/disposition", 0)

	{:ok, 200, headers, %{url: "/disposition"}}
	end)
	\|> expect(:stream_body, 2, fn %{url: "/disposition"} = client ->
	case Registry.lookup(Pleroma.ReverseProxy.ClientMock, "/disposition") do
	[{_, 0}] ->
	Registry.update_value(Pleroma.ReverseProxy.ClientMock, "/disposition", &(&1 + 1))
	{:ok, "", client}

	[{_, 1}] ->
	Registry.unregister(Pleroma.ReverseProxy.ClientMock, "/disposition")
	:done
	end
	end)
	end

	describe "response content disposition header" do
	test "not atachment", %{conn: conn} do
	disposition_headers_mock([
	{"content-type", "image/gif"},
	{"content-length", 0}
	])

	conn = ReverseProxy.call(conn, "/disposition")

	assert {"content-type", "image/gif"} in conn.resp_headers
	end

	test "with content-disposition header", %{conn: conn} do
	disposition_headers_mock([
	{"content-disposition", "attachment; filename=\"filename.jpg\""},
	{"content-length", 0}
	])

	conn = ReverseProxy.call(conn, "/disposition")

	assert {"content-disposition", "attachment; filename=\"filename.jpg\""} in conn.resp_headers
	end
	end

	describe "integration tests" do
	@describetag :integration

	test "with hackney client", %{conn: conn} do
	client = Pleroma.Config.get([Pleroma.ReverseProxy.Client])
	Pleroma.Config.put([Pleroma.ReverseProxy.Client], Pleroma.ReverseProxy.Client.Hackney)

	on_exit(fn ->
	Pleroma.Config.put([Pleroma.ReverseProxy.Client], client)
	end)

	conn = ReverseProxy.call(conn, "http://httpbin.org/stream-bytes/10")

	assert byte_size(conn.resp_body) == 10
	assert conn.state == :chunked
	assert conn.status == 200
	end

	test "with tesla client with gun adapter", %{conn: conn} do
	client = Pleroma.Config.get([Pleroma.ReverseProxy.Client])
	Pleroma.Config.put([Pleroma.ReverseProxy.Client], Pleroma.ReverseProxy.Client.Tesla)
	adapter = Application.get_env(:tesla, :adapter)
	Application.put_env(:tesla, :adapter, Tesla.Adapter.Gun)

	+ api = Pleroma.Config.get([Pleroma.Gun.API])
	+ Pleroma.Config.put([Pleroma.Gun.API], :gun)
	+ {:ok, _} = Pleroma.Gun.Connections.start_link(Pleroma.Gun.Connections)
	+
	conn = ReverseProxy.call(conn, "http://httpbin.org/stream-bytes/10")

	assert byte_size(conn.resp_body) == 10
	assert conn.state == :chunked
	assert conn.status == 200

	on_exit(fn ->
	Pleroma.Config.put([Pleroma.ReverseProxy.Client], client)
	Application.put_env(:tesla, :adapter, adapter)
	+ Pleroma.Config.put([Pleroma.Gun.API], api)
	end)
	end
	end
	end

File Metadata

Mime Type: text/x-diff
Expires: Sat, Oct 10, 6:09 PM (1 d, 8 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1785384
Default Alt Text: (26 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions